acouzens
/
open5gs
1
0
Fork 1
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Fix buffer length calculation in s1ap_copy_ie 

The aper_encode function returns the number of encoded bits and when
converting to bytes we should round up or use the ((.encoded + 7) / 8)
formula as described in per_encoder.h

Fixes: #257
This commit is contained in:
Vasil Velichkov 2019-08-26 17:05:25 +03:00
parent 282231a77f
commit c1a0f897b1
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mme/s1ap-conv.c
View File

@ -190,7 +190,7 @@ int s1ap_copy_ie(const asn_TYPE_descriptor_t *td, void *src, void *dst)
}
dec_ret = aper_decode(NULL, td, (void **)&dst,
buffer, (enc_ret.encoded >> 3), 0, 0);
buffer, ((enc_ret.encoded + 7) / 8), 0, 0);
if (dec_ret.code != RC_OK) {
ogs_error("aper_decode() failed[%d]", dec_ret.code);

2
tests/unit/crash-test.c
View File

@ -375,9 +375,7 @@ abts_suite *test_crash(abts_suite *suite)
suite = ADD_SUITE(suite)
abts_run_test(suite, test1_func, NULL);
#if 0
abts_run_test(suite, test2_func, NULL);
#endif
abts_run_test(suite, test3_func, NULL);
return suite;