linux/debian/patches-rt/0166-tty-serial-pl011-expli...

46 lines
1.6 KiB
Diff
Raw Normal View History

From f6bc04fdefa31a35588c0b33de38fd26a8640e38 Mon Sep 17 00:00:00 2001
2018-10-30 12:40:05 +00:00
From: Kurt Kanzenbach <kurt@linutronix.de>
Date: Mon, 24 Sep 2018 10:29:01 +0200
Subject: [PATCH 166/325] tty: serial: pl011: explicitly initialize the flags
2019-04-08 23:49:20 +00:00
variable
2018-10-30 12:40:05 +00:00
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.19/older/patches-4.19.115-rt48.tar.xz
2018-10-30 12:40:05 +00:00
Silence the following gcc warning:
drivers/tty/serial/amba-pl011.c: In function pl011_console_write:
./include/linux/spinlock.h:260:3: warning: flags may be used uninitialized in this function [-Wmaybe-uninitialized]
_raw_spin_unlock_irqrestore(lock, flags); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/tty/serial/amba-pl011.c:2214:16: note: flags was declared here
unsigned long flags;
^~~~~
The code is correct. Thus, initializing flags to zero doesn't change the
behavior and resolves the warning.
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
2019-04-08 23:49:20 +00:00
drivers/tty/serial/amba-pl011.c | 2 +-
2018-10-30 12:40:05 +00:00
1 file changed, 1 insertion(+), 1 deletion(-)
2019-04-08 23:49:20 +00:00
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
2020-01-03 23:36:11 +00:00
index 183e8b731d6a..2cc6b24bc88d 100644
2018-10-30 12:40:05 +00:00
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
2020-01-03 23:36:11 +00:00
@@ -2209,7 +2209,7 @@ pl011_console_write(struct console *co, const char *s, unsigned int count)
2018-10-30 12:40:05 +00:00
{
struct uart_amba_port *uap = amba_ports[co->index];
unsigned int old_cr = 0, new_cr;
- unsigned long flags;
+ unsigned long flags = 0;
int locked = 1;
clk_enable(uap->clk);
2020-01-03 23:36:11 +00:00
--
2020-04-09 19:44:24 +00:00
2.25.1
2020-01-03 23:36:11 +00:00