2019-08-18 21:33:52 +00:00
|
|
|
From: kbuild test robot <lkp@intel.com>
|
|
|
|
|
Date: Sat, 13 Apr 2019 11:22:51 +0800
|
2019-11-25 00:04:39 +00:00
|
|
|
Subject: [PATCH 273/290] pci/switchtec: fix stream_open.cocci warnings
|
|
|
|
|
Origin: https://git.kernel.org/cgit/linux/kernel/git/rt/linux-stable-rt.git/commit?id=163db421a90c12f33a0d3033405d56f8be864abb
|
2019-08-18 21:33:52 +00:00
|
|
|
|
|
|
|
|
[ Upstream commit 9462c69e29307adc95c289f50839d5d683973891 ]
|
|
|
|
|
|
|
|
|
|
drivers/pci/switch/switchtec.c:395:1-17: ERROR: switchtec_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix.
|
|
|
|
|
|
|
|
|
|
Generated by: scripts/coccinelle/api/stream_open.cocci
|
|
|
|
|
|
|
|
|
|
Cc: Kirill Smelkov <kirr@nexedi.com>
|
|
|
|
|
Cc: Julia Lawall <julia.lawall@lip6.fr>
|
|
|
|
|
Fixes: 8a29a3bae2a2 ("pci/switchtec: Don't use completion's wait queue")
|
|
|
|
|
Cc: stable-rt@vger.kernel.org # where it applies to
|
|
|
|
|
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1904131849350.2536@hadrien
|
|
|
|
|
Signed-off-by: kbuild test robot <lkp@intel.com>
|
|
|
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
|
|
|
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
|
|
|
|
|
---
|
|
|
|
|
drivers/pci/switch/switchtec.c | 2 +-
|
|
|
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
|
|
|
|
|
|
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
|
|
|
|
|
index 77d4fb86d05b..ea70bc0b06e9 100644
|
|
|
|
|
--- a/drivers/pci/switch/switchtec.c
|
|
|
|
|
+++ b/drivers/pci/switch/switchtec.c
|
|
|
|
|
@@ -360,7 +360,7 @@ static int switchtec_dev_open(struct inode *inode, struct file *filp)
|
|
|
|
|
return PTR_ERR(stuser);
|
|
|
|
|
|
|
|
|
|
filp->private_data = stuser;
|
|
|
|
|
- nonseekable_open(inode, filp);
|
|
|
|
|
+ stream_open(inode, filp);
|
|
|
|
|
|
|
|
|
|
dev_dbg(&stdev->dev, "%s: %p\n", __func__, stuser);
|
|
|
|
|
|
