2020-09-04 20:10:21 +00:00
|
|
|
From f18664825ba891cf54d1b2df85b0661f25cdccb9 Mon Sep 17 00:00:00 2001
|
|
|
|
Message-Id: <f18664825ba891cf54d1b2df85b0661f25cdccb9.1599166691.git.zanussi@kernel.org>
|
|
|
|
In-Reply-To: <56457dc415803c8abc5acb513ada877a79596f05.1599166690.git.zanussi@kernel.org>
|
|
|
|
References: <56457dc415803c8abc5acb513ada877a79596f05.1599166690.git.zanussi@kernel.org>
|
2020-02-21 18:07:43 +00:00
|
|
|
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
|
|
Date: Thu, 12 Dec 2019 10:53:59 +0100
|
2020-09-04 20:10:21 +00:00
|
|
|
Subject: [PATCH 314/333] sched: migrate_enable: Busy loop until the migration
|
2020-02-21 18:07:43 +00:00
|
|
|
request is completed
|
2020-09-04 20:10:21 +00:00
|
|
|
Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.19/older/patches-4.19.142-rt63.tar.xz
|
2020-02-21 18:07:43 +00:00
|
|
|
|
|
|
|
[ Upstream commit 140d7f54a5fff02898d2ca9802b39548bf7455f1 ]
|
|
|
|
|
|
|
|
If user task changes the CPU affinity mask of a running task it will
|
|
|
|
dispatch migration request if the current CPU is no longer allowed. This
|
|
|
|
might happen shortly before a task enters a migrate_disable() section.
|
|
|
|
Upon leaving the migrate_disable() section, the task will notice that
|
|
|
|
the current CPU is no longer allowed and will will dispatch its own
|
|
|
|
migration request to move it off the current CPU.
|
|
|
|
While invoking __schedule() the first migration request will be
|
|
|
|
processed and the task returns on the "new" CPU with "arg.done = 0". Its
|
|
|
|
own migration request will be processed shortly after and will result in
|
|
|
|
memory corruption if the stack memory, designed for request, was used
|
|
|
|
otherwise in the meantime.
|
|
|
|
|
|
|
|
Spin until the migration request has been processed if it was accepted.
|
|
|
|
|
|
|
|
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
|
|
|
|
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
|
|
|
|
---
|
|
|
|
kernel/sched/core.c | 7 +++++--
|
|
|
|
1 file changed, 5 insertions(+), 2 deletions(-)
|
|
|
|
|
|
|
|
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
|
2020-08-28 04:53:35 +00:00
|
|
|
index 2509cb37531d..ab34c573b79c 100644
|
2020-02-21 18:07:43 +00:00
|
|
|
--- a/kernel/sched/core.c
|
|
|
|
+++ b/kernel/sched/core.c
|
2020-08-28 04:53:35 +00:00
|
|
|
@@ -7324,7 +7324,7 @@ void migrate_enable(void)
|
2020-02-21 18:07:43 +00:00
|
|
|
|
|
|
|
WARN_ON(smp_processor_id() != cpu);
|
|
|
|
if (!is_cpu_allowed(p, cpu)) {
|
|
|
|
- struct migration_arg arg = { p };
|
|
|
|
+ struct migration_arg arg = { .task = p };
|
|
|
|
struct cpu_stop_work work;
|
|
|
|
struct rq_flags rf;
|
|
|
|
|
2020-08-28 04:53:35 +00:00
|
|
|
@@ -7337,7 +7337,10 @@ void migrate_enable(void)
|
2020-02-21 18:07:43 +00:00
|
|
|
&arg, &work);
|
|
|
|
tlb_migrate_finish(p->mm);
|
|
|
|
__schedule(true);
|
|
|
|
- WARN_ON_ONCE(!arg.done && !work.disabled);
|
|
|
|
+ if (!work.disabled) {
|
|
|
|
+ while (!arg.done)
|
|
|
|
+ cpu_relax();
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
|
|
|
|
out:
|
|
|
|
--
|
2020-06-22 13:14:16 +00:00
|
|
|
2.17.1
|
2020-02-21 18:07:43 +00:00
|
|
|
|