40 lines
1.5 KiB
Diff
40 lines
1.5 KiB
Diff
From f0fb46cca3273252efbb9671e781f6d0b31f05fb Mon Sep 17 00:00:00 2001
|
|
From: David Woodhouse <dwmw2@infradead.org>
|
|
Date: Thu, 3 Dec 2009 05:47:11 -0300
|
|
Subject: [PATCH 018/120] V4L/DVB (13716): [Mantis] Bug: incorrect byte swap
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
You know, the worst endianness errors are not the cases where
|
|
people forget to byte-swap, but the cases where they either byte-swap
|
|
with the wrong size, or byte-swap when they shouldn't have done so at
|
|
all. Those ones defeat the casual reader of the code.
|
|
|
|
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
|
|
Signed-off-by: Manu Abraham <manu@linuxtv.org>
|
|
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
|
(cherry picked from commit 417036844823313901d7f7d7b963f215cc3b0641)
|
|
|
|
Signed-off-by: Bjørn Mork <bjorn@mork.no>
|
|
---
|
|
drivers/media/dvb/mantis/mantis_dma.c | 2 +-
|
|
1 files changed, 1 insertions(+), 1 deletions(-)
|
|
|
|
diff --git a/drivers/media/dvb/mantis/mantis_dma.c b/drivers/media/dvb/mantis/mantis_dma.c
|
|
index ea23a89..f685992 100644
|
|
--- a/drivers/media/dvb/mantis/mantis_dma.c
|
|
+++ b/drivers/media/dvb/mantis/mantis_dma.c
|
|
@@ -189,7 +189,7 @@ void mantis_dma_start(struct mantis_pci *mantis)
|
|
dprintk(verbose, MANTIS_DEBUG, 1, "Mantis Start DMA engine");
|
|
|
|
mantis_risc_program(mantis);
|
|
- mmwrite(cpu_to_le32(mantis->risc_dma), MANTIS_RISC_START);
|
|
+ mmwrite(mantis->risc_dma, MANTIS_RISC_START);
|
|
mmwrite(mmread(MANTIS_GPIF_ADDR) | MANTIS_GPIF_RDWRN, MANTIS_GPIF_ADDR);
|
|
|
|
mmwrite(0, MANTIS_DMA_CTL);
|
|
--
|
|
1.7.1
|
|
|