40 lines
1.4 KiB
Diff
40 lines
1.4 KiB
Diff
From: Vasiliy Kulikov <segoon@openwall.com>
|
|
Date: Fri, 4 Feb 2011 15:23:59 +0300
|
|
Subject: [PATCH 8/9] platform: x86: asus_acpi: world-writable procfs files
|
|
|
|
commit e75b7eb5716256c52a123a467be25fb5e03fa930 upstream.
|
|
|
|
Don't allow everybody to change ACPI settings. The comment says that it
|
|
is done deliberatelly, however, the comment before disp_proc_write()
|
|
says that at least one of these setting is experimental.
|
|
|
|
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
|
|
Signed-off-by: Matthew Garrett <mjg@redhat.com>
|
|
---
|
|
drivers/platform/x86/asus_acpi.c | 8 +-------
|
|
1 files changed, 1 insertions(+), 7 deletions(-)
|
|
|
|
diff --git a/drivers/platform/x86/asus_acpi.c b/drivers/platform/x86/asus_acpi.c
|
|
index 4633fd8..fe49593 100644
|
|
--- a/drivers/platform/x86/asus_acpi.c
|
|
+++ b/drivers/platform/x86/asus_acpi.c
|
|
@@ -1081,14 +1081,8 @@ static int asus_hotk_add_fs(struct acpi_device *device)
|
|
struct proc_dir_entry *proc;
|
|
mode_t mode;
|
|
|
|
- /*
|
|
- * If parameter uid or gid is not changed, keep the default setting for
|
|
- * our proc entries (-rw-rw-rw-) else, it means we care about security,
|
|
- * and then set to -rw-rw----
|
|
- */
|
|
-
|
|
if ((asus_uid == 0) && (asus_gid == 0)) {
|
|
- mode = S_IFREG | S_IRUGO | S_IWUGO;
|
|
+ mode = S_IFREG | S_IRUGO | S_IWUSR | S_IWGRP;
|
|
} else {
|
|
mode = S_IFREG | S_IRUSR | S_IRGRP | S_IWUSR | S_IWGRP;
|
|
printk(KERN_WARNING " asus_uid and asus_gid parameters are "
|
|
--
|
|
1.7.2.3
|
|
|