29 lines
1010 B
Diff
29 lines
1010 B
Diff
From: Kangjie Lu <kangjielu@gmail.com>
|
|
Date: Tue, 3 May 2016 16:44:32 -0400
|
|
Subject: [2/2] ALSA: timer: Fix leak in events via snd_timer_user_tinterrupt
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
Origin: https://git.kernel.org/linus/e4ec8cc8039a7063e24204299b462bd1383184a5
|
|
|
|
The stack object “r1” has a total size of 32 bytes. Its field
|
|
“event” and “val” both contain 4 bytes padding. These 8 bytes
|
|
padding bytes are sent to user without being initialized.
|
|
|
|
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
|
|
Signed-off-by: Takashi Iwai <tiwai@suse.de>
|
|
---
|
|
sound/core/timer.c | 1 +
|
|
1 file changed, 1 insertion(+)
|
|
|
|
--- a/sound/core/timer.c
|
|
+++ b/sound/core/timer.c
|
|
@@ -1290,6 +1290,7 @@ static void snd_timer_user_tinterrupt(st
|
|
}
|
|
if ((tu->filter & (1 << SNDRV_TIMER_EVENT_RESOLUTION)) &&
|
|
tu->last_resolution != resolution) {
|
|
+ memset(&r1, 0, sizeof(r1));
|
|
r1.event = SNDRV_TIMER_EVENT_RESOLUTION;
|
|
r1.tstamp = tstamp;
|
|
r1.val = resolution;
|