160 lines
4.8 KiB
Diff
160 lines
4.8 KiB
Diff
Subject: workqueue: Use local irq lock instead of irq disable regions
|
|
From: Thomas Gleixner <tglx@linutronix.de>
|
|
Date: Sun, 17 Jul 2011 21:42:26 +0200
|
|
Origin: https://www.kernel.org/pub/linux/kernel/projects/rt/4.14/older/patches-4.14-rt1.tar.xz
|
|
|
|
Use a local_irq_lock as a replacement for irq off regions. We keep the
|
|
semantic of irq-off in regard to the pool->lock and remain preemptible.
|
|
|
|
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
|
|
---
|
|
kernel/workqueue.c | 36 ++++++++++++++++++++++--------------
|
|
1 file changed, 22 insertions(+), 14 deletions(-)
|
|
|
|
--- a/kernel/workqueue.c
|
|
+++ b/kernel/workqueue.c
|
|
@@ -48,6 +48,7 @@
|
|
#include <linux/nodemask.h>
|
|
#include <linux/moduleparam.h>
|
|
#include <linux/uaccess.h>
|
|
+#include <linux/locallock.h>
|
|
|
|
#include "workqueue_internal.h"
|
|
|
|
@@ -351,6 +352,8 @@ EXPORT_SYMBOL_GPL(system_power_efficient
|
|
struct workqueue_struct *system_freezable_power_efficient_wq __read_mostly;
|
|
EXPORT_SYMBOL_GPL(system_freezable_power_efficient_wq);
|
|
|
|
+static DEFINE_LOCAL_IRQ_LOCK(pendingb_lock);
|
|
+
|
|
static int worker_thread(void *__worker);
|
|
static void workqueue_sysfs_unregister(struct workqueue_struct *wq);
|
|
|
|
@@ -1104,9 +1107,11 @@ static void put_pwq_unlocked(struct pool
|
|
* As both pwqs and pools are RCU protected, the
|
|
* following lock operations are safe.
|
|
*/
|
|
- spin_lock_irq(&pwq->pool->lock);
|
|
+ rcu_read_lock();
|
|
+ local_spin_lock_irq(pendingb_lock, &pwq->pool->lock);
|
|
put_pwq(pwq);
|
|
- spin_unlock_irq(&pwq->pool->lock);
|
|
+ local_spin_unlock_irq(pendingb_lock, &pwq->pool->lock);
|
|
+ rcu_read_unlock();
|
|
}
|
|
}
|
|
|
|
@@ -1210,7 +1215,7 @@ static int try_to_grab_pending(struct wo
|
|
struct worker_pool *pool;
|
|
struct pool_workqueue *pwq;
|
|
|
|
- local_irq_save(*flags);
|
|
+ local_lock_irqsave(pendingb_lock, *flags);
|
|
|
|
/* try to steal the timer if it exists */
|
|
if (is_dwork) {
|
|
@@ -1274,7 +1279,7 @@ static int try_to_grab_pending(struct wo
|
|
spin_unlock(&pool->lock);
|
|
fail:
|
|
rcu_read_unlock();
|
|
- local_irq_restore(*flags);
|
|
+ local_unlock_irqrestore(pendingb_lock, *flags);
|
|
if (work_is_canceling(work))
|
|
return -ENOENT;
|
|
cpu_relax();
|
|
@@ -1379,7 +1384,7 @@ static void __queue_work(int cpu, struct
|
|
* queued or lose PENDING. Grabbing PENDING and queueing should
|
|
* happen with IRQ disabled.
|
|
*/
|
|
- WARN_ON_ONCE(!irqs_disabled());
|
|
+ WARN_ON_ONCE_NONRT(!irqs_disabled());
|
|
|
|
debug_work_activate(work);
|
|
|
|
@@ -1485,14 +1490,14 @@ bool queue_work_on(int cpu, struct workq
|
|
bool ret = false;
|
|
unsigned long flags;
|
|
|
|
- local_irq_save(flags);
|
|
+ local_lock_irqsave(pendingb_lock,flags);
|
|
|
|
if (!test_and_set_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(work))) {
|
|
__queue_work(cpu, wq, work);
|
|
ret = true;
|
|
}
|
|
|
|
- local_irq_restore(flags);
|
|
+ local_unlock_irqrestore(pendingb_lock, flags);
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(queue_work_on);
|
|
@@ -1501,8 +1506,11 @@ void delayed_work_timer_fn(unsigned long
|
|
{
|
|
struct delayed_work *dwork = (struct delayed_work *)__data;
|
|
|
|
+ /* XXX */
|
|
+ /* local_lock(pendingb_lock); */
|
|
/* should have been called from irqsafe timer with irq already off */
|
|
__queue_work(dwork->cpu, dwork->wq, &dwork->work);
|
|
+ /* local_unlock(pendingb_lock); */
|
|
}
|
|
EXPORT_SYMBOL(delayed_work_timer_fn);
|
|
|
|
@@ -1558,14 +1566,14 @@ bool queue_delayed_work_on(int cpu, stru
|
|
unsigned long flags;
|
|
|
|
/* read the comment in __queue_work() */
|
|
- local_irq_save(flags);
|
|
+ local_lock_irqsave(pendingb_lock, flags);
|
|
|
|
if (!test_and_set_bit(WORK_STRUCT_PENDING_BIT, work_data_bits(work))) {
|
|
__queue_delayed_work(cpu, wq, dwork, delay);
|
|
ret = true;
|
|
}
|
|
|
|
- local_irq_restore(flags);
|
|
+ local_unlock_irqrestore(pendingb_lock, flags);
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(queue_delayed_work_on);
|
|
@@ -1600,7 +1608,7 @@ bool mod_delayed_work_on(int cpu, struct
|
|
|
|
if (likely(ret >= 0)) {
|
|
__queue_delayed_work(cpu, wq, dwork, delay);
|
|
- local_irq_restore(flags);
|
|
+ local_unlock_irqrestore(pendingb_lock, flags);
|
|
}
|
|
|
|
/* -ENOENT from try_to_grab_pending() becomes %true */
|
|
@@ -2950,7 +2958,7 @@ static bool __cancel_work_timer(struct w
|
|
|
|
/* tell other tasks trying to grab @work to back off */
|
|
mark_work_canceling(work);
|
|
- local_irq_restore(flags);
|
|
+ local_unlock_irqrestore(pendingb_lock, flags);
|
|
|
|
/*
|
|
* This allows canceling during early boot. We know that @work
|
|
@@ -3011,10 +3019,10 @@ EXPORT_SYMBOL_GPL(cancel_work_sync);
|
|
*/
|
|
bool flush_delayed_work(struct delayed_work *dwork)
|
|
{
|
|
- local_irq_disable();
|
|
+ local_lock_irq(pendingb_lock);
|
|
if (del_timer_sync(&dwork->timer))
|
|
__queue_work(dwork->cpu, dwork->wq, &dwork->work);
|
|
- local_irq_enable();
|
|
+ local_unlock_irq(pendingb_lock);
|
|
return flush_work(&dwork->work);
|
|
}
|
|
EXPORT_SYMBOL(flush_delayed_work);
|
|
@@ -3032,7 +3040,7 @@ static bool __cancel_work(struct work_st
|
|
return false;
|
|
|
|
set_work_pool_and_clear_pending(work, get_work_pool_id(work));
|
|
- local_irq_restore(flags);
|
|
+ local_unlock_irqrestore(pendingb_lock, flags);
|
|
return ret;
|
|
}
|
|
|