[IMP] models: improve code of _convert_to_write(), make it easier to read

This commit is contained in:
Raphael Collet 2014-08-18 14:19:24 +02:00
parent 221b746c7f
commit 01e647b57d
1 changed files with 7 additions and 7 deletions

View File

@ -5135,13 +5135,13 @@ class BaseModel(object):
def _convert_to_write(self, values): def _convert_to_write(self, values):
""" Convert the `values` dictionary into the format of :meth:`write`. """ """ Convert the `values` dictionary into the format of :meth:`write`. """
fields = self._fields fields = self._fields
return dict( result = {}
(name, write_value) for name, value in values.iteritems():
for name, value in values.iteritems() if name in fields:
if name in self._fields value = fields[name].convert_to_write(value)
for write_value in [fields[name].convert_to_write(value)] if not isinstance(value, NewId):
if not isinstance(write_value, NewId) result[name] = value
) return result
# #
# Record traversal and update # Record traversal and update