From 067e0b882748fb2b426155ab873f660be4081246 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Tue, 6 Sep 2011 11:31:39 +0200
Subject: [PATCH] [FIX] implicit globals: missing 'var' declarations

did not touch gantt.js, this thing's a swap, there are implicit globals which are actually used globally

bzr revid: xmo@openerp.com-20110906093139-uermn7a9vo38l3kf
---
 addons/web/static/src/js/boot.js                 |  4 ++--
 addons/web/static/src/js/core.js                 |  2 +-
 addons/web/static/src/js/data.js                 |  2 +-
 addons/web_gantt/static/src/js/gantt.js          |  2 +-
 addons/web_mobile/static/src/js/chrome_mobile.js | 14 +++++++-------
 addons/web_mobile/static/src/js/form_mobile.js   |  6 +++---
 addons/web_mobile/static/src/js/list_mobile.js   |  4 ++--
 addons/web_mobile/static/src/web_mobile.html     |  5 +++--
 8 files changed, 20 insertions(+), 19 deletions(-)

diff --git a/addons/web/static/src/js/boot.js b/addons/web/static/src/js/boot.js
index c5d8bbfc1ca..2c00eb3d5a5 100644
--- a/addons/web/static/src/js/boot.js
+++ b/addons/web/static/src/js/boot.js
@@ -56,8 +56,8 @@ openerp.web = function(instance) {
     openerp.web.formats(instance);
     openerp.web.chrome(instance);
     openerp.web.data(instance);
-    files = ["views","search","list","form","list_editable","web_mobile","view_tree","data_export"];
-    for(i=0; i<files.length; i++) {
+    var files = ["views","search","list","form","list_editable","web_mobile","view_tree","data_export"];
+    for(var i=0; i<files.length; i++) {
         if(openerp.web[files[i]]) {
             openerp.web[files[i]](instance);
         }
diff --git a/addons/web/static/src/js/core.js b/addons/web/static/src/js/core.js
index c228d06db56..78fb1761ef7 100644
--- a/addons/web/static/src/js/core.js
+++ b/addons/web/static/src/js/core.js
@@ -553,7 +553,7 @@ openerp.web.Session = openerp.web.CallbackEnabled.extend( /** @lends openerp.web
         this.rpc('/web/session/modules', {}, function(result) {
             self.module_list = result;
             var lang = self.user_context.lang;
-            params = { mods: ["web"].concat(result), lang: lang};
+            var params = { mods: ["web"].concat(result), lang: lang};
             self.rpc('/web/webclient/translations',params).then(function(transs) {
                 openerp.web._t.database.set_bundle(transs);
                 var modules = self.module_list.join(',');
diff --git a/addons/web/static/src/js/data.js b/addons/web/static/src/js/data.js
index 7a57a2b728f..3797121756f 100644
--- a/addons/web/static/src/js/data.js
+++ b/addons/web/static/src/js/data.js
@@ -622,7 +622,7 @@ openerp.web.BufferedDataSet = openerp.web.DataSetStatic.extend({
         record = record || _.detect(this.to_write, function(x) {return x.id === id;});
         var dirty = false;
         if (record) {
-            for (k in data) {
+            for (var k in data) {
                 if (record.values[k] === undefined || record.values[k] !== data[k]) {
                     dirty = true;
                     break;
diff --git a/addons/web_gantt/static/src/js/gantt.js b/addons/web_gantt/static/src/js/gantt.js
index cecaf711ebd..a2da2d99671 100644
--- a/addons/web_gantt/static/src/js/gantt.js
+++ b/addons/web_gantt/static/src/js/gantt.js
@@ -233,7 +233,7 @@ init: function(parent, element_id, dataset, view_id) {
             evt_date = all_events[evt_id]['evt'][2];
             evt_duration = all_events[evt_id]['evt'][3];
 
-            evt_str_date = this.convert_date_str(evt_date);
+            var evt_str_date = this.convert_date_str(evt_date);
             evt_end_date = this.end_date(evt_str_date, evt_duration);
 
             while (all_events[evt_id]['parent'] != "") {
diff --git a/addons/web_mobile/static/src/js/chrome_mobile.js b/addons/web_mobile/static/src/js/chrome_mobile.js
index 1f78c602a7e..52ff355fa0a 100644
--- a/addons/web_mobile/static/src/js/chrome_mobile.js
+++ b/addons/web_mobile/static/src/js/chrome_mobile.js
@@ -116,8 +116,8 @@ openerp.web_mobile.Header =  openerp.web.Widget.extend({
         self.$element.find("a").click(this.on_clicked);
     },
     on_clicked: function(ev) {
-        $opt = $(ev.currentTarget);
-        current_id = $opt.attr('id');
+        var $opt = $(ev.currentTarget);
+        var current_id = $opt.attr('id');
         if (current_id == 'home') {
             this.homepage = new openerp.web_mobile.HomePage(this, "oe_app");
             this.homepage.start();
@@ -137,9 +137,9 @@ openerp.web_mobile.Shortcuts =  openerp.web.Widget.extend({
         })
     },
     on_clicked: function(ev) {
-        $shortcut = $(ev.currentTarget);
-        id = $shortcut.data('menu');
-        res_id = $shortcut.data('res');
+        var $shortcut = $(ev.currentTarget);
+        var id = $shortcut.data('menu');
+        var res_id = $shortcut.data('res');
         jQuery("#oe_header").find("h1").html($shortcut.data('name'));
         this.listview = new openerp.web_mobile.ListView(this, "oe_app", res_id);
         this.listview.start();
@@ -162,7 +162,7 @@ openerp.web_mobile.Menu =  openerp.web.Widget.extend({
         this.$element.add(this.$secondary_menu).find("a").click(this.on_menu_click);
     },
     on_menu_click: function(ev, id) {
-        $menu = $(ev.currentTarget);
+        var $menu = $(ev.currentTarget);
         id = $menu.data('menu');
         for (var i = 0; i < this.data.data.children.length; i++) {
             if (this.data.data.children[i].id == id) {
@@ -190,7 +190,7 @@ openerp.web_mobile.Secondary =  openerp.web.Widget.extend({
         this.$element.add(this.$secondary_menu).find("a").click(this.on_menu_click);
     },
     on_menu_click: function(ev, id) {
-        $menu = $(ev.currentTarget);
+        var $menu = $(ev.currentTarget);
         id = $menu.data('menu');
         for (var i = 0; i < this.data.children.length; i++) {
             if (this.data.children[i].id == id) {
diff --git a/addons/web_mobile/static/src/js/form_mobile.js b/addons/web_mobile/static/src/js/form_mobile.js
index 75dc71fad71..03291a70bfa 100644
--- a/addons/web_mobile/static/src/js/form_mobile.js
+++ b/addons/web_mobile/static/src/js/form_mobile.js
@@ -18,9 +18,9 @@ openerp.web_mobile.FormView = openerp.web.Widget.extend({
     },
     start: function() {
         var self = this;
-        id = this.list_id;
-        model = this.action.res_model;
-        view_id = this.action.views[1][0];
+        var id = this.list_id;
+        var model = this.action.res_model;
+        var view_id = this.action.views[1][0];
         this.dataset = new openerp.web.DataSetSearch(this, this.action.res_model, null, null);
         this.dataset.read_slice([],{}, function (result) {
             for (var i = 0; i < result.length; i++) {
diff --git a/addons/web_mobile/static/src/js/list_mobile.js b/addons/web_mobile/static/src/js/list_mobile.js
index 71ce8b38a0c..9bcdc0a72ce 100644
--- a/addons/web_mobile/static/src/js/list_mobile.js
+++ b/addons/web_mobile/static/src/js/list_mobile.js
@@ -63,9 +63,9 @@ openerp.web_mobile.ListView = openerp.web.Widget.extend({
         });
     },
     on_list_click: function(ev) {
-        $record = $(ev.currentTarget);
+        var $record = $(ev.currentTarget);
         var self = this;
-        id = $record.data('id');
+        var id = $record.data('id');
         this.formview = new openerp.web_mobile.FormView(this, "oe_app", id, this.action);
         this.formview.start();
     }
diff --git a/addons/web_mobile/static/src/web_mobile.html b/addons/web_mobile/static/src/web_mobile.html
index 6efc28b6532..254c4a6ea36 100755
--- a/addons/web_mobile/static/src/web_mobile.html
+++ b/addons/web_mobile/static/src/web_mobile.html
@@ -15,7 +15,7 @@
     <script type="text/javascript" src="/web_mobile/static/lib/jquery_mobile/js/jquery.mobile-1.0a4.1.js"></script>
 
     <script type="text/javascript" src="/base/static/lib/qweb/qweb2.js"></script>
-    <script type="text/javascript" src="/base/static/src/js/boot.js"></script>
+    <script type="text/javascript" src="/base/static/src/js/boot.js"></script>
     <script type="text/javascript" src="/base/static/src/js/core.js"></script>
     <script type="text/javascript" src="/base/static/src/js/chrome.js"></script>
     <script type="text/javascript" src="/base/static/src/js/data.js"></script>
@@ -27,6 +27,7 @@
     <script type="text/javascript" src="/web_mobile/static/src/js/form_mobile.js"></script>
 
     <script type="text/javascript">
+        var QWeb;
         $(function() {
             QWeb = window.QWeb || new QWeb2.Engine();
             var oe = openerp.init();
@@ -38,4 +39,4 @@
 <body>
     <div id="moe" class="openerp"></div>
 </body>
-</html>
\ No newline at end of file
+</html>