From 0bbd8351f1126f2d9141200ce1519c99746a065c Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Mon, 23 Feb 2015 11:41:32 +0100 Subject: [PATCH] [FIX] web: on_item_action_clicked, self.dataset is not always defined. 27a48f8026f824f62955d5bf2a83b2799ad98db1 introduced the use of self.dataset It appears it is not always defined. Few lines above, self.getParent().dataset is used, and looks to be always defined. We therefore now use this dataset in order to get the context, to correctly pass the current session language. Closes #5416 --- addons/web/static/src/js/views.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/addons/web/static/src/js/views.js b/addons/web/static/src/js/views.js index 5ae8bfc79fc..009621cd27a 100644 --- a/addons/web/static/src/js/views.js +++ b/addons/web/static/src/js/views.js @@ -1210,10 +1210,11 @@ instance.web.Sidebar = instance.web.Widget.extend({ instance.web.dialog($("
").text(_t("You must choose at least one record.")), { title: _t("Warning"), modal: true }); return false; } + var dataset = self.getParent().dataset; var active_ids_context = { active_id: ids[0], active_ids: ids, - active_model: self.getParent().dataset.model + active_model: dataset.model }; var c = instance.web.pyeval.eval('context', new instance.web.CompoundContext( @@ -1221,7 +1222,7 @@ instance.web.Sidebar = instance.web.Widget.extend({ self.rpc("/web/action/load", { action_id: item.action.id, context: new instance.web.CompoundContext( - self.dataset.get_context(), active_ids_context).eval() + dataset.get_context(), active_ids_context).eval() }).done(function(result) { result.context = new instance.web.CompoundContext( result.context || {}, active_ids_context)