From 34be74d3df001fb35d77c78f6bd7da9a937b1d50 Mon Sep 17 00:00:00 2001
From: "olt@tinyerp.com" <>
Date: Thu, 23 Sep 2010 09:52:53 +0200
Subject: [PATCH 01/13] [IMP] hr: performance improvement: removed 2 not used
 fields (parent_id, child_ids)

bzr revid: olt@tinyerp.com-20100923075253-kolxfmlzlo2kj51p
---
 addons/hr/hr_department.py       | 79 +-------------------------------
 addons/hr/hr_department_view.xml |  4 --
 2 files changed, 1 insertion(+), 82 deletions(-)

diff --git a/addons/hr/hr_department.py b/addons/hr/hr_department.py
index 21946469ce4..ec6f276e670 100644
--- a/addons/hr/hr_department.py
+++ b/addons/hr/hr_department.py
@@ -113,87 +113,10 @@ class res_users(osv.osv):
     _inherit = 'res.users'
     _description = 'User'
 
-    def _parent_compute(self, cr, uid, ids, name, args, context=None):
-        if context is None:
-            context = {}
-        result = {}
-        obj_dept = self.pool.get('hr.department')
-        for user_id in ids:
-            emp_ids = self.pool.get('hr.employee').search(cr, uid, [('user_id', '=', user_id)], context=context)
-            cr.execute('SELECT emp.department_id FROM hr_employee AS emp \
-                        JOIN resource_resource AS res ON res.id = emp.resource_id \
-                        JOIN hr_department as dept ON dept.id = emp.department_id \
-                        WHERE res.user_id = %s AND emp.department_id IS NOT NULL AND dept.manager_id IS NOT NULL', (user_id,))
-            ids_dept = [x[0] for x in cr.fetchall()]
-            parent_ids = []
-            if ids_dept:
-                data_dept = obj_dept.read(cr, uid, ids_dept, ['manager_id'], context=context)
-                parent_ids = map(lambda x: x['manager_id'][0], data_dept)
-                cr.execute('SELECT res.user_id FROM hr_employee AS emp JOIN resource_resource AS res ON res.id=emp.resource_id \
-                        WHERE emp.id IN %s AND res.user_id IS NOT NULL', (tuple(parent_ids),))
-                parent_ids = [x[0] for x in cr.fetchall()]
-            result[user_id] = parent_ids
-        return result
-
-    def _parent_search(self, cr, uid, obj, name, args, context=None):
-        if context is None:
-            context = {}
-        parent = []
-        for arg in args:
-            if arg[0] == 'parent_id':
-                parent = arg[2]
-        child_ids = self._child_compute(cr, uid, parent, name, args, context=context)
-        if not child_ids:
-            return [('id', 'in', [0])]
-        return [('id', 'in', child_ids.get(uid, []))]
-
-    def _child_compute(self, cr, uid, ids, name, args, context=None):
-        if context is None:
-            context = {}
-        obj_dept = self.pool.get('hr.department')
-        obj_user = self.pool.get('res.users')
-        result = {}
-        for user_id in ids:
-            child_ids = []
-            cr.execute('SELECT dept.id FROM hr_department AS dept \
-                        LEFT JOIN hr_employee AS emp ON dept.manager_id = emp.id \
-                        WHERE emp.id IN \
-                            (SELECT emp.id FROM hr_employee \
-                                JOIN resource_resource r ON r.id = emp.resource_id WHERE r.user_id=' + str(user_id) + ') ')
-            mgnt_dept_ids = [x[0] for x in cr.fetchall()]
-            ids_dept = obj_dept.search(cr, uid, [('id', 'child_of', mgnt_dept_ids)], context=context)
-            if ids_dept:
-                data_dept = obj_dept.read(cr, uid, ids_dept, ['member_ids'], context=context)
-                childs = map(lambda x: x['member_ids'], data_dept)
-                childs = tools.flatten(childs)
-                childs = obj_user.search(cr, uid, [('id', 'in', childs),('active', '=', True)], context=context)
-                if user_id in childs:
-                    childs.remove(user_id)
-                child_ids.extend(tools.flatten(childs))
-                set = {}
-                map(set.__setitem__, child_ids, [])
-                child_ids = set.keys()
-            result[user_id] = child_ids
-        return result
-
-    def _child_search(self, cr, uid, obj, name, args, context=None):
-        if context is None:
-            context = {}
-        parent = []
-        for arg in args:
-            if arg[0] == 'child_ids':
-                parent = arg[2]
-        child_ids = self._child_compute(cr, uid, parent, name, args, context=context)
-        if not child_ids:
-            return [('id', 'in', [0])]
-        return [('id', 'in', child_ids.get(uid, []))]
-
     _columns = {
-        'parent_id': fields.function(_parent_compute, relation='res.users', fnct_search=_parent_search, method=True, string="Managers", type='many2many'),
-        'child_ids': fields.function(_child_compute, relation='res.users', fnct_search=_child_search, method=True, string="Subordinates", type='many2many'),
         'context_department_id': fields.many2one('hr.department', 'Departments'),
     }
 
 res_users()
 
-# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
\ No newline at end of file
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
diff --git a/addons/hr/hr_department_view.xml b/addons/hr/hr_department_view.xml
index c2bb6ac7390..7626c501167 100644
--- a/addons/hr/hr_department_view.xml
+++ b/addons/hr/hr_department_view.xml
@@ -87,10 +87,6 @@
                 <notebook position="inside">
                     <page string="Departments" groups="base.group_extended">
                         <field name="context_department_id" completion="1" widget="selection" string="Department"/>
-                        <separator string="Managers" colspan="4"/>
-                        <field name="parent_id" nolabel="1" colspan="4"/>
-                        <separator string="Subordinates" colspan="4"/>
-                        <field name="child_ids" nolabel="1" colspan="4"/>
                     </page>
                 </notebook>
             </field>

From c1dcd713577406b48a6095e121dd7374edfc5290 Mon Sep 17 00:00:00 2001
From: "olt@tinyerp.com" <>
Date: Thu, 23 Sep 2010 09:53:54 +0200
Subject: [PATCH 02/13] [IMP] analytic: performance improvement: using browse
 instead of search for children computation

bzr revid: olt@tinyerp.com-20100923075354-jispscmrhfhhwmy4
---
 addons/analytic/analytic.py | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/addons/analytic/analytic.py b/addons/analytic/analytic.py
index eef25f665d8..b97edb9a546 100644
--- a/addons/analytic/analytic.py
+++ b/addons/analytic/analytic.py
@@ -35,16 +35,16 @@ class account_analytic_account(osv.osv):
         cr.execute("SELECT a.id, r.currency_id FROM account_analytic_account a INNER JOIN res_company r ON (a.company_id = r.id) where a.id IN %s" , (tuple(ids2),))
         currency = dict(cr.fetchall())
         res_currency= self.pool.get('res.currency')
-        for id in ids:
-            if id not in ids2:
+        for account in self.browse(cr, uid, ids, context=context):
+            if account.id not in ids2:
                 continue
-            for child in self.search(cr, uid, [('parent_id', 'child_of', [id])]):
-                if child != id:
-                    res.setdefault(id, 0.0)
-                    if  currency[child]!=currency[id]:
-                        res[id] += res_currency.compute(cr, uid, currency[child], currency[id], res.get(child, 0.0), context=context)
+            for child in account.child_ids:
+                if child.id != account.id:
+                    res.setdefault(account.id, 0.0)
+                    if  currency[child.id] != currency[account.id]:
+                        res[account.id] += res_currency.compute(cr, uid, currency[child.id], currency[account.id], res.get(child.id, 0.0), context=context)
                     else:
-                        res[id] += res.get(child, 0.0)
+                        res[account.id] += res.get(child.id, 0.0)
 
         cur_obj = res_currency.browse(cr, uid, currency.values(), context=context)
         cur_obj = dict([(o.id, o) for o in cur_obj])
@@ -145,13 +145,13 @@ class account_analytic_account(osv.osv):
         for account_id, sum in cr.fetchall():
             res[account_id] = sum
 
-        for id in ids:
-            if id not in parent_ids:
+        for account in self.browse(cr, uid, ids, context=context):
+            if account.id not in parent_ids:
                 continue
-            for child in self.search(cr, uid, [('parent_id', 'child_of', [id])]):
-                if child != id:
-                    res.setdefault(id, 0.0)
-                    res[id] += res.get(child, 0.0)
+            for child in account.child_ids:
+                if child.id != account.id:
+                    res.setdefault(account.id, 0.0)
+                    res[account.id] += res.get(child.id, 0.0)
         return dict([(i, res[i]) for i in ids])
 
     def name_get(self, cr, uid, ids, context=None):

From 07b88cb8da2d6e3d9a13fc5afff69c1b95c14a0a Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Thu, 23 Sep 2010 14:47:34 +0530
Subject: [PATCH 03/13] [FIX]: add the missing field to the payslip model

bzr revid: mga@tinyerp.com-20100923091734-7niyoorw5hmryo58
---
 addons/hr_payroll/hr_payroll.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/addons/hr_payroll/hr_payroll.py b/addons/hr_payroll/hr_payroll.py
index 7a6eaf14b58..48ffc1f6b20 100644
--- a/addons/hr_payroll/hr_payroll.py
+++ b/addons/hr_payroll/hr_payroll.py
@@ -784,6 +784,7 @@ class hr_payslip(osv.osv):
         'contract_id':fields.many2one('hr.contract', 'Contract', required=False),
         'igross': fields.float('Calculaton Field', readonly=True,  digits=(16, 2), help="Calculation field used for internal calculation, do not place this on form"),
         'inet': fields.float('Calculaton Field', readonly=True,  digits=(16, 2), help="Calculation field used for internal calculation, do not place this on form"),
+        'period_id': fields.many2one('account.period', 'Force Period', domain=[('state','<>','done')], help="Keep empty to use the period of the validation(Payslip) date."),
     }
     _defaults = {
         'date': lambda *a: time.strftime('%Y-%m-%d'),

From cc4ee88766573321b927c3cbf061d303856240ce Mon Sep 17 00:00:00 2001
From: Mantavya Gajjar <mga@tinyerp.com>
Date: Thu, 23 Sep 2010 15:30:36 +0530
Subject: [PATCH 04/13] [FIX]: solve the usability issue in psyslip view

bzr revid: mga@tinyerp.com-20100923100036-mtbc9m87t39fpya9
---
 addons/hr_payroll/hr_payroll_view.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/hr_payroll/hr_payroll_view.xml b/addons/hr_payroll/hr_payroll_view.xml
index fbfa2d1aad5..d833612e383 100644
--- a/addons/hr_payroll/hr_payroll_view.xml
+++ b/addons/hr_payroll/hr_payroll_view.xml
@@ -500,12 +500,12 @@
                     </notebook>
                     <group col="10" colspan="4">
                         <field name="state"/>
+                        <button string="Cancel" icon="terp-dialog-close" name="cancel_sheet" states="draft,hr_check,confirm"/>
                         <button string="Compute Sheet" icon="terp-stock_format-scientific" name="compute_sheet" states="new"/>
                         <button string="Recompute Sheet" icon="terp-stock_format-scientific" name="compute_sheet" type="object" states="draft"/>
                         <button string="Verify Sheet" icon="terp-camera_test" name="verify_sheet" states="draft"/>
                         <button string="Approve Sheet" icon="terp-camera_test" name="final_verify_sheet" states="hr_check"/>
                         <button string="Pay Salary" icon="terp-dolar_ok!" name="process_sheet" states="confirm"/>
-                        <button string="Cancel" icon="terp-dialog-close" name="cancel_sheet" states="draft,hr_check,confirm"/>
                         <button string="Set to Draft" icon="terp-stock_effects-object-colorize" name="set_to_draft" states="cancel"/>
                     </group>
                 </form>

From f8e9c6750a25dbb7876450cb8b1f4a907649064c Mon Sep 17 00:00:00 2001
From: "DHS(OpenERP)" <>
Date: Thu, 23 Sep 2010 15:43:51 +0530
Subject: [PATCH 05/13] [FIX] hr_expense : Expense Report Corrected

bzr revid: ach@tinyerp.com-20100923101351-h8dtdz2osd0a0kic
---
 addons/hr_expense/report/expense.rml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/hr_expense/report/expense.rml b/addons/hr_expense/report/expense.rml
index bb9a1ba0b1c..4ae45ad0aa2 100644
--- a/addons/hr_expense/report/expense.rml
+++ b/addons/hr_expense/report/expense.rml
@@ -259,7 +259,7 @@
     <para style="terp_default_9">
       <font color="white"> </font>
     </para>
-    <para style="terp_default_9">[[ o.note or '' ]] [[ setTag('para','xpre') ]]</para>
+    <para style="terp_default_9">[[ setTag('para','xpre') ]] [[ o.note or '' ]] </para>
     <para style="terp_default_9">
       <font color="white"> </font>
     </para>

From 63682313aada690cc9a9f5f494b1f48675068cd5 Mon Sep 17 00:00:00 2001
From: "PAP(OpenERP)" <>
Date: Thu, 23 Sep 2010 16:56:00 +0530
Subject: [PATCH 06/13] [FIX] Account: yaml

bzr revid: mra@mra-laptop-20100923112600-ndyhrfcjglc79m6e
---
 .../account/test/account_change_currency.yml  | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/addons/account/test/account_change_currency.yml b/addons/account/test/account_change_currency.yml
index 71a4ff6e301..d68b5fb90b5 100644
--- a/addons/account/test/account_change_currency.yml
+++ b/addons/account/test/account_change_currency.yml
@@ -41,14 +41,17 @@
   I clicked on Change Currency button to change the currency
 -
   !python {model: account.change.currency}: |
-    self.view_init(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
-      "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
-      [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
-    })
-    self.change_currency(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
-      "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
-      [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
-    })
+    try:
+      self.view_init(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
+        "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
+        [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
+      })
+      self.change_currency(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
+        "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
+        [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
+      })
+    except:
+      print "Error: You can change currency only for Draft Invoice !"
 -
   I can't change the currency of invoice when it is not in draft state so i change the state to cancel
 -

From 1a04f8f0d4c6e9b56e0721214a1d991c49da6e3d Mon Sep 17 00:00:00 2001
From: "Anup (OpenERP)" <ach@tinyerp.com>
Date: Thu, 23 Sep 2010 17:07:39 +0530
Subject: [PATCH 07/13] [FIX] stock,mrp : Demo data corrected

bzr revid: ach@tinyerp.com-20100923113739-uzo38vqvv8dbl8g8
---
 addons/mrp/mrp_demo.xml     | 7 ++++++-
 addons/stock/stock_demo.xml | 1 -
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/addons/mrp/mrp_demo.xml b/addons/mrp/mrp_demo.xml
index f454a8d14a8..e303ceb3378 100644
--- a/addons/mrp/mrp_demo.xml
+++ b/addons/mrp/mrp_demo.xml
@@ -14,7 +14,12 @@
             <field name="name">Repairs workshop</field>
             <field name="calendar_id" ref="resource.timesheet_group1"/>
         </record>
-
+      <!--
+    Resource: res.company
+    -->
+		<record id="stock.res_company_tinyshop0" model="res.company">
+			<field eval="1.0" name="manufacturing_lead"/>
+		</record>
         <!--
     Resource: mrp.property.group
     -->
diff --git a/addons/stock/stock_demo.xml b/addons/stock/stock_demo.xml
index 03a29838981..91acb5c6406 100644
--- a/addons/stock/stock_demo.xml
+++ b/addons/stock/stock_demo.xml
@@ -217,7 +217,6 @@
             <field name="currency_id" ref="base.EUR"/>
             <field eval="1.0" name="po_lead"/>
             <field name="partner_id" ref="res_partner_tinyshop1"/>
-            <field eval="1.0" name="manufacturing_lead"/>
             <field name="parent_id" ref="base.main_company"/>
             <field eval="80.0" name="schedule_range"/>
             <field eval="&quot;&quot;&quot;Shop 2&quot;&quot;&quot;" name="name"/>

From d942be95d4c66714e4a26ac965c4e95257f74865 Mon Sep 17 00:00:00 2001
From: "Anup (OpenERP)" <ach@tinyerp.com>
Date: Thu, 23 Sep 2010 17:59:34 +0530
Subject: [PATCH 08/13] [FIx] purchase : Demo data Corrected

bzr revid: ach@tinyerp.com-20100923122934-h9gzm5p2zk64lu62
---
 addons/purchase/purchase_demo.xml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/addons/purchase/purchase_demo.xml b/addons/purchase/purchase_demo.xml
index f6c2931a626..ebd0b0becaf 100644
--- a/addons/purchase/purchase_demo.xml
+++ b/addons/purchase/purchase_demo.xml
@@ -41,9 +41,6 @@
             <field name="product_uom" ref="product.product_uom_unit"/>
             <field name="price_unit">450</field>
             <field name="product_qty">2</field>
-            <field name="product_uom_qty">3</field>
-            <field name="product_uos_qty">3</field>
-            <field name="type">make_to_stock</field>
         </record>
         
         <record id="line3_purchase" model="purchase.order.line">
@@ -54,7 +51,6 @@
             <field name="product_uom" ref="product.product_uom_unit"/>
             <field name="price_unit">900</field>
             <field name="product_qty">1</field>
-            <field name="type">make_to_stock</field>
         </record>
         
         <workflow action="purchase_confirm" model="purchase.order" ref="order_purchase2"/>

From cc84c31d1bedf3b4a18827fd4b3f2fd0799b86a3 Mon Sep 17 00:00:00 2001
From: "Anup (OpenERP)" <ach@tinyerp.com>
Date: Thu, 23 Sep 2010 18:01:07 +0530
Subject: [PATCH 09/13] [FIX] account : YML test of currency Corrected

bzr revid: ach@tinyerp.com-20100923123107-cln1mtwionpkj56j
---
 .../account/test/account_change_currency.yml  | 37 +++++++++----------
 1 file changed, 17 insertions(+), 20 deletions(-)

diff --git a/addons/account/test/account_change_currency.yml b/addons/account/test/account_change_currency.yml
index d68b5fb90b5..4fe89534ce5 100644
--- a/addons/account/test/account_change_currency.yml
+++ b/addons/account/test/account_change_currency.yml
@@ -23,15 +23,6 @@
 -
   !assert {model: account.invoice, id: account_invoice_currency, string: Customer Invoice is in Draft state}:
     - state == 'draft'
--
-  I change the state of invoice to proforma2 by clicking PRO-FORMA button
--
-  !workflow {model: account.invoice, action: invoice_proforma2, ref: account_invoice_currency}
--
-  I check that now customer invoice is in the "proforma2" state
--
-  !assert {model: account.invoice, id: account_invoice_currency}:
-    - state == 'proforma2'
 -
   Now I select USD as new currency
 -
@@ -41,17 +32,23 @@
   I clicked on Change Currency button to change the currency
 -
   !python {model: account.change.currency}: |
-    try:
-      self.view_init(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
-        "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
-        [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
-      })
-      self.change_currency(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
-        "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
-        [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
-      })
-    except:
-      print "Error: You can change currency only for Draft Invoice !"
+    self.view_init(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
+      "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
+      [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
+    })
+    self.change_currency(cr, uid, [ref("account_change_currency_0")], {"lang": 'en_US',
+      "active_model": "account.invoice", "tz": False, "record_id": 4, "active_ids":
+      [ref("account_invoice_currency")], "type": "out_invoice", "active_id": ref("account_invoice_currency"),
+    })
+-
+  I change the state of invoice to proforma2 by clicking PRO-FORMA button
+-
+  !workflow {model: account.invoice, action: invoice_proforma2, ref: account_invoice_currency}
+-
+  I check that now customer invoice is in the "proforma2" state
+-
+  !assert {model: account.invoice, id: account_invoice_currency}:
+    - state == 'proforma2'
 -
   I can't change the currency of invoice when it is not in draft state so i change the state to cancel
 -

From c3de35eb8d35cc681fb83c55bec73cb4012c17e7 Mon Sep 17 00:00:00 2001
From: "Anup (OpenERP)" <ach@tinyerp.com>
Date: Thu, 23 Sep 2010 18:42:04 +0530
Subject: [PATCH 10/13] [FIX] account_reporting : Balance Sheet Report RML
 Corrected

bzr revid: ach@tinyerp.com-20100923131204-qjijtuuotbpb4f3j
---
 addons/account_reporting/report/account_report_bs.rml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/account_reporting/report/account_report_bs.rml b/addons/account_reporting/report/account_report_bs.rml
index b33ebb4bcc8..c0fa4f1e2d2 100644
--- a/addons/account_reporting/report/account_report_bs.rml
+++ b/addons/account_reporting/report/account_report_bs.rml
@@ -155,7 +155,7 @@
           <para style="terp_default_Centre_8">[[ company.currency_id.name ]]</para>
         </td>
         <td>
-          <para style="terp_default_Centre_8"><font>[[ setTag('font','font',{'face':o.font_style,'color':o.color_font.name,'backColor':o.color_back.name}) ]] [[o.name]]</font></para>
+          <para style="terp_default_Centre_8"><font>[[ setTag('font','font',{'face':o.font_style or "Helvetica",'color':o.color_font.name or "black",'backColor':o.color_back.name or "white"}) ]] [[o.name]]</font></para>
         </td>
       </tr>
     </blockTable>

From debb9fac866bfa609f007d1991d3f5a42b6c1a51 Mon Sep 17 00:00:00 2001
From: "DHS(OpenERP)" <>
Date: Thu, 23 Sep 2010 18:54:54 +0530
Subject: [PATCH 11/13] [FIX] hr_timesheet : Reports Corrected

bzr revid: ach@tinyerp.com-20100923132454-ms7s6fnonf1hw590
---
 addons/hr_timesheet/report/user_timesheet.py  | 2 +-
 addons/hr_timesheet/report/users_timesheet.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/addons/hr_timesheet/report/user_timesheet.py b/addons/hr_timesheet/report/user_timesheet.py
index 8cf255c9b7f..dc048748f46 100644
--- a/addons/hr_timesheet/report/user_timesheet.py
+++ b/addons/hr_timesheet/report/user_timesheet.py
@@ -77,7 +77,7 @@ class report_custom(report_rml):
             <amount>%.2f</amount>
         </time-element>
         '''
-        rpt_obj = pooler.get_pool(cr.dbname).get('hr.holidays')
+        rpt_obj = pooler.get_pool(cr.dbname).get('hr.employee')
         rml_obj=report_sxw.rml_parse(cr, uid, rpt_obj._name,context)
         header_xml = '''
         <header>
diff --git a/addons/hr_timesheet/report/users_timesheet.py b/addons/hr_timesheet/report/users_timesheet.py
index 0198994728c..35c86fd08b9 100644
--- a/addons/hr_timesheet/report/users_timesheet.py
+++ b/addons/hr_timesheet/report/users_timesheet.py
@@ -97,7 +97,7 @@ class report_custom(report_rml):
         # Computing the xml
         #Without this, report don't show non-ascii characters (TO CHECK)
         date_xml = '\n'.join(date_xml)
-        rpt_obj = pooler.get_pool(cr.dbname).get('hr.holidays')
+        rpt_obj = pooler.get_pool(cr.dbname).get('hr.employee')
         rml_obj=report_sxw.rml_parse(cr, uid, rpt_obj._name,context)
         header_xml = '''
         <header>

From b1e8536b113b85ca3598ddef952c82aa6b47ac2c Mon Sep 17 00:00:00 2001
From: "olt@tinyerp.com" <>
Date: Thu, 23 Sep 2010 16:14:55 +0200
Subject: [PATCH 12/13] [IMP] account_analytic_analysis: performance
 improvement: reduced the number of call to sql queries

bzr revid: olt@tinyerp.com-20100923141455-mpa2kjzsrxk4ni1k
---
 .../account_analytic_analysis.py              | 454 ++++++++----------
 1 file changed, 213 insertions(+), 241 deletions(-)

diff --git a/addons/account_analytic_analysis/account_analytic_analysis.py b/addons/account_analytic_analysis/account_analytic_analysis.py
index bf577ebeaf6..6bd2f2138ec 100644
--- a/addons/account_analytic_analysis/account_analytic_analysis.py
+++ b/addons/account_analytic_analysis/account_analytic_analysis.py
@@ -28,6 +28,210 @@ class account_analytic_account(osv.osv):
     _name = "account.analytic.account"
     _inherit = "account.analytic.account"
 
+    def _analysis_all(self, cr, uid, ids, fields, arg, context=None):
+        dp = 2
+        res = dict([(i, {}) for i in ids])
+
+        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
+        accounts = self.browse(cr, uid, ids, context=context)
+
+        for f in fields:
+            if f == 'user_ids':
+                cr.execute('SELECT MAX(id) FROM res_users')
+                max_user = cr.fetchone()[0]
+                if parent_ids:
+                    cr.execute('SELECT DISTINCT("user") FROM account_analytic_analysis_summary_user ' \
+                               'WHERE account_id IN %s AND unit_amount <> 0.0', (parent_ids,))
+                    result = cr.fetchall()
+                else:
+                    result = []
+                for id in ids:
+                    res[id][f] = [int((id * max_user) + x[0]) for x in result]
+            elif f == 'month_ids':
+                if parent_ids:
+                    cr.execute('SELECT DISTINCT(month_id) FROM account_analytic_analysis_summary_month ' \
+                               'WHERE account_id IN %s AND unit_amount <> 0.0', (parent_ids,))
+                    result = cr.fetchall()
+                else:
+                    result = []
+                for id in ids:
+                    res[id][f] = [int(id * 1000000 + int(x[0])) for x in result]
+            elif f == 'last_worked_invoiced_date':
+                for id in ids:
+                    res[id][f] = 0.0
+                if parent_ids:
+                    cr.execute("select account_analytic_line.account_id, max(date) \
+                            from account_analytic_line \
+                            where account_id IN %s \
+                                and invoice_id is not null \
+                            GROUP BY account_analytic_line.account_id;", (parent_ids,))
+                    for account_id, sum in cr.fetchall():
+                        res[account_id][f] = sum
+                for account in accounts:
+                    for child in account.child_ids:
+                        if res[account.id].get(f, '') < res.get(child.id, {}).get(f, ''):
+                            res[account.id][f] = res.get(child.id, {}).get(f, '')
+            elif f == 'ca_to_invoice':
+                for id in ids:
+                    res[id][f] = 0.0
+                res2 = {}
+                if parent_ids:
+                    # Amount uninvoiced hours to invoice at sale price
+                    # Warning
+                    # This computation doesn't take care of pricelist !
+                    # Just consider list_price
+                    cr.execute("""SELECT account_analytic_account.id, \
+                                COALESCE(sum (product_template.list_price * \
+                                    account_analytic_line.unit_amount * \
+                                    ((100-hr_timesheet_invoice_factor.factor)/100)),0.0) \
+                                    AS ca_to_invoice \
+                            FROM product_template \
+                            join product_product \
+                                on product_template.id = product_product.product_tmpl_id \
+                            JOIN account_analytic_line \
+                                on account_analytic_line.product_id = product_product.id \
+                            JOIN account_analytic_journal \
+                                on account_analytic_line.journal_id = account_analytic_journal.id \
+                            JOIN account_analytic_account \
+                                on account_analytic_account.id = account_analytic_line.account_id \
+                            JOIN hr_timesheet_invoice_factor \
+                                on hr_timesheet_invoice_factor.id = account_analytic_account.to_invoice \
+                            WHERE account_analytic_account.id IN %s \
+                                AND account_analytic_line.invoice_id is null \
+                                AND account_analytic_line.to_invoice IS NOT NULL \
+                                and account_analytic_journal.type in ('purchase','general') \
+                            GROUP BY account_analytic_account.id;""", (parent_ids,))
+                    for account_id, sum in cr.fetchall():
+                        res[account_id][f] = round(sum, dp)
+
+                for account in accounts:
+                    #res.setdefault(account.id, 0.0)
+                    res2.setdefault(account.id, 0.0)
+                    for child in account.child_ids:
+                        if child.id != account.id:
+                            res[account.id][f] += res.get(child.id, {}).get(f, 0.0)
+                            res2[account.id] += res2.get(child.id, 0.0)
+                # sum both result on account_id
+                for id in ids:
+                    res[id][f] = round(res.get(id, {}).get(f, 0.0), dp) + round(res2.get(id, 0.0), 2)
+            elif f == 'last_invoice_date':
+                for id in ids:
+                    res[id][f] = ''
+                if parent_ids:
+                    cr.execute ("select account_analytic_line.account_id, \
+                                date(max(account_invoice.date_invoice)) \
+                            from account_analytic_line \
+                            join account_invoice \
+                                on account_analytic_line.invoice_id = account_invoice.id \
+                            where account_analytic_line.account_id IN %s \
+                                and account_analytic_line.invoice_id is not null \
+                            GROUP BY account_analytic_line.account_id",(parent_ids,))
+                    for account_id, sum in cr.fetchall():
+                        res[account_id] = sum
+                for account in accounts:
+                    for child in account.child_ids:
+                        if res[account.id][f] < res.get(child.id, {}).get(f, ''):
+                            res[account.id][f] = res.get(child.id, {}).get(f, '')
+            elif f == 'last_worked_date':
+                for id in ids:
+                    res[id][f] = ''
+                if parent_ids:
+                    cr.execute("select account_analytic_line.account_id, max(date) \
+                            from account_analytic_line \
+                            where account_id IN %s \
+                                and invoice_id is null \
+                            GROUP BY account_analytic_line.account_id" ,(parent_ids,))
+                    for account_id, sum in cr.fetchall():
+                        res[account_id][f] = sum
+                for account in accounts:
+                    for child in account.child_ids:
+                        if res[account.id][f] < res.get(child.id, {}).get(f, ''):
+                            res[account.id][f] = res.get(child.id, {}).get(f, '')
+            elif f == 'hours_qtt_non_invoiced':
+                for id in ids:
+                    res[id][f] = 0.0
+                if parent_ids:
+                    cr.execute("select account_analytic_line.account_id, COALESCE(sum(unit_amount),0.0) \
+                            from account_analytic_line \
+                            join account_analytic_journal \
+                                on account_analytic_line.journal_id = account_analytic_journal.id \
+                            where account_analytic_line.account_id IN %s \
+                                and account_analytic_journal.type='general' \
+                                and invoice_id is null \
+                                AND to_invoice IS NOT NULL \
+                            GROUP BY account_analytic_line.account_id;",(parent_ids,))
+                    for account_id, sum in cr.fetchall():
+                        res[account_id][f] = round(sum, dp)
+                for account in accounts:
+                    for child in account.child_ids:
+                        if account.id != child.id:
+                            res[account.id][f] += res.get(child.id, {}).get(f, 0.0)
+                for id in ids:
+                    res[id][f] = round(res[id][f], dp)
+            elif f == 'hours_quantity':
+                for id in ids:
+                    res[id][f] = 0.0
+                if parent_ids:
+                    cr.execute("select account_analytic_line.account_id,COALESCE(SUM(unit_amount),0.0) \
+                            from account_analytic_line \
+                            join account_analytic_journal \
+                                on account_analytic_line.journal_id = account_analytic_journal.id \
+                            where account_analytic_line.account_id IN %s \
+                                and account_analytic_journal.type='general' \
+                            GROUP BY account_analytic_line.account_id",(parent_ids,))
+                    ff =  cr.fetchall()
+                    for account_id, sum in ff:
+                        res[account_id][f] = round(sum, dp)
+                for account in accounts:
+                    for child in account.child_ids:
+                        if account.id != child.id:
+                            res[account.id][f] += res.get(child.id, {}).get(f, 0.0)
+                for id in ids:
+                    res[id][f] = round(res[id][f], dp)
+            elif f == 'ca_theorical':
+                # TODO Take care of pricelist and purchase !
+                for id in ids:
+                    res[id][f] = 0.0
+                res2 = {}
+                # Warning
+                # This computation doesn't take care of pricelist !
+                # Just consider list_price
+                if parent_ids:
+                    cr.execute("""select account_analytic_line.account_id as account_id, \
+                                COALESCE(sum((account_analytic_line.unit_amount * pt.list_price) \
+                                    - (account_analytic_line.unit_amount * pt.list_price \
+                                        * hr.factor)),0.0) as somme
+                            from account_analytic_line \
+                            left join account_analytic_journal \
+                                on (account_analytic_line.journal_id = account_analytic_journal.id) \
+                            join product_product pp \
+                                on (account_analytic_line.product_id = pp.id) \
+                            join product_template pt \
+                                on (pp.product_tmpl_id = pt.id) \
+                            join account_analytic_account a \
+                                on (a.id=account_analytic_line.account_id) \
+                            join hr_timesheet_invoice_factor hr \
+                                on (hr.id=a.to_invoice) \
+                        where account_analytic_line.account_id IN %s \
+                            and a.to_invoice IS NOT NULL \
+                            and account_analytic_journal.type IN ('purchase','general')
+                        GROUP BY account_analytic_line.account_id""",(parent_ids,))
+                    for account_id, sum in cr.fetchall():
+                        res2[account_id] = round(sum, dp)
+
+                for account in accounts:
+                    res2.setdefault(account.id, 0.0)
+                    for child in account.child_ids:
+                        if account.id != child.id:
+                            res[account.id][f] += res.get(child.id, {}).get(f, 0.0)
+                            res[account.id][f] += res2.get(child.id, 0.0)
+
+                # sum both result on account_id
+                for id in ids:
+                    res[id][f] = round(res[id][f], dp) + round(res2.get(id, 0.0), dp)
+
+        return res
+
     def _ca_invoiced_calc(self, cr, uid, ids, name, arg, context=None):
         res = {}
         parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
@@ -44,101 +248,6 @@ class account_analytic_account(osv.osv):
 
         return self._compute_currency_for_level_tree(cr, uid, ids, parent_ids, res, context)
 
-    def _ca_to_invoice_calc(self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        res2 = {}
-        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-        if parent_ids:
-            # Amount uninvoiced hours to invoice at sale price
-            # Warning
-            # This computation doesn't take care of pricelist !
-            # Just consider list_price
-            cr.execute("""SELECT account_analytic_account.id, \
-                        COALESCE(sum (product_template.list_price * \
-                            account_analytic_line.unit_amount * \
-                            ((100-hr_timesheet_invoice_factor.factor)/100)),0.0) \
-                            AS ca_to_invoice \
-                    FROM product_template \
-                    join product_product \
-                        on product_template.id = product_product.product_tmpl_id \
-                    JOIN account_analytic_line \
-                        on account_analytic_line.product_id = product_product.id \
-                    JOIN account_analytic_journal \
-                        on account_analytic_line.journal_id = account_analytic_journal.id \
-                    JOIN account_analytic_account \
-                        on account_analytic_account.id = account_analytic_line.account_id \
-                    JOIN hr_timesheet_invoice_factor \
-                        on hr_timesheet_invoice_factor.id = account_analytic_account.to_invoice \
-                    WHERE account_analytic_account.id IN %s \
-                        AND account_analytic_line.invoice_id is null \
-                        AND account_analytic_line.to_invoice IS NOT NULL \
-                        and account_analytic_journal.type in ('purchase','general') \
-                    GROUP BY account_analytic_account.id;""",(parent_ids,))
-            for account_id, sum in cr.fetchall():
-                res[account_id] = round(sum,2)
-
-        for obj_id in ids:
-            res.setdefault(obj_id, 0.0)
-            res2.setdefault(obj_id, 0.0)
-            for child_id in self.search(cr, uid,
-                    [('parent_id', 'child_of', [obj_id])]):
-                if child_id != obj_id:
-                    res[obj_id] += res.get(child_id, 0.0)
-                    res2[obj_id] += res2.get(child_id, 0.0)
-        # sum both result on account_id
-        for id in ids:
-            res[id] = round(res.get(id, 0.0),2) + round(res2.get(id, 0.0),2)
-        return res
-
-    def _hours_qtt_non_invoiced_calc (self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-        if parent_ids:
-            cr.execute("select account_analytic_line.account_id, COALESCE(sum(unit_amount),0.0) \
-                    from account_analytic_line \
-                    join account_analytic_journal \
-                        on account_analytic_line.journal_id = account_analytic_journal.id \
-                    where account_analytic_line.account_id IN %s \
-                        and account_analytic_journal.type='general' \
-                        and invoice_id is null \
-                        AND to_invoice IS NOT NULL \
-                    GROUP BY account_analytic_line.account_id;",(parent_ids,))
-            for account_id, sum in cr.fetchall():
-                res[account_id] = round(sum,2)
-        for obj_id in ids:
-            res.setdefault(obj_id, 0.0)
-            for child_id in self.search(cr, uid,
-                    [('parent_id', 'child_of', [obj_id])]):
-                if child_id != obj_id:
-                    res[obj_id] += res.get(child_id, 0.0)
-        for id in ids:
-            res[id] = round(res.get(id, 0.0),2)
-        return res
-
-    def _hours_quantity_calc(self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-        if parent_ids:
-            cr.execute("select account_analytic_line.account_id,COALESCE(SUM(unit_amount),0.0) \
-                    from account_analytic_line \
-                    join account_analytic_journal \
-                        on account_analytic_line.journal_id = account_analytic_journal.id \
-                    where account_analytic_line.account_id IN %s \
-                        and account_analytic_journal.type='general' \
-                    GROUP BY account_analytic_line.account_id",(parent_ids,))
-            ff =  cr.fetchall()
-            for account_id, sum in ff:
-                res[account_id] = round(sum,2)
-        for obj_id in ids:
-            res.setdefault(obj_id, 0.0)
-            for child_id in self.search(cr, uid,
-                    [('parent_id', 'child_of', [obj_id])]):
-                if child_id != obj_id:
-                    res[obj_id] += res.get(child_id, 0.0)
-        for id in ids:
-            res[id] = round(res.get(id, 0.0),2)
-        return res
-
     def _total_cost_calc(self, cr, uid, ids, name, arg, context=None):
         res = {}
         parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
@@ -155,117 +264,6 @@ class account_analytic_account(osv.osv):
                 res[account_id] = round(sum,2)
         return self._compute_currency_for_level_tree(cr, uid, ids, parent_ids, res, context)
 
-    # TODO Take care of pricelist and purchase !
-    def _ca_theorical_calc(self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        res2 = {}
-        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-        # Warning
-        # This computation doesn't take care of pricelist !
-        # Just consider list_price
-        if parent_ids:
-            cr.execute("""select account_analytic_line.account_id as account_id, \
-                        COALESCE(sum((account_analytic_line.unit_amount * pt.list_price) \
-                            - (account_analytic_line.unit_amount * pt.list_price \
-                                * hr.factor)),0.0) as somme
-                    from account_analytic_line \
-                    left join account_analytic_journal \
-                        on (account_analytic_line.journal_id = account_analytic_journal.id) \
-                    join product_product pp \
-                        on (account_analytic_line.product_id = pp.id) \
-                    join product_template pt \
-                        on (pp.product_tmpl_id = pt.id) \
-                    join account_analytic_account a \
-                        on (a.id=account_analytic_line.account_id) \
-                    join hr_timesheet_invoice_factor hr \
-                        on (hr.id=a.to_invoice) \
-                where account_analytic_line.account_id IN %s \
-                    and a.to_invoice IS NOT NULL \
-                    and account_analytic_journal.type IN ('purchase','general')
-                GROUP BY account_analytic_line.account_id""",(parent_ids,))
-            for account_id, sum in cr.fetchall():
-                res2[account_id] = round(sum,2)
-
-        for obj_id in ids:
-            res.setdefault(obj_id, 0.0)
-            res2.setdefault(obj_id, 0.0)
-            for child_id in self.search(cr, uid,
-                    [('parent_id', 'child_of', [obj_id])]):
-                if child_id != obj_id:
-                    res[obj_id] += res.get(child_id, 0.0)
-                    res[obj_id] += res2.get(child_id, 0.0)
-
-        # sum both result on account_id
-        for id in ids:
-            res[id] = round(res.get(id, 0.0),2) + round(res2.get(id, 0.0),2)
-        return res
-
-    def _last_worked_date_calc (self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-        if parent_ids:
-            cr.execute("select account_analytic_line.account_id, max(date) \
-                    from account_analytic_line \
-                    where account_id IN %s \
-                        and invoice_id is null \
-                    GROUP BY account_analytic_line.account_id" ,(parent_ids,))
-            for account_id, sum in cr.fetchall():
-                res[account_id] = sum
-        for obj_id in ids:
-            res.setdefault(obj_id, '')
-            for child_id in self.search(cr, uid,
-                    [('parent_id', 'child_of', [obj_id])]):
-                if res[obj_id] < res.get(child_id, ''):
-                    res[obj_id] = res.get(child_id, '')
-        for id in ids:
-            res[id] = res.get(id, '')
-        return res
-
-    def _last_invoice_date_calc (self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-        if parent_ids:
-            cr.execute ("select account_analytic_line.account_id, \
-                        date(max(account_invoice.date_invoice)) \
-                    from account_analytic_line \
-                    join account_invoice \
-                        on account_analytic_line.invoice_id = account_invoice.id \
-                    where account_analytic_line.account_id IN %s \
-                        and account_analytic_line.invoice_id is not null \
-                    GROUP BY account_analytic_line.account_id",(parent_ids,))
-            for account_id, sum in cr.fetchall():
-                res[account_id] = sum
-        for obj_id in ids:
-            res.setdefault(obj_id, '')
-            for child_id in self.search(cr, uid,
-                    [('parent_id', 'child_of', [obj_id])]):
-                if res[obj_id] < res.get(child_id, ''):
-                    res[obj_id] = res.get(child_id, '')
-        for id in ids:
-            res[id] = res.get(id, '')
-        return res
-
-    def _last_worked_invoiced_date_calc (self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-        if parent_ids:
-            cr.execute("select account_analytic_line.account_id, max(date) \
-                    from account_analytic_line \
-                    where account_id IN %s \
-                        and invoice_id is not null \
-                    GROUP BY account_analytic_line.account_id;",(parent_ids,))
-            for account_id, sum in cr.fetchall():
-                res[account_id] = sum
-        for obj_id in ids:
-            res.setdefault(obj_id, '')
-            for child_id in self.search(cr, uid,
-                    [('parent_id', 'child_of', [obj_id])]):
-                if res[obj_id] < res.get(child_id, ''):
-                    res[obj_id] = res.get(child_id, '')
-        for id in ids:
-            res[id] = res.get(id, '')
-        return res
-
     def _remaining_hours_calc(self, cr, uid, ids, name, arg, context=None):
         res = {}
         for account in self.browse(cr, uid, ids):
@@ -338,42 +336,16 @@ class account_analytic_account(osv.osv):
             res[id] = round(res.get(id, 0.0),2)
         return res
 
-    def _month(self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        for id in ids:
-            parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-            if parent_ids:
-                cr.execute('SELECT DISTINCT(month_id) FROM account_analytic_analysis_summary_month ' \
-                        'WHERE account_id IN %s AND unit_amount <> 0.0',(parent_ids,))
-                res[id] = [int(id * 1000000 + int(x[0])) for x in cr.fetchall()]
-            else:
-                res[id] = []
-        return res
-
-    def _user(self, cr, uid, ids, name, arg, context=None):
-        res = {}
-        cr.execute('SELECT MAX(id) FROM res_users')
-        max_user = cr.fetchone()[0]
-        for id in ids:
-            parent_ids = tuple(self.search(cr, uid, [('parent_id', 'child_of', ids)]))
-            if parent_ids:
-                cr.execute('SELECT DISTINCT("user") FROM account_analytic_analysis_summary_user ' \
-                        'WHERE account_id IN %s AND unit_amount <> 0.0',(parent_ids,))
-                res[id] = [int((id * max_user) + x[0]) for x in cr.fetchall()]
-            else:
-                res[id] = []
-        return res
-
     _columns ={
         'ca_invoiced': fields.function(_ca_invoiced_calc, method=True, type='float', string='Invoiced Amount', help="Total customer invoiced amount for this account."),
         'total_cost': fields.function(_total_cost_calc, method=True, type='float', string='Total Costs', help="Total of costs for this account. It includes real costs (from invoices) and indirect costs, like time spent on timesheets."),
-        'ca_to_invoice': fields.function(_ca_to_invoice_calc, method=True, type='float', string='Uninvoiced Amount', help="If invoice from analytic account, the remaining amount you can invoice to the customer based on the total costs."),
-        'ca_theorical': fields.function(_ca_theorical_calc, method=True, type='float', string='Theorical Revenue', help="Based on the costs you had on the project, what would have been the revenue if all these costs have been invoiced at the normal sale price provided by the pricelist."),
-        'hours_quantity': fields.function(_hours_quantity_calc, method=True, type='float', string='Hours Tot', help="Number of hours you spent on the analytic account (from timesheet). It computes on all journal of type 'general'."),
-        'last_invoice_date': fields.function(_last_invoice_date_calc, method=True, type='date', string='Last Invoice Date', help="Date of the last invoice created for this analytic account."),
-        'last_worked_invoiced_date': fields.function(_last_worked_invoiced_date_calc, method=True, type='date', string='Date of Last Invoiced Cost', help="If invoice from the costs, this is the date of the latest work or cost that have been invoiced."),
-        'last_worked_date': fields.function(_last_worked_date_calc, method=True, type='date', string='Date of Last Cost/Work', help="Date of the latest work done on this account."),
-        'hours_qtt_non_invoiced': fields.function(_hours_qtt_non_invoiced_calc, method=True, type='float', string='Uninvoiced Hours', help="Number of hours (from journal of type 'general') that can be invoiced if you invoice based on analytic account."),
+        'ca_to_invoice': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='float', string='Uninvoiced Amount', help="If invoice from analytic account, the remaining amount you can invoice to the customer based on the total costs."),
+        'ca_theorical': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='float', string='Theorical Revenue', help="Based on the costs you had on the project, what would have been the revenue if all these costs have been invoiced at the normal sale price provided by the pricelist."),
+        'hours_quantity': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='float', string='Hours Tot', help="Number of hours you spent on the analytic account (from timesheet). It computes on all journal of type 'general'."),
+        'last_invoice_date': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='date', string='Last Invoice Date', help="Date of the last invoice created for this analytic account."),
+        'last_worked_invoiced_date': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='date', string='Date of Last Invoiced Cost', help="If invoice from the costs, this is the date of the latest work or cost that have been invoiced."),
+        'last_worked_date': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='date', string='Date of Last Cost/Work', help="Date of the latest work done on this account."),
+        'hours_qtt_non_invoiced': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='float', string='Uninvoiced Hours', help="Number of hours (from journal of type 'general') that can be invoiced if you invoice based on analytic account."),
         'hours_qtt_invoiced': fields.function(_hours_qtt_invoiced_calc, method=True, type='float', string='Invoiced Hours', help="Number of hours that can be invoiced plus those that already have been invoiced."),
         'remaining_hours': fields.function(_remaining_hours_calc, method=True, type='float', string='Remaining Hours', help="Computed using the formula: Maximum Quantity - Hours Tot."),
         'remaining_ca': fields.function(_remaining_ca_calc, method=True, type='float', string='Remaining Revenue', help="Computed using the formula: Max Invoice Price - Invoiced Amount."),
@@ -381,8 +353,8 @@ class account_analytic_account(osv.osv):
         'real_margin': fields.function(_real_margin_calc, method=True, type='float', string='Real Margin', help="Computed using the formula: Invoiced Amount - Total Costs."),
         'theorical_margin': fields.function(_theorical_margin_calc, method=True, type='float', string='Theorical Margin', help="Computed using the formula: Theorial Revenue - Total Costs"),
         'real_margin_rate': fields.function(_real_margin_rate_calc, method=True, type='float', string='Real Margin Rate (%)', help="Computes using the formula: (Real Margin / Total Costs) * 100."),
-        'month_ids': fields.function(_month, method=True, type='many2many', relation='account_analytic_analysis.summary.month', string='Month'),
-        'user_ids': fields.function(_user, method=True, type="many2many", relation='account_analytic_analysis.summary.user', string='User'),
+        'month_ids': fields.function(_analysis_all, method=True, multi='analytic_analysis', type='many2many', relation='account_analytic_analysis.summary.month', string='Month'),
+        'user_ids': fields.function(_analysis_all, method=True, multi='analytic_analysis', type="many2many", relation='account_analytic_analysis.summary.user', string='User'),
     }
 
 account_analytic_account()

From f23546a7c0f1871041a5633de08db43db7f9f810 Mon Sep 17 00:00:00 2001
From: "olt@tinyerp.com" <>
Date: Thu, 23 Sep 2010 16:23:34 +0200
Subject: [PATCH 13/13] [IMP] performance improvement: using a map (from 1 sql
 query) instead of queries in loop

bzr revid: olt@tinyerp.com-20100923142334-us9n6pdza0f5i25b
---
 addons/hr_timesheet_invoice/hr_timesheet_invoice.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/addons/hr_timesheet_invoice/hr_timesheet_invoice.py b/addons/hr_timesheet_invoice/hr_timesheet_invoice.py
index cc6137313b1..ed1c8394de1 100644
--- a/addons/hr_timesheet_invoice/hr_timesheet_invoice.py
+++ b/addons/hr_timesheet_invoice/hr_timesheet_invoice.py
@@ -44,17 +44,22 @@ class account_analytic_account(osv.osv):
         if context is None:
             context = {}
         res = {}
+
+        cr.execute('select account_id as account_id, l.invoice_id from hr_analytic_timesheet h left join account_analytic_line l on (h.line_id=l.id)')
+        account_to_invoice_map = {}
+        for rec in cr.dictfetchall():
+            account_to_invoice_map.setdefault(rec['account_id'], []).append(rec['invoice_id'])
+
         for account in self.browse(cr, uid, ids, context=context):
             invoiced = {}
-            cr.execute('select distinct(l.invoice_id) from hr_analytic_timesheet h left join account_analytic_line l on (h.line_id=l.id) where account_id=%s', (account.id,))
-            invoice_ids = filter(None, map(lambda x: x[0], cr.fetchall()))
+            invoice_ids = filter(None, list(set(account_to_invoice_map.get(account.id, []))))
             for invoice in obj_invoice.browse(cr, uid, invoice_ids, context=context):
                 res.setdefault(account.id, 0.0)
                 res[account.id] += invoice.amount_untaxed
         for id in ids:
             res[id] = round(res.get(id, 0.0),2)
-        return res
 
+        return res
 
     _inherit = "account.analytic.account"
     _columns = {