From 11f52c9ee856387d95f15657d865bc65bdd534cd Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Fri, 19 Dec 2014 17:47:04 +0100 Subject: [PATCH] [FIX] payment_buckaroo: copy values dict to avoid altering original dict _buckaroo_generate_digital_sign uses the values dict to generate the shasign At some point, it alters the dict, it removes BRQ_SIGNATURE, but, as the values dict was not copied, it altered the original dict. So, the key BRQ_SIGNATURE was not anymore present for methods called after _buckaroo_generate_digital_sign. For instance, the overriden method form_feedback of website_sale payment --- addons/payment_buckaroo/models/buckaroo.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/addons/payment_buckaroo/models/buckaroo.py b/addons/payment_buckaroo/models/buckaroo.py index 6e504ef14be..41c143fad27 100644 --- a/addons/payment_buckaroo/models/buckaroo.py +++ b/addons/payment_buckaroo/models/buckaroo.py @@ -57,6 +57,8 @@ class AcquirerBuckaroo(osv.Model): return values[key] return '' + values = dict(values or {}) + if inout == 'out': if 'BRQ_SIGNATURE' in values: del values['BRQ_SIGNATURE']