From 188241ce00fb4e10315e568e3dabe6cbad0fce56 Mon Sep 17 00:00:00 2001 From: Gery Debongnie Date: Wed, 7 May 2014 16:07:18 +0200 Subject: [PATCH] [FIX] code cleanup (addon hr_contract) simplify the method _contracts_count, remove try/except/pass statements bzr revid: ged@openerp.com-20140507140718-waw1di92qicsch2z --- addons/hr_contract/hr_contract.py | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/addons/hr_contract/hr_contract.py b/addons/hr_contract/hr_contract.py index d641c490ec2..798ee46832d 100644 --- a/addons/hr_contract/hr_contract.py +++ b/addons/hr_contract/hr_contract.py @@ -39,13 +39,11 @@ class hr_employee(osv.osv): return res def _contracts_count(self, cr, uid, ids, field_name, arg, context=None): - res = dict(map(lambda x: (x,0), ids)) - try: - for employee in self.browse(cr, uid, ids, context=context): - res[employee.id] = len(employee.contract_ids) - except: - pass - return res + Contract = self.pool['hr.contract'] + return { + employee_id: Contract.search_count(cr,uid, [('employee_id', '=', employee_id)], context=context) + for employee_id in ids + } _columns = { 'manager': fields.boolean('Is a Manager'),