From 1d97ddfd8178bbb197f6b48cd549bf10c89bdd55 Mon Sep 17 00:00:00 2001 From: Eric Antones Date: Fri, 11 Dec 2015 12:21:54 +0100 Subject: [PATCH] [FIX] Collateral effect merging query params The keep_query() function has to **keep** all or selected query parameters or add new ones but not change them by merging those with the same name. That unnecessary parameter merge breaks the *Change language* feature in the website_sale module when *Website -> Customize -> Product Attribute's filters* is enabled and there's 2 or more select type attributes created and at least one of them is selected. Merging params was added in: * 8.0: commit 7759af7c4cd948f428eb4bebd72228a335cc6eab * 9.0: commit daf8bdf688a8d7c3a8799b45f3c983a589232fa2 --- openerp/addons/base/ir/ir_ui_view.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/openerp/addons/base/ir/ir_ui_view.py b/openerp/addons/base/ir/ir_ui_view.py index d75046fe3f3..27294f3de21 100644 --- a/openerp/addons/base/ir/ir_ui_view.py +++ b/openerp/addons/base/ir/ir_ui_view.py @@ -68,7 +68,7 @@ def keep_query(*keep_params, **additional_params): for keep_param in keep_params: for param in fnmatch.filter(qs_keys, keep_param): if param not in additional_params and param in qs_keys: - params[param] = ','.join(request.httprequest.args.getlist(param)) + params[param] = request.httprequest.args.getlist(param) return werkzeug.urls.url_encode(params) class view_custom(osv.osv):