From 2801d91337ec2c4227d761e8c12369f790a31c30 Mon Sep 17 00:00:00 2001
From: "Quentin (OpenERP)" <qdp-launchpad@openerp.com>
Date: Wed, 21 Mar 2012 17:29:56 +0100
Subject: [PATCH] [REF] reducing the diff toward trunk by removing the
 assignation to group 'No One' on fields that are already in a <group> tag
 with such an assignation + review of the work done

bzr revid: qdp-launchpad@openerp.com-20120321162956-kyxo5mu1rjwjoqe3
---
 addons/crm/crm_lead_view.xml                  | 28 ++++++++--------
 addons/crm_claim/crm_claim_view.xml           |  8 ++---
 .../crm_fundraising/crm_fundraising_view.xml  |  6 ++--
 addons/crm_helpdesk/crm_helpdesk_view.xml     |  6 ++--
 addons/document/document_view.xml             |  8 ++---
 addons/event/event_view.xml                   |  4 +--
 addons/hr_expense/hr_expense_view.xml         |  8 ++---
 addons/hr_recruitment/hr_recruitment_view.xml | 10 +++---
 addons/project/project_view.xml               |  8 ++---
 addons/project_issue/project_issue_view.xml   | 32 +++++++++----------
 addons/purchase/purchase_view.xml             |  6 ++--
 addons/sale/sale_view.xml                     |  4 +--
 .../sale_order_dates_view.xml                 |  6 ++--
 addons/stock/stock_view.xml                   |  6 ++--
 14 files changed, 70 insertions(+), 70 deletions(-)

diff --git a/addons/crm/crm_lead_view.xml b/addons/crm/crm_lead_view.xml
index 62caa35a809..a97cfe21bad 100644
--- a/addons/crm/crm_lead_view.xml
+++ b/addons/crm/crm_lead_view.xml
@@ -177,11 +177,11 @@
                         <field name="referred"/>
                     </group>
                     <group colspan="2" col="2" groups="base.group_no_one">
-                        <separator string="Dates" colspan="2" col="2" />
-                        <field name="create_date" groups="base.group_no_one"/>
-                        <field name="write_date" groups="base.group_no_one"/>
-                        <field name="date_open" groups="base.group_no_one"/>
-                        <field name="date_closed" groups="base.group_no_one"/>
+                        <separator string="Dates" colspan="2" col="2"/>
+                        <field name="create_date"/>
+                        <field name="write_date"/>
+                        <field name="date_open"/>
+                        <field name="date_closed"/>
                     </group>
                     <group colspan="2" col="2">
                         <separator string="Mailings" colspan="2" col="2"/>
@@ -189,9 +189,9 @@
                         <field name="optout" on_change="on_change_optout(optout)"/>
                     </group>
                     <group colspan="2" col="2" groups="base.group_no_one">
-                        <separator string="Statistics" colspan="2" col="2" />
-                        <field name="day_open" groups="base.group_no_one"/>
-                        <field name="day_close" groups="base.group_no_one"/>
+                        <separator string="Statistics" colspan="2" col="2"/>
+                        <field name="day_open"/>
+                        <field name="day_close"/>
                     </group>
                  </page>
                 </notebook>
@@ -417,7 +417,7 @@
                     <separator orientation="vertical"/>
                     <filter string="Stage" icon="terp-stage" domain="[]" context="{'group_by':'stage_id'}"/>
                     <filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
-                    <separator orientation="vertical"/>
+                    <separator orientation="vertical" groups="base.group_no_one"/>
                     <filter string="Creation" help="Create date" icon="terp-go-month"
                         domain="[]" context="{'group_by':'create_date'}" groups="base.group_no_one"/>
                 </group>
@@ -572,13 +572,13 @@
                 <page string="Extra Info" groups="base.group_extended">
                     <group col="2" colspan="2" groups="base.group_no_one">
                         <separator string="Dates" colspan="2"/>
-                        <field name="create_date" groups="base.group_no_one"/>
-                        <field name="write_date" groups="base.group_no_one"/>
-                        <field name="date_closed" groups="base.group_no_one"/>
-                        <field name="date_open" groups="base.group_no_one"/>
+                        <field name="create_date"/>
+                        <field name="write_date"/>
+                        <field name="date_closed"/>
+                        <field name="date_open"/>
                     </group>
                     <group col="2" colspan="2">
-                        <separator string="Misc" colspan="2" groups="base.group_no_one"/>
+                        <separator string="Misc" colspan="2"/>
                         <field name="active"/>
                         <field name="day_open" groups="base.group_no_one"/>
                         <field name="day_close" groups="base.group_no_one"/>
diff --git a/addons/crm_claim/crm_claim_view.xml b/addons/crm_claim/crm_claim_view.xml
index 2ab5f57ee09..fde63a3a367 100644
--- a/addons/crm_claim/crm_claim_view.xml
+++ b/addons/crm_claim/crm_claim_view.xml
@@ -49,7 +49,7 @@
                     <field name="categ_id" string="Type" select="1"/>
                     <field name="stage_id" invisible="1"/>
                     <field name="date_deadline" invisible="1"/>
-                    <field name="date_closed" invisible="1" groups="base.group_no_one"/>
+                    <field name="date_closed" invisible="1"/>
                     <field name="state"/>
                     <button name="case_open" string="Open"
                         states="draft,pending" type="object"
@@ -132,9 +132,9 @@
                                 </group>
                                 <group colspan="2" col="2" groups="base.group_no_one">
                                     <separator colspan="2" string="Dates"/>
-                                    <field name="create_date" groups="base.group_no_one"/>
-                                    <field name="date_closed" groups="base.group_no_one"/>
-                                    <field name="write_date" groups="base.group_no_one"/>
+                                    <field name="create_date"/>
+                                    <field name="date_closed"/>
+                                    <field name="write_date"/>
                                 </group>
 
                                 <group colspan="2" col="2">
diff --git a/addons/crm_fundraising/crm_fundraising_view.xml b/addons/crm_fundraising/crm_fundraising_view.xml
index dab6088c61a..dd2a87baa31 100644
--- a/addons/crm_fundraising/crm_fundraising_view.xml
+++ b/addons/crm_fundraising/crm_fundraising_view.xml
@@ -164,9 +164,9 @@
                             </group>
                             <group col="2" colspan="2" groups="base.group_no_one">
                                 <separator colspan="4" string="Dates"/>
-                                <field name="create_date" groups="base.group_no_one"/>
-                                <field name="date_closed" groups="base.group_no_one"/>
-                                <field name="duration" groups="base.group_no_one"/>
+                                <field name="create_date"/>
+                                <field name="date_closed"/>
+                                <field name="duration"/>
                             </group>
                             <newline/>
                             <group colspan="4" col="2">
diff --git a/addons/crm_helpdesk/crm_helpdesk_view.xml b/addons/crm_helpdesk/crm_helpdesk_view.xml
index 2341d6406f9..3f0d69eacc1 100644
--- a/addons/crm_helpdesk/crm_helpdesk_view.xml
+++ b/addons/crm_helpdesk/crm_helpdesk_view.xml
@@ -118,9 +118,9 @@
                         <page string="Extra Info" groups="base.group_extended">
                             <group colspan="2" col="2" groups="base.group_no_one">
                                 <separator colspan="4" string="Dates"/>
-                                <field name="create_date" groups="base.group_no_one"/>
-                                <field name="write_date" groups="base.group_no_one"/>
-                                <field name="date_closed" groups="base.group_no_one"/>
+                                <field name="create_date"/>
+                                <field name="write_date"/>
+                                <field name="date_closed"/>
                             </group>
                             <group colspan="2" col="2">
                                 <separator colspan="4" string="Misc"/>
diff --git a/addons/document/document_view.xml b/addons/document/document_view.xml
index 24c2e86d4dc..e426444f26d 100644
--- a/addons/document/document_view.xml
+++ b/addons/document/document_view.xml
@@ -266,13 +266,13 @@
                     </group>
                     <group col="2" colspan="2" groups="base.group_no_one">
                         <separator string="Created" colspan="2"/>
-                        <field name="create_uid" readonly="1" groups="base.group_no_one"/>
-                        <field name="create_date" readonly="1" groups="base.group_no_one"/>
+                        <field name="create_uid" readonly="1"/>
+                        <field name="create_date" readonly="1"/>
                     </group>
                     <group col="2" colspan="2" groups="base.group_no_one">
                         <separator string="Modified" colspan="2"/>
-                        <field name="write_uid" readonly="1" groups="base.group_no_one"/>
-                        <field name="write_date" readonly="1" groups="base.group_no_one"/>
+                        <field name="write_uid" readonly="1"/>
+                        <field name="write_date" readonly="1"/>
                     </group>
                 </page>
                 <page string="Indexed Content - experimental" groups="base.group_extended">
diff --git a/addons/event/event_view.xml b/addons/event/event_view.xml
index 85edcbd1fe8..16162fe3d86 100644
--- a/addons/event/event_view.xml
+++ b/addons/event/event_view.xml
@@ -299,10 +299,10 @@
                                 <field name="email"/>
                                 <field name="phone"/>
                             </group>
-                            <group colspan="2" col="2" groups="base.group_extended">
+                            <group colspan="2" col="2" groups="base.group_no_one">
                                 <separator string="Dates" colspan="2"/>
                                 <field name="create_date"/>
-                                <field name="date_closed" groups="base.group_no_one"/>
+                                <field name="date_closed"/>
                                 <field name="event_begin_date" />
                                 <field name="event_end_date" />
                             </group>
diff --git a/addons/hr_expense/hr_expense_view.xml b/addons/hr_expense/hr_expense_view.xml
index fb63b2e9a39..da013976097 100644
--- a/addons/hr_expense/hr_expense_view.xml
+++ b/addons/hr_expense/hr_expense_view.xml
@@ -115,10 +115,10 @@
                             <field name="invoice_id" context="{'type':'in_invoice', 'journal_type': 'purchase'}"/>
                             </group>
                             <group col="2" colspan="2" groups="base.group_no_one">
-                            <separator colspan="2" string="Validation"/>
-                            <field name="date_confirm" readonly = "1" groups="base.group_no_one"/>
-                            <field name="date_valid" readonly = "1" groups="base.group_no_one"/>
-                            <field name="user_valid" groups="base.group_no_one"/>
+                                <separator colspan="2" string="Validation"/>
+                                <field name="date_confirm" readonly = "1"/>
+                                <field name="date_valid" readonly = "1"/>
+                                <field name="user_valid"/>
                             </group>
                             <separator colspan="4" string="Notes"/>
                             <field colspan="4" name="note" nolabel="1"/>
diff --git a/addons/hr_recruitment/hr_recruitment_view.xml b/addons/hr_recruitment/hr_recruitment_view.xml
index 2fe62cb52ab..582794c7121 100644
--- a/addons/hr_recruitment/hr_recruitment_view.xml
+++ b/addons/hr_recruitment/hr_recruitment_view.xml
@@ -126,10 +126,10 @@
                         </group>
                         <group col="2" colspan="2" groups="base.group_no_one">
                            <separator colspan="2" string="Dates"/>
-                           <field name="create_date" groups="base.group_no_one"/>
-                           <field name="write_date" groups="base.group_no_one"/>
-                           <field name="date_closed" groups="base.group_no_one"/>
-                           <field name="date_open" groups="base.group_no_one"/>
+                           <field name="create_date"/>
+                           <field name="write_date"/>
+                           <field name="date_closed"/>
+                           <field name="date_open"/>
                         </group>
                         <separator colspan="4" string="Status"/>
                         <group col="8" colspan="4">
@@ -228,7 +228,7 @@
                     <filter string="Stage" icon="terp-stage" domain="[]" context="{'group_by':'stage_id'}"/>
                     <filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
                     <filter string="Source" icon="terp-face-plain" domain="[]" context="{'group_by':'source_id'}"/>
-                    <separator orientation="vertical"/>
+                    <separator orientation="vertical" groups="base.group_no_one"/>
                     <filter string="Creation Date" icon="terp-go-month" domain="[]" context="{'group_by':'create_date'}" groups="base.group_no_one"/>
                 </group>
            </search>
diff --git a/addons/project/project_view.xml b/addons/project/project_view.xml
index 3aeea52bd9d..9477d146ccf 100644
--- a/addons/project/project_view.xml
+++ b/addons/project/project_view.xml
@@ -293,9 +293,9 @@
                             </group>
                             <group colspan="2" col="2" groups="base.group_no_one">
                                 <separator string="Dates" colspan="2"/>
-                                <field name="date_start" groups="base.group_no_one"/>
-                                <field name="date_end" groups="base.group_no_one"/>
-                                <field name="create_date" groups="base.group_no_one"/>
+                                <field name="date_start"/>
+                                <field name="date_end"/>
+                                <field name="create_date"/>
                             </group>
                             <separator string="Miscelleanous" colspan="4"/>
                             <field name="partner_id" />
@@ -510,7 +510,7 @@
                         <filter string="State" name="group_state" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
                         <separator orientation="vertical"/>
                         <filter string="Deadline" icon="terp-gnome-cpu-frequency-applet+" domain="[]" context="{'group_by':'date_deadline'}"/>
-                        <separator orientation="vertical"/>
+                        <separator orientation="vertical" groups="base.group_no_one"/>
                         <filter string="Start Date" icon="terp-go-month" domain="[]" context="{'group_by':'date_start'}" groups="base.group_no_one"/>
                         <filter string="End Date" icon="terp-go-month" domain="[]" context="{'group_by':'date_end'}" groups="base.group_no_one"/>
                     </group>
diff --git a/addons/project_issue/project_issue_view.xml b/addons/project_issue/project_issue_view.xml
index 4bcfa99e411..8bcc7f21c37 100644
--- a/addons/project_issue/project_issue_view.xml
+++ b/addons/project_issue/project_issue_view.xml
@@ -116,23 +116,23 @@
                                 name="%(mail.action_email_compose_message_wizard)d"
                                 icon="terp-mail-message-new" type="action"/>
                         </page>
-                           <page string="Extra Info" groups="base.group_extended">
-                            <group col="2" colspan="2" groups="base.group_no_one">
-                            <separator colspan="2" string="Date"/>
-                            <field name="create_date" groups="base.group_no_one"/>
-                            <field name="write_date"  groups="base.group_no_one"/>
-                            <field name="date_closed" groups="base.group_no_one"/>
-                            <field name="date_open" groups="base.group_no_one"/>
-                            <field name="date_action_last" groups="base.group_no_one"/>
+                           <page string="Extra Info" groups="base.group_no_one">
+                            <group col="2" colspan="2">
+                                <separator colspan="2" string="Date"/>
+                               <field name="create_date"/>
+                                <field name="write_date" />
+                                <field name="date_closed"/>
+                                <field name="date_open"/>
+                                <field name="date_action_last"/>
                             </group>
-                            <group colspan="2" col="2" groups="base.group_no_one">
-                            <separator string="Statistics" colspan="2" col="2"/>
-                            <field name="day_open" groups="base.group_no_one"/>
-                            <field name="day_close" groups="base.group_no_one"/>
-                            <field name="working_hours_open" widget="float_time" groups="base.group_no_one"/>
-                            <field name="working_hours_close" widget="float_time" groups="base.group_no_one"/>
-                            <field name="inactivity_days" groups="base.group_no_one"/>
-                            <field name="days_since_creation" groups="base.group_no_one"/>
+                            <group colspan="2" col="2">
+                                <separator string="Statistics" colspan="2" col="2"/>
+                                <field name="day_open"/>
+                                <field name="day_close"/>
+                                <field name="working_hours_open" widget="float_time"/>
+                                <field name="working_hours_close" widget="float_time"/>
+                                <field name="inactivity_days"/>
+                                <field name="days_since_creation"/>
                             </group>
                             <group colspan="2" col="2">
                             <separator string="References" colspan="2"/>
diff --git a/addons/purchase/purchase_view.xml b/addons/purchase/purchase_view.xml
index 92190d1be79..7106df71d98 100644
--- a/addons/purchase/purchase_view.xml
+++ b/addons/purchase/purchase_view.xml
@@ -221,9 +221,9 @@
                             </group>
                             <newline/>
                             <group colspan="2" col="2" groups="base.group_no_one">
-                            <separator string="Purchase Control" colspan="4"/>
-                            <field name="validator" groups="base.group_no_one"/>
-                            <field name="date_approve" groups="base.group_no_one"/>
+                                <separator string="Purchase Control" colspan="4"/>
+                                <field name="validator"/>
+                                <field name="date_approve"/>
                             </group>
                             <separator string="Invoices" colspan="4"/>
                             <newline/>
diff --git a/addons/sale/sale_view.xml b/addons/sale/sale_view.xml
index baaf31153ca..df1fef586d5 100644
--- a/addons/sale/sale_view.xml
+++ b/addons/sale/sale_view.xml
@@ -237,8 +237,8 @@
                             </group>
                             <group colspan="2" col="2" groups="base.group_no_one">
                                 <separator string="Dates" colspan="2"/>
-                                <field name="create_date" groups="base.group_no_one"/>
-                                <field name="date_confirm" groups="base.group_no_one"/>
+                                <field name="create_date"/>
+                                <field name="date_confirm"/>
                             </group>
                             <separator colspan="4" string="Notes"/>
                             <field colspan="4" name="note" nolabel="1"/>
diff --git a/addons/sale_order_dates/sale_order_dates_view.xml b/addons/sale_order_dates/sale_order_dates_view.xml
index 9ccd935cae7..c6544d5238f 100644
--- a/addons/sale_order_dates/sale_order_dates_view.xml
+++ b/addons/sale_order_dates/sale_order_dates_view.xml
@@ -9,11 +9,11 @@
             <field name="inherit_id" ref="sale.view_order_form"/>
             <field name="arch" type="xml">
                 <field name="create_date" position="after">
-                    <field name="requested_date" groups="base.group_no_one"/>
+                    <field name="requested_date"/>
                 </field>
                 <field name="date_confirm" position="after">
-                    <field name="commitment_date" groups="base.group_no_one"/>
-                    <field name="effective_date" groups="base.group_no_one"/>
+                    <field name="commitment_date"/>
+                    <field name="effective_date"/>
                 </field>
             </field>
         </record>
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 3877d833ac5..6e53f3c3998 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -1584,7 +1584,7 @@
                     <field name="product_id"/>
                     <field name="product_qty" />
                     <field name="product_uom" string="UoM"/>
-                    <field name="date"  groups="base.group_no_one" />
+                    <field name="date" groups="base.group_no_one" />
                     <button name="action_done" states="confirmed,assigned" string="Process" type="object" icon="gtk-go-forward"/>
                 </tree>
             </field>
@@ -1687,7 +1687,7 @@
                         <separator orientation="vertical"/>
                         <filter string="Order" icon="terp-gtk-jump-to-rtl" domain="[]" context="{'group_by':'origin'}"/>
                         <filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
-                        <separator orientation="vertical"/>
+                        <separator orientation="vertical" groups="base.group_no_one"/>
                         <filter string="Order Date" icon="terp-go-month" domain="[]" context="{'group_by':'date'}" groups="base.group_no_one"/>
                     </group>
                 </search>
@@ -1720,7 +1720,7 @@
                         <filter string="Product" icon="terp-accessories-archiver" domain="[]" context="{'group_by':'product_id'}"/>
                         <filter string="Order" icon="terp-gtk-jump-to-rtl" domain="[]" context="{'group_by':'origin'}"/>
                         <filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
-                        <separator orientation="vertical"/>
+                        <separator orientation="vertical" groups="base.group_no_one"/>
                         <filter string="Order Date" icon="terp-go-month" domain="[]" context="{'group_by':'date'}" groups="base.group_no_one"/>
                     </group>
                 </search>