From 2a2398eaf90c6a76f9ecc20fef2fb029c1e5bb84 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Fri, 9 Aug 2013 15:51:41 +0200 Subject: [PATCH] [IMP] lxml doc recommends using .get/.set/.keys/.values/.items for attributes manipulation where possible bzr revid: xmo@openerp.com-20130809135141-114l6262wdts0i43 --- openerp/tools/convert.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/openerp/tools/convert.py b/openerp/tools/convert.py index 13a0f1ab0cf..6c776dcce54 100644 --- a/openerp/tools/convert.py +++ b/openerp/tools/convert.py @@ -846,7 +846,7 @@ form: module.record_id""" % (xml_id,) if '.' in tpl_id: module, tpl_id = tpl_id.split('.', 1) # set the full template name for qweb . - el.attrib['t-name'] = '%s.%s' % (module, tpl_id) + el.set('t-name', '%s.%s' % (module, tpl_id)) el.attrib.pop('id', None) el.tag = 't' @@ -855,7 +855,7 @@ form: module.record_id""" % (xml_id,) 'model': 'ir.ui.view', } for att in ['forcecreate', 'context']: - if att in el.attrib: + if att in el.keys(): record_attrs[att] = el.attrib.pop(att) record = etree.Element('record', attrib=record_attrs)