From 329a1550004dc548e0493f36e643f64c1ec7bd86 Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Tue, 17 May 2011 16:07:26 +0200
Subject: [PATCH] [IMP] add some doc to setup_columns

bzr revid: xmo@openerp.com-20110517140726-9yjdk66nwl7xh3pe
---
 addons/base/static/src/js/list.js | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/addons/base/static/src/js/list.js b/addons/base/static/src/js/list.js
index 81b90ba13ea..16da073e337 100644
--- a/addons/base/static/src/js/list.js
+++ b/addons/base/static/src/js/list.js
@@ -151,10 +151,19 @@ openerp.base.ListView = openerp.base.View.extend( /** @lends openerp.base.ListVi
             this.view_manager.sidebar.set_toolbar(data.fields_view.toolbar);
         }
     },
+    /**
+     * Sets up the listview's columns: merges view and fields data, move
+     * grouped-by columns to the front of the columns list and make them all
+     * visible.
+     *
+     * @param {Object} fields fields_view_get's fields section
+     * @param {Array} groupby_columns columns the ListView is grouped by
+     */
     setup_columns: function (fields, groupby_columns) {
         var self = this;
         var domain_computer = openerp.base.form.compute_domain;
 
+        var noop = function () { return {}; };
         var field_to_column = function (field) {
             var name = field.attrs.name;
             var column = _.extend({id: name, tag: field.tag},
@@ -170,7 +179,7 @@ openerp.base.ListView = openerp.base.View.extend( /** @lends openerp.base.ListVi
                     return result;
                 };
             } else {
-                column.attrs_for = function () { return {}; };
+                column.attrs_for = noop;
             }
             return column;
         };