From 336443d60446f059481cdef3ce954aefc4ff5e76 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Tue, 3 Jul 2012 13:07:00 +0200 Subject: [PATCH] [IMP] hiding of readonly form fields in edition row: don't directly access DOM visibility properties bzr revid: xmo@openerp.com-20120703110700-k0dqtthwo1g36pod --- addons/web/static/src/js/view_list_editable.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/addons/web/static/src/js/view_list_editable.js b/addons/web/static/src/js/view_list_editable.js index 1c477046c2b..0926e233109 100644 --- a/addons/web/static/src/js/view_list_editable.js +++ b/addons/web/static/src/js/view_list_editable.js @@ -150,18 +150,16 @@ openerp.web.list_editable = function (instance) { }, self.editor.edit, [record.attributes, function (field_name, field) { var cell = cells[field_name]; - if (!cell) { return; } + if (!cell || field.get('effective_readonly')) { + // Readonly fields can just remain the list's, form's + // usually don't have backgrounds &al + field.set({invisible: true}); + return; + } var $cell = $(cell); var position = $cell.position(); - // FIXME: this is shit. Is it possible to prefilter? - if (field.get('effective_readonly')) { - // Readonly fields can just remain the list's, form's - // usually don't have backgrounds &al - field.$element.hide(); - return; - } - field.$element.show().css({ + field.$element.css({ top: position.top, left: position.left, width: $cell.outerWidth(),