From 34b03bd24d8db9dcd36477b7e1076ae9b180870b Mon Sep 17 00:00:00 2001 From: Fabien Meghazi Date: Tue, 6 Mar 2012 21:59:55 +0100 Subject: [PATCH] [FIX] Can't add to dashboard a view that includes a 'group_by' lp bug: https://launchpad.net/bugs/948097 fixed bzr revid: fme@openerp.com-20120306205955-zqgtbgtz1gtix4w9 --- addons/web/controllers/main.py | 2 +- addons/web/static/src/js/views.js | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/addons/web/controllers/main.py b/addons/web/controllers/main.py index 165641d8049..71d01e2ef0a 100644 --- a/addons/web/controllers/main.py +++ b/addons/web/controllers/main.py @@ -1359,7 +1359,7 @@ class SearchView(View): if board and 'arch' in board: xml = ElementTree.fromstring(board['arch']) column = xml.find('./board/column') - if column: + if column is not None: new_action = ElementTree.Element('action', { 'name' : str(action_id), 'string' : name, diff --git a/addons/web/static/src/js/views.js b/addons/web/static/src/js/views.js index 56997190bc1..a9979ebf099 100644 --- a/addons/web/static/src/js/views.js +++ b/addons/web/static/src/js/views.js @@ -408,6 +408,9 @@ session.web.ViewManager = session.web.OldWidget.extend(/** @lends session.web.V var groupby = results.group_by.length ? results.group_by : action_context.group_by; + if (_.isString(groupby)) { + groupby = [groupby]; + } controller.do_search(results.domain, results.context, groupby || []); }); },