From 38df72d010f490aef64f5379e60ded510d0b9283 Mon Sep 17 00:00:00 2001 From: Stephane Wirtel Date: Fri, 12 Dec 2008 01:28:15 +0100 Subject: [PATCH] [FIX] Check if dirname is empty or not lp bug: https://launchpad.net/bugs/301983 fixed bzr revid: stephane@tinyerp.com-20081212002815-hcc325x6gjp66lpg --- bin/netsvc.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/bin/netsvc.py b/bin/netsvc.py index 9072421c0b7..a0253c867da 100644 --- a/bin/netsvc.py +++ b/bin/netsvc.py @@ -157,13 +157,12 @@ def init_logger(): if config['logfile']: logf = config['logfile'] - # test if the directories exist, else create them try: dirname = os.path.dirname(logf) - if not os.path.isdir(dirname): - res = os.makedirs(dirname) + if dirname and not os.path.isdir(dirname): + os.makedirs(dirname) handler = logging.handlers.TimedRotatingFileHandler(logf,'D',1,30) - except: + except Exception, ex: sys.stderr.write("ERROR: couldn't create the logfile directory\n") handler = logging.StreamHandler(sys.stdout) else: