From 255bf5806a57937e3e986296236053acd8fcdb64 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Thu, 18 Nov 2010 17:36:27 +0530
Subject: [PATCH 01/10] [IMP]: purchase: Improvment in code product  supplier
 code name display in purchase line

bzr revid: ron@tinyerp.com-20101118120627-7150ordmsx038omu
---
 addons/purchase/purchase.py | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)

diff --git a/addons/purchase/purchase.py b/addons/purchase/purchase.py
index d93a1ec15b1..80ba39d9f35 100644
--- a/addons/purchase/purchase.py
+++ b/addons/purchase/purchase.py
@@ -646,10 +646,7 @@ class purchase_order_line(osv.osv):
             return {'value': {'price_unit': price_unit or 0.0, 'name': name or '',
                 'notes': notes or'', 'product_uom' : uom or False}, 'domain':{'product_uom':[]}}
         prod= self.pool.get('product.product').browse(cr, uid, product)
-        if prod.product_tmpl_id.seller_ids:
-            seller_get_id = prod.product_tmpl_id.seller_ids[0].name.id
-        else:
-            seller_get_id = False
+
 
         lang=False
         if partner_id:
@@ -680,15 +677,22 @@ class purchase_order_line(osv.osv):
                         'date': date_order,
                         })[pricelist]
         dt = (datetime.now() + relativedelta(days=int(seller_delay) or 0.0)).strftime('%Y-%m-%d %H:%M:%S')
-        if seller_get_id == partner_id:
-            prod_suppl_name = self.pool.get('product.product').browse(cr, uid, prod.id).seller_ids[0].product_name
-            prod_suppl_code = self.pool.get('product.product').browse(cr, uid, prod.id).seller_ids[0].product_code
-            if prod_suppl_name == False or prod_suppl_code == False:
-               prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
-            else:
-                prod_name= '[' + prod_suppl_code + '] '+ prod_suppl_name
-        else:
-            prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
+
+        seller_get_id = False
+
+        prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
+
+        for seller_id in prod.product_tmpl_id.seller_ids:
+            if seller_id.name.id == partner_id:
+                prod_suppl_name = seller_id.product_name
+                prod_suppl_code = seller_id.product_code
+                if not (prod_suppl_name or prod_suppl_code):
+                    prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
+                elif (not prod_suppl_name) or (not prod_suppl_code):
+                     prod_name= '[' + (prod_suppl_code or prod.default_code or '') + '] '+ (prod_suppl_name or prod.name or '')
+                else:
+                    prod_name= '[' + prod_suppl_code + '] '+ prod_suppl_name
+
 
         res = {'value': {'price_unit': price, 'name': name or prod_name,
             'taxes_id':map(lambda x: x.id, prod.supplier_taxes_id),

From b5a5314fc04d61ab83492056ce06e712ec4d54c9 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Thu, 18 Nov 2010 19:01:57 +0530
Subject: [PATCH 02/10] [IMP]Add Button  Print delivery order and Return
 Product in Delivery Module .lp BUG:-674578

bzr revid: ron@tinyerp.com-20101118133157-s8w7i43mjbuqxcx4
---
 addons/delivery/delivery_report.xml           |  3 ++-
 addons/delivery/delivery_view.xml             | 19 ++++++++++++++++++-
 addons/stock/stock_view.xml                   |  2 +-
 .../wizard/stock_return_picking_view.xml      | 11 ++++++-----
 4 files changed, 27 insertions(+), 8 deletions(-)

diff --git a/addons/delivery/delivery_report.xml b/addons/delivery/delivery_report.xml
index 14c1d241131..3cebbba4eac 100644
--- a/addons/delivery/delivery_report.xml
+++ b/addons/delivery/delivery_report.xml
@@ -6,7 +6,8 @@
             id="report_shipping"
             model="stock.picking"
             name="sale.shipping"
-            rml="delivery/report/shipping.rml" 
+            multi="True"
+            rml="delivery/report/shipping.rml"
             string="Delivery order"/>
 
     </data>
diff --git a/addons/delivery/delivery_view.xml b/addons/delivery/delivery_view.xml
index b7ec0fed61e..59e58c4f97b 100644
--- a/addons/delivery/delivery_view.xml
+++ b/addons/delivery/delivery_view.xml
@@ -4,6 +4,9 @@
         <!-- Delivery Carriers -->
         <menuitem id="menu_delivery" name="Delivery" parent="stock.menu_stock_configuration" sequence="4"/>
 
+
+
+
         <record id="view_delivery_carrier_tree" model="ir.ui.view">
             <field name="name">delivery.carrier.tree</field>
             <field name="model">delivery.carrier</field>
@@ -266,10 +269,24 @@
             <field name="inherit_id" ref="sale.view_order_form"/>
             <field name="arch" type="xml">
                     <xpath expr="/form/notebook/page[@string='Sales Order']/group[1]/button[@name='button_dummy']" position="after">
-                         <button name="%(action_delivery_cost)d" states="draft" string="Delivery Costs" type="action" icon="gtk-add" context="{'order_id':active_id}"/>                    
+                         <button name="%(action_delivery_cost)d" states="draft" string="Delivery Costs" type="action" icon="gtk-add" context="{'order_id':active_id}"/>
                     </xpath>
             </field>
         </record>
 
+        <record id="view_delivary_order_inherit_stock" model="ir.ui.view">
+            <field name="name">stock.picking.out.form</field>
+            <field name="type">form</field>
+            <field name="model">stock.picking</field>
+            <field name="inherit_id" ref="stock.view_picking_out_form"/>
+            <field name="arch" type="xml">
+                <xpath expr="/form/notebook/page[@string='Products']/group/button[@name='action_process']" position="after">
+                	<button name="%(stock.act_stock_return_picking)d" string="Return Products" states="done" type="action" icon="gtk-execute"/>
+                    <button name="%(report_shipping)d" string="Delivery Order" states="done,assigned" type="action" icon="gtk-print"/>
+                </xpath>
+            </field>
+        </record>
+
+
     </data>
 </openerp>
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 61bc8b887de..a1e3e01fca7 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -911,7 +911,7 @@
                                     </group>
                                 </form>
                             </field>
-                            <group col="10" colspan="4">
+                            <group col="12" colspan="4">
                                 <field name="state" readonly="1"/>
                                 <button name="button_cancel" states="assigned,confirmed,draft" string="_Cancel" icon="gtk-cancel"/>
                                 <button name="draft_force_assign" states="draft" string="Process Later" type="object" icon="gtk-ok"/>
diff --git a/addons/stock/wizard/stock_return_picking_view.xml b/addons/stock/wizard/stock_return_picking_view.xml
index 36a7c23a66f..3f4f2d296d9 100644
--- a/addons/stock/wizard/stock_return_picking_view.xml
+++ b/addons/stock/wizard/stock_return_picking_view.xml
@@ -1,12 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
 <openerp>
     <data>
-         <act_window name="Return Picking"		    
+         <act_window name="Return Picking"
 		    res_model="stock.return.picking"
 		    src_model="stock.picking"
 		    view_mode="form"
-		    target="new"        
-            key2="client_action_multi"    
-		    id="act_stock_return_picking"/>			
+		    target="new"
+            key2="client_action_multi"
+            multi="True"
+		    id="act_stock_return_picking"/>
 	</data>
-</openerp>	
+</openerp>

From 5b647eb30c82b1f3eed3a549ecc08069f0858647 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Fri, 19 Nov 2010 15:35:51 +0530
Subject: [PATCH 03/10] [FIX]Product:EAN code validation fails

lp bug: https://launchpad.net/bugs/606325 fixed

bzr revid: ron@tinyerp.com-20101119100551-gwmlsdp1md2b7z93
---
 addons/product/product.py | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

diff --git a/addons/product/product.py b/addons/product/product.py
index 002add587ee..c3df5c76e3e 100644
--- a/addons/product/product.py
+++ b/addons/product/product.py
@@ -430,7 +430,7 @@ class product_product(osv.osv):
         'active': fields.boolean('Active', help="If the active field is set to true, it will allow you to hide the product without removing it."),
         'variants': fields.char('Variants', size=64),
         'product_tmpl_id': fields.many2one('product.template', 'Product Template', required=True, ondelete="cascade"),
-        'ean13': fields.char('EAN13', size=13),
+        'ean13': fields.char('EAN13', size=14),
         'packaging' : fields.one2many('product.packaging', 'product_id', 'Logistical Units', help="Gives the different ways to package the same product. This has no impact on the picking order and is mainly used if you use the EDI module."),
         'price_extra': fields.float('Variant Price Extra', digits_compute=dp.get_precision('Sale Price')),
         'price_margin': fields.float('Variant Price Margin', digits_compute=dp.get_precision('Sale Price')),
@@ -450,20 +450,29 @@ class product_product(osv.osv):
         for partner in self.browse(cr, uid, ids):
             if not partner.ean13:
                 continue
-            if len(partner.ean13) <> 13:
+            if len(partner.ean13) not in [13,14,8]:
                 return False
             try:
                 int(partner.ean13)
             except:
                 return False
-            sum=0
-            for i in range(12):
+            oddsum=0
+            evensum=0
+            total=0
+            eanvalue=partner.ean13
+            reversevalue = eanvalue[::-1]
+            finalean=reversevalue[1:]
+
+            for i in range(len(finalean)):
                 if is_pair(i):
-                    sum += int(partner.ean13[i])
+                    oddsum += int(finalean[i])
                 else:
-                    sum += 3 * int(partner.ean13[i])
-            check = int(math.ceil(sum / 10.0) * 10 - sum)
-            if check != int(partner.ean13[12]):
+                    evensum += int(finalean[i])
+            total=(oddsum * 3) + evensum
+
+            check = int(10 - math.ceil(total % 10.0))
+
+            if check != int(partner.ean13[-1]):
                 return False
         return True
 

From 05a612012c00d1880266fc26fdf83943ff821296 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Fri, 19 Nov 2010 18:32:08 +0530
Subject: [PATCH 04/10] [IMP]Product:EAN code validation check on
 product_packaging bug:606325

bzr revid: ron@tinyerp.com-20101119130208-u6akfv119p6n0lnu
---
 addons/product/product.py | 65 +++++++++++++++++++++++----------------
 1 file changed, 38 insertions(+), 27 deletions(-)

diff --git a/addons/product/product.py b/addons/product/product.py
index c3df5c76e3e..aa931c20916 100644
--- a/addons/product/product.py
+++ b/addons/product/product.py
@@ -30,6 +30,34 @@ from tools.translate import _
 def is_pair(x):
     return not x%2
 
+def check_ean(ean_code):
+    if not ean_code:
+        return True
+    if len(ean_code) not in [13,14,8]:
+        return False
+    try:
+        int(ean_code)
+    except:
+        return False
+    oddsum=0
+    evensum=0
+    total=0
+    eanvalue=ean_code
+    reversevalue = eanvalue[::-1]
+    finalean=reversevalue[1:]
+
+    for i in range(len(finalean)):
+        if is_pair(i):
+            oddsum += int(finalean[i])
+        else:
+            evensum += int(finalean[i])
+    total=(oddsum * 3) + evensum
+
+    check = int(10 - math.ceil(total % 10.0))
+
+    if check != int(ean_code[-1]):
+        return False
+    return True
 #----------------------------------------------------------
 # UOM
 #----------------------------------------------------------
@@ -448,33 +476,8 @@ class product_product(osv.osv):
 
     def _check_ean_key(self, cr, uid, ids):
         for partner in self.browse(cr, uid, ids):
-            if not partner.ean13:
-                continue
-            if len(partner.ean13) not in [13,14,8]:
-                return False
-            try:
-                int(partner.ean13)
-            except:
-                return False
-            oddsum=0
-            evensum=0
-            total=0
-            eanvalue=partner.ean13
-            reversevalue = eanvalue[::-1]
-            finalean=reversevalue[1:]
-
-            for i in range(len(finalean)):
-                if is_pair(i):
-                    oddsum += int(finalean[i])
-                else:
-                    evensum += int(finalean[i])
-            total=(oddsum * 3) + evensum
-
-            check = int(10 - math.ceil(total % 10.0))
-
-            if check != int(partner.ean13[-1]):
-                return False
-        return True
+            res = check_ean(partner.ean13)
+        return res
 
     _constraints = [(_check_ean_key, 'Error: Invalid ean code', ['ean13'])]
 
@@ -604,6 +607,14 @@ class product_packaging(osv.osv):
     }
 
 
+    def _check_ean_key_r(self, cr, uid, ids):
+        for partner in self.browse(cr, uid, ids):
+            res = check_ean(partner.ean)
+        return res
+
+    _constraints = [(_check_ean_key_r, 'Error: Invalid ean code', ['ean'])]
+
+
     def name_get(self, cr, uid, ids, context={}):
         if not len(ids):
             return []

From 7a502da18682a5d163dec1767ee7b003aac66754 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Mon, 22 Nov 2010 16:39:17 +0530
Subject: [PATCH 05/10] [IMP]product:EAN Code check Function  Improvment

bzr revid: ron@tinyerp.com-20101122110917-1eafwg0o36du4puz
---
 addons/product/product.py | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/addons/product/product.py b/addons/product/product.py
index 471ac4dda2e..a636d5d64fe 100644
--- a/addons/product/product.py
+++ b/addons/product/product.py
@@ -30,19 +30,19 @@ from tools.translate import _
 def is_pair(x):
     return not x%2
 
-def check_ean(ean_code):
-    if not ean_code:
+def check_ean(eancode):
+    if not eancode:
         return True
-    if len(ean_code) not in [13,14,8]:
+    if len(eancode) not in [13,14,8]:
         return False
     try:
-        int(ean_code)
+        int(eancode)
     except:
         return False
     oddsum=0
     evensum=0
     total=0
-    eanvalue=ean_code
+    eanvalue=eancode
     reversevalue = eanvalue[::-1]
     finalean=reversevalue[1:]
 
@@ -55,7 +55,7 @@ def check_ean(ean_code):
 
     check = int(10 - math.ceil(total % 10.0))
 
-    if check != int(ean_code[-1]):
+    if check != int(eancode[-1]):
         return False
     return True
 #----------------------------------------------------------
@@ -481,7 +481,8 @@ class product_product(osv.osv):
 
     def _check_ean_key(self, cr, uid, ids):
         for partner in self.browse(cr, uid, ids):
-            res = check_ean(partner.ean13)
+            eancheck = partner.ean13
+            res = check_ean( eancheck )
         return res
 
     _constraints = [(_check_ean_key, 'Error: Invalid ean code', ['ean13'])]
@@ -614,7 +615,8 @@ class product_packaging(osv.osv):
 
     def _check_ean_key_r(self, cr, uid, ids):
         for partner in self.browse(cr, uid, ids):
-            res = check_ean(partner.ean)
+            eancheckp = partner.ean
+            res = check_ean(eancheckp)
         return res
 
     _constraints = [(_check_ean_key_r, 'Error: Invalid ean code', ['ean'])]

From 327be90e0c43647219003256b296f1fe93ef572a Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Mon, 22 Nov 2010 16:55:03 +0530
Subject: [PATCH 06/10] [FIX]Incomming Shippment:Group By Partner Problem

lp bug: https://launchpad.net/bugs/670921 fixed

bzr revid: ron@tinyerp.com-20101122112503-nd6bykbglmojdo91
---
 addons/stock/stock_view.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index 5b452478582..c80fce972ef 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -786,7 +786,7 @@
                     </group>
                     <newline/>
                     <group expand="0" string="Group By..." colspan="4" col="8">
-                        <filter string="Partner" icon="terp-partner" domain="[]" context="{'group_by':'address_id'}"/>
+                        <filter string="Partner" icon="terp-partner" domain="[]" context="{'group_by':'partner_id'}"/>
                         <separator orientation="vertical" />
                         <filter string="State" icon="terp-stock_effects-object-colorize" domain="[]" context="{'group_by':'state'}"/>
                         <separator orientation="vertical" />

From 68e8e0caecfb20ad56e8cbcb4bc4fd2dd50096b1 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Mon, 22 Nov 2010 18:46:15 +0530
Subject: [PATCH 07/10] [IMP]Improvement in Code

bzr revid: ron@tinyerp.com-20101122131615-l4c5xxidfsokhdvs
---
 addons/product/product.py                       | 4 ++--
 addons/stock/stock_view.xml                     | 1 +
 addons/stock/wizard/stock_invoice_onshipping.py | 3 +--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/product/product.py b/addons/product/product.py
index a636d5d64fe..d810ea8e01f 100644
--- a/addons/product/product.py
+++ b/addons/product/product.py
@@ -33,7 +33,7 @@ def is_pair(x):
 def check_ean(eancode):
     if not eancode:
         return True
-    if len(eancode) not in [13,14,8]:
+    if len(eancode) not in [13]:
         return False
     try:
         int(eancode)
@@ -463,7 +463,7 @@ class product_product(osv.osv):
         'active': fields.boolean('Active', help="If the active field is set to true, it will allow you to hide the product without removing it."),
         'variants': fields.char('Variants', size=64),
         'product_tmpl_id': fields.many2one('product.template', 'Product Template', required=True, ondelete="cascade"),
-        'ean13': fields.char('EAN13', size=14),
+        'ean13': fields.char('EAN13', size=13),
         'packaging' : fields.one2many('product.packaging', 'product_id', 'Logistical Units', help="Gives the different ways to package the same product. This has no impact on the picking order and is mainly used if you use the EDI module."),
         'price_extra': fields.float('Variant Price Extra', digits_compute=dp.get_precision('Sale Price')),
         'price_margin': fields.float('Variant Price Margin', digits_compute=dp.get_precision('Sale Price')),
diff --git a/addons/stock/stock_view.xml b/addons/stock/stock_view.xml
index c80fce972ef..4ef592bd3fd 100644
--- a/addons/stock/stock_view.xml
+++ b/addons/stock/stock_view.xml
@@ -875,6 +875,7 @@
                                     <field name="state"/>
                                     <button name="%(action_partial_move)d" string="Partial" type="action" states="confirmed,assigned" icon="gtk-justify-fill"/>
                                     <button name="action_done" states="confirmed,assigned" string="Process" type="object" icon="gtk-go-forward"/>
+                                    <button name="%(act_stock_return_picking)d" string="Return Products" states="done" type="action" icon="gtk-execute"/>
                                 </tree>
                                 <form string="Stock Moves">
                                     <group colspan="2" col="4">
diff --git a/addons/stock/wizard/stock_invoice_onshipping.py b/addons/stock/wizard/stock_invoice_onshipping.py
index 7924ad0a31b..9af23888b4d 100644
--- a/addons/stock/wizard/stock_invoice_onshipping.py
+++ b/addons/stock/wizard/stock_invoice_onshipping.py
@@ -63,7 +63,6 @@ class stock_invoice_onshipping(osv.osv_memory):
 
 
     _columns = {
-#        'journal_id': fields.many2one('account.journal', 'Destination Journal', required=True,selection=_get_journal_id),
         'journal_id': fields.selection(_get_journal_id, 'Destination Journal',required=True),
         'group': fields.boolean("Group by partner"),
         'invoice_date': fields.date('Invoiced date'),
@@ -86,7 +85,7 @@ class stock_invoice_onshipping(osv.osv_memory):
             raise osv.except_osv(_('Warning !'), _('None of these picking lists require invoicing.'))
         return res
 
-    
+
 
     def create_invoice(self, cr, uid, ids, context=None):
         if context is None:

From 94d6daaa7687a239a38c2bbba53a735714b30ecb Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Mon, 22 Nov 2010 18:49:03 +0530
Subject: [PATCH 08/10] [IMP]Improvement in Code

bzr revid: ron@tinyerp.com-20101122131903-jlh128utajmitfaf
---
 addons/delivery/delivery_view.xml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/addons/delivery/delivery_view.xml b/addons/delivery/delivery_view.xml
index edb0daa151c..57fc4e65dc0 100644
--- a/addons/delivery/delivery_view.xml
+++ b/addons/delivery/delivery_view.xml
@@ -281,7 +281,6 @@
             <field name="inherit_id" ref="stock.view_picking_out_form"/>
             <field name="arch" type="xml">
                 <xpath expr="/form/notebook/page[@string='Products']/group/button[@name='action_process']" position="after">
-                	<button name="%(stock.act_stock_return_picking)d" string="Return Products" states="done" type="action" icon="gtk-execute"/>
                     <button name="%(report_shipping)d" string="Delivery Order" states="done,assigned" type="action" icon="gtk-print"/>
                 </xpath>
             </field>

From ab1e86c9fc0e725b7cc4198aa781a6e399510f47 Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Mon, 22 Nov 2010 19:06:22 +0530
Subject: [PATCH 09/10] [IMP]PO:Improvement in take default code from product
 suppier code

bzr revid: ron@tinyerp.com-20101122133622-4ieg0scgl7f99eve
---
 addons/purchase/purchase.py | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/addons/purchase/purchase.py b/addons/purchase/purchase.py
index 80ba39d9f35..5b1d5b069fa 100644
--- a/addons/purchase/purchase.py
+++ b/addons/purchase/purchase.py
@@ -662,12 +662,22 @@ class purchase_order_line(osv.osv):
             date_order = time.strftime('%Y-%m-%d')
         qty = qty or 1.0
         seller_delay = 0
+        seller_get_id = False
+        prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
         for s in prod.seller_ids:
             if s.name.id == partner_id:
                 seller_delay = s.delay
                 temp_qty = s.qty # supplier _qty assigned to temp
                 if qty < temp_qty: # If the supplier quantity is greater than entered from user, set minimal.
                     qty = temp_qty
+                prod_suppl_name = s.product_name
+                prod_suppl_code = s.product_code
+                if not (prod_suppl_name or prod_suppl_code):
+                    prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
+                elif (not prod_suppl_name) or (not prod_suppl_code):
+                     prod_name= '[' + (prod_suppl_code or prod.default_code or '') + '] '+ (prod_suppl_name or prod.name or '')
+                else:
+                    prod_name= '[' + prod_suppl_code + '] '+ prod_suppl_name
         if price_unit:
             price = price_unit
         else:
@@ -678,21 +688,6 @@ class purchase_order_line(osv.osv):
                         })[pricelist]
         dt = (datetime.now() + relativedelta(days=int(seller_delay) or 0.0)).strftime('%Y-%m-%d %H:%M:%S')
 
-        seller_get_id = False
-
-        prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
-
-        for seller_id in prod.product_tmpl_id.seller_ids:
-            if seller_id.name.id == partner_id:
-                prod_suppl_name = seller_id.product_name
-                prod_suppl_code = seller_id.product_code
-                if not (prod_suppl_name or prod_suppl_code):
-                    prod_name = self.pool.get('product.product').name_get(cr, uid, [prod.id])[0][1]
-                elif (not prod_suppl_name) or (not prod_suppl_code):
-                     prod_name= '[' + (prod_suppl_code or prod.default_code or '') + '] '+ (prod_suppl_name or prod.name or '')
-                else:
-                    prod_name= '[' + prod_suppl_code + '] '+ prod_suppl_name
-
 
         res = {'value': {'price_unit': price, 'name': name or prod_name,
             'taxes_id':map(lambda x: x.id, prod.supplier_taxes_id),

From 6738d345c01c0345d8c8aed4a29da00579391e5c Mon Sep 17 00:00:00 2001
From: "ron@tinyerp.com" <>
Date: Tue, 23 Nov 2010 17:25:55 +0530
Subject: [PATCH 10/10] [IMP]Purchase :YML testing(warning for Pending Invoice
 is not created)

bzr revid: ron@tinyerp.com-20101123115555-ruqegn9kwqkz4360
---
 addons/purchase/test/purchase_from_manual.yml | 19 +++++++------
 .../purchase/test/purchase_from_picking.yml   | 27 +++++++++----------
 2 files changed, 22 insertions(+), 24 deletions(-)

diff --git a/addons/purchase/test/purchase_from_manual.yml b/addons/purchase/test/purchase_from_manual.yml
index 0c406635b85..6b95748bc4d 100644
--- a/addons/purchase/test/purchase_from_manual.yml
+++ b/addons/purchase/test/purchase_from_manual.yml
@@ -21,17 +21,16 @@
     warranty: 0.0
     weight: 0.0
     weight_net: 0.0
-- 
+-
   In order to test the purchase flow,I create a new record where "invoice_method" is From Manual
 -
   I create purchase order for iPod.
-- 
+-
   !record {model: purchase.order, id: purchase_order_po1}:
     company_id: base.main_company
     date_order: '2010-05-11'
     invoice_method: manual
     location_id: stock.stock_location_stock
-    name: PO00010
     order_line:
       - date_planned: '2010-05-13'
         name: iPod
@@ -47,16 +46,16 @@
   Initially purchase order is in the draft state
 -
   !assert {model: purchase.order, id: purchase_order_po1}:
-    - state == 'draft'  
+    - state == 'draft'
 -
   I confirm the purchase order.
 -
   !workflow {model: purchase.order, action: purchase_confirm, ref: purchase_order_po1}
--  
+-
   I check that the order which was initially in the draft state has transit to confirm state.
 -
   !assert {model: purchase.order, id: purchase_order_po1}:
-    - state == 'approved'  
+    - state == 'approved'
 -
   I check that an entry gets created in the "Lines to Invoice" of Invoice Control on the basis of purchase order line
 -
@@ -68,7 +67,7 @@
     assert search_ids, _('Purchase order line is not created!')
 -
   To check that wizard "Create Invoices" gets opened
-- 
+-
   I create purchase order line invoice entry.
 -
   !record {model: purchase.order.line_invoice, id: purchase_order_line_invoice_0}:
@@ -77,7 +76,7 @@
   I create invoice for products in the purchase order.
 -
   !python {model: purchase.order.line_invoice}: |
-    pur_obj=self.pool.get('purchase.order')  
+    pur_obj=self.pool.get('purchase.order')
     ids = []
     pur_id1=pur_obj.browse(cr, uid, ref("purchase_order_po1"))
     for line in pur_id1.order_line:
@@ -99,13 +98,13 @@
     from tools.translate import _
     pur_id1=self.browse(cr, uid, ref("purchase_order_po1"))
     account_obj = self.pool.get('account.invoice')
-    ids = account_obj.search(cr, uid, [('origin', '=', pur_id1.name)])
+    ids = account_obj.search(cr, uid, [('origin', '=', 'PO-'+str(pur_id1.id))])
     assert ids, _('Pending Invoice is not created!')
 -
   I check that the order which was initially in the confirmed state has transit to approved state.
 -
   !assert {model: purchase.order, id: purchase_order_po1}:
-    - state == 'approved' 
+    - state == 'approved'
 -
   I check that date_approve field of Delivery&Invoices gets bind with the date on which it has been approved.
 -
diff --git a/addons/purchase/test/purchase_from_picking.yml b/addons/purchase/test/purchase_from_picking.yml
index 5ef3058cdc2..e68668f408d 100644
--- a/addons/purchase/test/purchase_from_picking.yml
+++ b/addons/purchase/test/purchase_from_picking.yml
@@ -21,17 +21,16 @@
     warranty: 0.0
     weight: 0.0
     weight_net: 0.0
-- 
+-
   In order to test the purchase flow,I create a new record where "invoice_method" is From Picking
 -
   I create purchase order for iPod.
-- 
+-
   !record {model: purchase.order, id: purchase_order_po2}:
     company_id: base.main_company
     date_order: '2010-05-11'
     invoice_method: picking
     location_id: stock.stock_location_stock
-    name: PO00008
     order_line:
       - date_planned: '2010-05-13'
         name: iPod
@@ -47,16 +46,16 @@
   Initially purchase order is in the draft state.
 -
   !assert {model: purchase.order, id: purchase_order_po2}:
-    - state == 'draft'  
+    - state == 'draft'
 -
   I confirm the purchase order for iPod.
 -
   !workflow {model: purchase.order, action: purchase_confirm, ref: purchase_order_po2}
--  
+-
  I check that the order which was initially in the draft state has transit to confirm state.
 -
   !assert {model: purchase.order, id: purchase_order_po2}:
-    - state == 'approved'  
+    - state == 'approved'
 -
   I check that an entry gets created in the "Lines to Invoice" of Invoice Control on the basis of purchase order line.
 -
@@ -68,7 +67,7 @@
     assert search_ids, _('Purchase order line is not created!')
 -
   To check that wizard "Create Invoices" gets opened.
-- 
+-
   I create purchase order line invoice entry.
 -
   !record {model: purchase.order.line_invoice, id: purchase_order_line_invoice_0}:
@@ -77,7 +76,7 @@
   I create invoice for products in the purchase order.
 -
   !python {model: purchase.order.line_invoice}: |
-    pur_obj=self.pool.get('purchase.order')  
+    pur_obj=self.pool.get('purchase.order')
     ids = []
     pur_id1=pur_obj.browse(cr, uid, ref("purchase_order_po2"))
     for line in pur_id1.order_line:
@@ -99,21 +98,21 @@
     from tools.translate import _
     pur_id1=self.browse(cr, uid, ref("purchase_order_po2"))
     account_obj = self.pool.get('account.invoice')
-    ids = account_obj.search(cr, uid, [('origin', '=', pur_id1.name)])
+    ids = account_obj.search(cr, uid, [('origin', '=', 'PO-'+str(pur_id1.id))])
     assert ids, _('Pending Invoice is not created!')
 -
  I check that the order which was initially in the confirmed state has transit to approved state.
 -
   !assert {model: purchase.order, id: purchase_order_po2}:
-    - state == 'approved' 
+    - state == 'approved'
 -
- I check that date_approve field of Delivery&Invoices gets bind with the date on which it has been approved. 
+ I check that date_approve field of Delivery&Invoices gets bind with the date on which it has been approved.
 -
   !python {model: purchase.order}: |
     pur_id=self.browse(cr, uid, ref("purchase_order_po2"))
     assert(pur_id.date_approve)
 -
- I check that an entry gets created in the stock.picking. 
+ I check that an entry gets created in the stock.picking.
 -
   !python {model: purchase.order}: |
     pur_id=self.browse(cr, uid, ref("purchase_order_po2"))
@@ -130,8 +129,8 @@
     search_id = move_obj.search(cr, uid, [('picking_id', '=', pick_id.name)])
     assert search_id, 'No Incoming Product!'
 -
-  Then I create an invoice from picking by clicking on "Create Invoice" wizard 
-- 
+  Then I create an invoice from picking by clicking on "Create Invoice" wizard
+-
   !python {model: stock.invoice.onshipping}: |
     pur_obj=self.pool.get('purchase.order')
     pur_id1=pur_obj.browse(cr, uid, ref("purchase_order_po2"))