odoo
/
odoo
2
0
Fork 0
Code Pull Requests Releases Activity

[FIX] test_reports.py: use communicate() to avoid creating zombie processes 

bzr revid: chs@openerp.com-20121130152937-xcgs9bxrw7vyewex
This commit is contained in:
Christophe Simonis 2012-11-30 16:29:37 +01:00
parent 053d6af231
commit 415dc94a9d
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openerp/tools/test_reports.py
View File

@ -2,7 +2,7 @@
############################################################################## ##############################################################################
# #
# OpenERP, Open Source Management Solution # OpenERP, Open Source Management Solution
# Copyright (C) 2010 OpenERP s.a. (<http://openerp.com>). # Copyright (C) 2010-2012 OpenERP s.a. (<http://openerp.com>).
# #
# This program is free software: you can redistribute it and/or modify # This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU Affero General Public License as # it under the terms of the GNU Affero General Public License as
@ -73,8 +73,9 @@ def try_report(cr, uid, rname, ids, data=None, context=None, our_module=None):
os.write(fd, res_data) os.write(fd, res_data)
os.close(fd) os.close(fd)
fp = Popen(['pdftotext', '-enc', 'UTF-8', '-nopgbrk', rfname, '-'], shell=False, stdout=PIPE).stdout proc = Popen(['pdftotext', '-enc', 'UTF-8', '-nopgbrk', rfname, '-'], shell=False, stdout=PIPE)
res_text = tools.ustr(fp.read()) stdout, stderr = proc.communicate()
res_text = tools.ustr(stdout)
os.unlink(rfname) os.unlink(rfname)
except Exception: except Exception:
_logger.debug("Unable to parse PDF report: install pdftotext to perform automated tests.") _logger.debug("Unable to parse PDF report: install pdftotext to perform automated tests.")