From 4bd2ee1aaace8e7f6fa5621688e00dc2115fa8a7 Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Fri, 27 Feb 2015 15:07:15 +0100 Subject: [PATCH] [FIX] undefined variable Variable was added to an error message, then inlined in only one of the two callsites. Undefined variable error would only appear when an error is triggered in the actual (postgres-level) backup call. inserted in ec9a543 fixes #5241 --- openerp/tools/misc.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/openerp/tools/misc.py b/openerp/tools/misc.py index 231496e7b58..9fba582ad30 100644 --- a/openerp/tools/misc.py +++ b/openerp/tools/misc.py @@ -122,7 +122,8 @@ def exec_pg_command(name, *args): prog = find_pg_tool(name) env = exec_pg_environ() with open(os.devnull) as dn: - rc = subprocess.call((prog,) + args, env=env, stdout=dn, stderr=subprocess.STDOUT) + args2 = (prog,) + args + rc = subprocess.call(args2, env=env, stdout=dn, stderr=subprocess.STDOUT) if rc: raise Exception('Postgres subprocess %s error %s' % (args2, rc))