From 4e7c00fa4dfdb98d60df4004c66999af1d8f90b9 Mon Sep 17 00:00:00 2001
From: "JMA(OpenERP)" <>
Date: Thu, 10 Mar 2011 18:06:23 +0530
Subject: [PATCH] [FIX] Stock : Creation of invoice from picking should respect
 the journal and its view over opened invoice

lp bug: https://launchpad.net/bugs/724198 fixed

bzr revid: jvo@tinyerp.com-20110310123623-26cw8ewgr22fr0j2
---
 .../stock/wizard/stock_invoice_onshipping.py  | 44 ++++++++++---------
 1 file changed, 23 insertions(+), 21 deletions(-)

diff --git a/addons/stock/wizard/stock_invoice_onshipping.py b/addons/stock/wizard/stock_invoice_onshipping.py
index c7eab1eef4d..42add8019c4 100644
--- a/addons/stock/wizard/stock_invoice_onshipping.py
+++ b/addons/stock/wizard/stock_invoice_onshipping.py
@@ -34,41 +34,43 @@ class stock_invoice_onshipping(osv.osv_memory):
             return []
 
         model_pool = self.pool.get(model)
-        acct_obj = self.pool.get('account.journal')
+        journal_obj = self.pool.get('account.journal')
         res_ids = context and context.get('active_ids', [])
-        vals=[]
-        pick_types = list(set(map(lambda x: x.type, model_pool.browse(cr, uid, res_ids, context=context))))
-        for type in pick_types:
-            if type == 'out':
-               value = acct_obj.search(cr, uid, [('type', 'in',('sale','purchase_refund') )])
-               for jr_type in acct_obj.browse(cr, uid, value, context=context):
-                   t1 = jr_type.id,jr_type.name
-                   vals.append(t1)
-
-            elif type == 'in':
-               value = acct_obj.search(cr, uid, [('type', 'in',('purchase','sale_refund') )])
-               for jr_type in acct_obj.browse(cr, uid, value, context=context):
-                   t1 = jr_type.id,jr_type.name
-                   vals.append(t1)
+        vals = []
+        browse_picking = model_pool.browse(cr, uid, res_ids, context=context)
+        
+        for pick in browse_picking:
+            src_usage = pick.move_lines[0].location_id.usage
+            dest_usage = pick.move_lines[0].location_dest_id.usage
+            type = pick.type
+            if type == 'out' and dest_usage == 'supplier':
+                journal_type = 'purchase_refund'
+            elif type == 'out' and dest_usage == 'customer':
+                journal_type = 'sale'
+            elif type == 'in' and src_usage == 'supplier':
+                journal_type = 'purchase'
+            elif type == 'in' and src_usage == 'customer':
+                journal_type = 'sale_refund'
             else:
-               value = acct_obj.search(cr, uid, [('type', 'in',('cash','bank','general','situation') )])
-               for jr_type in acct_obj.browse(cr, uid, value, context=context):
-                   t1 = jr_type.id,jr_type.name
-                   vals.append(t1)
+                journal_type = 'sale'
+                
+            value = journal_obj.search(cr, uid, [('type', '=',journal_type )])
+            for jr_type in journal_obj.browse(cr, uid, value, context=context):
+                t1 = jr_type.id,jr_type.name
+                if t1 not in vals:
+                    vals.append(t1)
         return vals
 
 
     _name = "stock.invoice.onshipping"
     _description = "Stock Invoice Onshipping"
 
-
     _columns = {
         'journal_id': fields.selection(_get_journal_id, 'Destination Journal',required=True),
         'group': fields.boolean("Group by partner"),
         'invoice_date': fields.date('Invoiced date'),
     }
 
-
     def view_init(self, cr, uid, fields_list, context=None):
         if context is None:
             context = {}