odoo
/
odoo
2
0
Fork 0
Code Pull Requests Releases Activity

[FIX] mass_mailing: avoid mutable values for dict.fromkeys(), simplify with RIGHT JOIN

This commit is contained in:
Olivier Dony 2014-07-04 23:56:22 +02:00
parent d32fc5c597
commit 4fa30f5569
1 changed files with 26 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
addons/mass_mailing/mass_mailing.py
View File

@ -37,27 +37,24 @@ class MassMailingCampaign(osv.Model):
def _get_statistics(self, cr, uid, ids, name, arg, context=None): def _get_statistics(self, cr, uid, ids, name, arg, context=None):
""" Compute statistics of the mass mailing campaign """ """ Compute statistics of the mass mailing campaign """
results = dict.fromkeys(ids, { results = {}
'sent': 0,
'delivered': 0,
'opened': 0,
'replied': 0,
'bounced': 0,
})
cr.execute(""" cr.execute("""
SELECT SELECT
mass_mailing_campaign_id, c.id,
COUNT(id) AS sent, COUNT(s.id) AS sent,
COUNT(CASE WHEN bounced is null THEN 1 ELSE null END) AS delivered, COUNT(CASE WHEN s.id is not null AND s.bounced is null THEN 1 ELSE null END) AS delivered,
COUNT(CASE WHEN opened is not null THEN 1 ELSE null END) AS opened, COUNT(CASE WHEN s.opened is not null THEN 1 ELSE null END) AS opened,
COUNT(CASE WHEN replied is not null THEN 1 ELSE null END) AS replied , COUNT(CASE WHEN s.replied is not null THEN 1 ELSE null END) AS replied ,
COUNT(CASE WHEN bounced is not null THEN 1 ELSE null END) AS bounced COUNT(CASE WHEN s.bounced is not null THEN 1 ELSE null END) AS bounced
FROM FROM
mail_mail_statistics mail_mail_statistics s
RIGHT JOIN
mail_mass_mailing_campaign c
ON (c.id = s.mass_mailing_campaign_id)
WHERE WHERE
mass_mailing_campaign_id IN %s c.id IN %s
GROUP BY GROUP BY
mass_mailing_campaign_id c.id
""", (tuple(ids), )) """, (tuple(ids), ))
for (campaign_id, sent, delivered, opened, replied, bounced) in cr.fetchall(): for (campaign_id, sent, delivered, opened, replied, bounced) in cr.fetchall():
results[campaign_id] = { results[campaign_id] = {
@ -217,27 +214,24 @@ class MassMailing(osv.Model):
def _get_statistics(self, cr, uid, ids, name, arg, context=None): def _get_statistics(self, cr, uid, ids, name, arg, context=None):
""" Compute statistics of the mass mailing """ """ Compute statistics of the mass mailing """
results = dict.fromkeys(ids, { results = {}
'sent': 0,
'delivered': 0,
'opened': 0,
'replied': 0,
'bounced': 0,
})
cr.execute(""" cr.execute("""
SELECT SELECT
mass_mailing_id, m.id,
COUNT(id) AS sent, COUNT(s.id) AS sent,
COUNT(CASE WHEN bounced is null THEN 1 ELSE null END) AS delivered, COUNT(CASE WHEN s.id is not null AND s.bounced is null THEN 1 ELSE null END) AS delivered,
COUNT(CASE WHEN opened is not null THEN 1 ELSE null END) AS opened, COUNT(CASE WHEN s.opened is not null THEN 1 ELSE null END) AS opened,
COUNT(CASE WHEN replied is not null THEN 1 ELSE null END) AS replied , COUNT(CASE WHEN s.replied is not null THEN 1 ELSE null END) AS replied ,
COUNT(CASE WHEN bounced is not null THEN 1 ELSE null END) AS bounced COUNT(CASE WHEN s.bounced is not null THEN 1 ELSE null END) AS bounced
FROM FROM
mail_mail_statistics mail_mail_statistics s
RIGHT JOIN
mail_mass_mailing m
ON (m.id = s.mass_mailing_id)
WHERE WHERE
mass_mailing_id IN %s m.id IN %s
GROUP BY GROUP BY
mass_mailing_id m.id
""", (tuple(ids), )) """, (tuple(ids), ))
for (mass_mailing_id, sent, delivered, opened, replied, bounced) in cr.fetchall(): for (mass_mailing_id, sent, delivered, opened, replied, bounced) in cr.fetchall():
results[mass_mailing_id] = { results[mass_mailing_id] = {