From 552dab0dc858b2d36e6d7a90bbd46dfdb7d9a821 Mon Sep 17 00:00:00 2001 From: Raphael Collet Date: Thu, 13 Nov 2014 10:06:30 +0100 Subject: [PATCH] [FIX] models: simplify conditions that seem to lead to missing fields --- openerp/models.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/openerp/models.py b/openerp/models.py index e871dfff2cc..02be95568f5 100644 --- a/openerp/models.py +++ b/openerp/models.py @@ -516,7 +516,7 @@ class BaseModel(object): """ def add(name, field): """ add `field` with the given `name` if it does not exist yet """ - if name not in cls._columns and name not in cls._fields: + if name not in cls._fields: cls._add_field(name, field) # cyclic import @@ -811,8 +811,7 @@ class BaseModel(object): cls._fields = {} above = cls.__bases__[0] for attr, field in getmembers(above, Field.__instancecheck__): - if not field.inherited: - cls._add_field(attr, field.new()) + cls._add_field(attr, field.new()) # introduce magic fields cls._add_magic_fields()