From 55ac10cd3d523e36026d2534eb6cca82b7cff1f8 Mon Sep 17 00:00:00 2001 From: niv-openerp Date: Tue, 22 Oct 2013 15:34:32 +0200 Subject: [PATCH] [FIX] Bug in form view. When a on_change alters the domain of a field, the view_content_has_changed event is triggered *before* we alter the domain of the field. So, it is not possible for the fields to really know when they have to re-calculate their domain. bzr revid: nicolas.vanhoren@openerp.com-20131022133432-l0m36mfiwx8z6014 --- addons/web/static/src/js/view_form.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/addons/web/static/src/js/view_form.js b/addons/web/static/src/js/view_form.js index b68891db77f..1fa7cb6a4f8 100644 --- a/addons/web/static/src/js/view_form.js +++ b/addons/web/static/src/js/view_form.js @@ -566,6 +566,13 @@ instance.web.FormView = instance.web.View.extend(instance.web.form.FieldManagerM }, on_processed_onchange: function(result, processed) { try { + var fields = this.fields; + _(result.domain).each(function (domain, fieldname) { + var field = fields[fieldname]; + if (!field) { return; } + field.node.attrs.domain = domain; + }); + if (result.value) { this._internal_set_values(result.value, processed); } @@ -579,13 +586,6 @@ instance.web.FormView = instance.web.View.extend(instance.web.form.FieldManagerM }); } - var fields = this.fields; - _(result.domain).each(function (domain, fieldname) { - var field = fields[fieldname]; - if (!field) { return; } - field.node.attrs.domain = domain; - }); - return $.Deferred().resolve(); } catch(e) { console.error(e);