From 5e2d8687903bbd7d029f2adadad4a7b0fa13bdaa Mon Sep 17 00:00:00 2001
From: "Harry (OpenERP)" <hmo@tinyerp.com>
Date: Thu, 6 Sep 2012 18:43:10 +0530
Subject: [PATCH] [FIX] sale: in a sale order, if a line is created with only a
 description, no product, the system must propose direclty to create the final
 invoice whatever the invoicing policy

bzr revid: hmo@tinyerp.com-20120906131310-pzx34w7fcu8j28zy
---
 addons/sale/sale.py           | 7 +++++++
 addons/sale/sale_view.xml     | 2 +-
 addons/sale/sale_workflow.xml | 4 ++--
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/addons/sale/sale.py b/addons/sale/sale.py
index 6a6678d6163..9b8057c2289 100644
--- a/addons/sale/sale.py
+++ b/addons/sale/sale.py
@@ -582,6 +582,13 @@ class sale_order(osv.osv):
         result.update(view_id = res and res[1] or False)
         return result
 
+    def test_no_product(self, cr, uid, ids, *args):
+        for order in self.browse(cr, uid, ids):
+            for line in order.order_line:
+                if line.product_id:
+                    return False
+        return True
+
     def action_invoice_create(self, cr, uid, ids, grouped=False, states=['confirmed', 'done', 'exception'], date_inv = False, context=None):
         res = False
         invoices = {}
diff --git a/addons/sale/sale_view.xml b/addons/sale/sale_view.xml
index 2c2acff227e..1bc110312db 100644
--- a/addons/sale/sale_view.xml
+++ b/addons/sale/sale_view.xml
@@ -163,7 +163,7 @@
                             <button name="action_button_confirm" states="draft" string="Confirm" type="object"/>
                             <button name="action_button_confirm" states="sent" string="Confirm" class="oe_highlight" type="object"/>
                             <button name="action_view_invoice" string="View Invoice" type="object" class="oe_highlight"
-                              attrs="{'invisible': ['|','|',('state', '!=','progress'), ('invoiced', '=', True),('order_policy','=','picking')]}"/>
+                              attrs="{'invisible': ['|','|',('state', '!=','progress'), ('invoiced', '=', True),('order_policy','=','picking')]}"/> <!-- ('invoice_ids','=',[]) should be work-->
                             <button name="action_view_delivery" string="View Delivery Order" type="object" class="oe_highlight"
                               attrs="{'invisible': ['|','|','|',('picking_ids','=',False),('picking_ids','=',[]), ('state', 'not in', ('progress','manual')),('shipped','=',True)]}"/>
                             <button name="%(action_view_sale_advance_payment_inv)d" string="Create Invoice"
diff --git a/addons/sale/sale_workflow.xml b/addons/sale/sale_workflow.xml
index c18e271d480..48e299c8314 100644
--- a/addons/sale/sale_workflow.xml
+++ b/addons/sale/sale_workflow.xml
@@ -162,7 +162,7 @@
         <record id="trans_router_wait_invoice_shipping" model="workflow.transition">
             <field name="act_from" ref="act_wait_invoice"/>
             <field name="act_to" ref="act_invoice_end"/>
-            <field name="condition">(order_policy=='picking')</field>
+            <field name="condition">(order_policy=='picking') and (not test_no_product())</field>
         </record>
 
         <record id="trans_router_wait_invoice" model="workflow.transition">
@@ -196,7 +196,7 @@
         <record id="trans_wait_invoice_invoice" model="workflow.transition">
             <field name="act_from" ref="act_wait_invoice"/>
             <field name="act_to" ref="act_invoice"/>
-            <field name="condition">(order_policy=='prepaid')</field>
+            <field name="condition">(order_policy=='prepaid') or test_no_product()</field>
         </record>
 
         <record id="trans_wait_invoice_invoice_manual" model="workflow.transition">