[MERGE] sets are better than lists when mostly checking for containment

bzr revid: xmo@openerp.com-20120123150257-5qklt4mia8y7tp5k
This commit is contained in:
Xavier Morel 2012-01-23 16:02:57 +01:00
commit 726f1cc669
1 changed files with 2 additions and 2 deletions

View File

@ -355,7 +355,7 @@ def session_context(request, storage_path, session_cookie='sessionid'):
# Remove all OpenERPSession instances with no uid, they're generated
# either by login process or by HTTP requests without an OpenERP
# session id, and are generally noise
removed_sessions = []
removed_sessions = set()
for key, value in request.session.items():
if (isinstance(value, session.OpenERPSession)
and not value._uid
@ -363,7 +363,7 @@ def session_context(request, storage_path, session_cookie='sessionid'):
and value._creation_time + (60*5) < time.time() # FIXME do not use a fixed value
):
_logger.debug('remove session %s', key)
removed_sessions.append(key)
removed_sessions.add(key)
del request.session[key]
with session_lock: