odoo
/
odoo
2
0
Fork 0
Code Pull Requests Releases Activity

[IMP] point_of_sale: refactored the ean checksum method 

bzr revid: fva@openerp.com-20120720152421-lfq05r6xkczl1y56
This commit is contained in:
Frédéric van der Essen 2012-07-20 17:24:21 +02:00
parent 28733c9f5c
commit 7a1cee1401
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
addons/product/product.py
View File

@ -30,15 +30,10 @@ from tools.translate import _
def is_pair(x): def is_pair(x):
return not x%2 return not x%2
def check_ean(eancode): def ean_checksum(eancode):
if not eancode: """returns the checksum of an ean string of length 13, returns -1 if the string has the wrong length"""
return True
if len(eancode) <> 13: if len(eancode) <> 13:
return False return -1
try:
int(eancode)
except:
return False
oddsum=0 oddsum=0
evensum=0 evensum=0
total=0 total=0
@ -54,10 +49,20 @@ def check_ean(eancode):
total=(oddsum * 3) + evensum total=(oddsum * 3) + evensum
check = int(10 - math.ceil(total % 10.0)) %10 check = int(10 - math.ceil(total % 10.0)) %10
return check
if check != int(eancode[-1]): def check_ean(eancode):
"""returns True if eancode is a valid ean13 string, or null"""
if not eancode:
return True
if len(eancode) <> 13:
return False return False
return True try:
int(eancode)
except:
return False
return ean_checksum(eancode) == int(eancode[-1])
#---------------------------------------------------------- #----------------------------------------------------------
# UOM # UOM
#---------------------------------------------------------- #----------------------------------------------------------