From 8f67c5c367a2653918f5e0473c3d0f8e031f3aaf Mon Sep 17 00:00:00 2001
From: Xavier Morel <xmo@openerp.com>
Date: Mon, 21 Nov 2011 13:41:45 +0100
Subject: [PATCH] [ADD] support for string literals in form @on_change

lp bug: https://launchpad.net/bugs/889741 fixed

bzr revid: xmo@openerp.com-20111121124145-6i2kvesyc689g3ez
---
 addons/web/static/src/js/view_form.js | 36 ++++++++++++++++++---------
 addons/web/static/test/onchange.js    |  7 ++++++
 2 files changed, 31 insertions(+), 12 deletions(-)

diff --git a/addons/web/static/src/js/view_form.js b/addons/web/static/src/js/view_form.js
index 1f35c0e1dc3..bd9cf27e0ed 100644
--- a/addons/web/static/src/js/view_form.js
+++ b/addons/web/static/src/js/view_form.js
@@ -268,26 +268,38 @@ openerp.web.FormView = openerp.web.View.extend( /** @lends openerp.web.FormView#
         var parent_fields = null;
         _.each(call[2].split(','), function (a, i) {
             var field = _.str.trim(a);
+
+            // literal constant or context
             if (field in argument_replacement) {
                 args.push(argument_replacement[field](i));
                 return;
-            } else if (self.fields[field]) {
+            }
+            // form field
+            if (self.fields[field]) {
                 var value = self.fields[field].get_on_change_value();
                 args.push(value == null ? false : value);
                 return;
-            } else {
-                var splitted = field.split('.');
-                if (splitted.length > 1 && _.str.trim(splitted[0]) === "parent" && self.dataset.parent_view) {
-                    if (parent_fields === null) {
-                        parent_fields = self.dataset.parent_view.get_fields_values();
-                    }
-                    var p_val = parent_fields[_.str.trim(splitted[1])];
-                    if (p_val !== undefined) {
-                        args.push(p_val == null ? false : p_val);
-                        return;
-                    }
+            }
+            // parent field
+            var splitted = field.split('.');
+            if (splitted.length > 1 && _.str.trim(splitted[0]) === "parent" && self.dataset.parent_view) {
+                if (parent_fields === null) {
+                    parent_fields = self.dataset.parent_view.get_fields_values();
+                }
+                var p_val = parent_fields[_.str.trim(splitted[1])];
+                if (p_val !== undefined) {
+                    args.push(p_val == null ? false : p_val);
+                    return;
                 }
             }
+            // string literal
+            var first_char = field[0], last_char = field[field.length-1];
+            if ((first_char === '"' && last_char === '"')
+                || (first_char === "'" && last_char === "'")) {
+                args.push(field.slice(1, -1));
+                return;
+            }
+
             throw new Error("Could not get field with name '" + field +
                             "' for onchange '" + onchange + "'");
         });
diff --git a/addons/web/static/test/onchange.js b/addons/web/static/test/onchange.js
index c606915f31a..9f047f33d93 100644
--- a/addons/web/static/test/onchange.js
+++ b/addons/web/static/test/onchange.js
@@ -55,4 +55,11 @@ $(document).ready(function () {
         var result = f.parse_on_change('on_null(False)', {});
         deepEqual(result.args, [false]);
     });
+    test('Literal string', function () {
+        var f = make_form();
+        var result = f.parse_on_change('on_str("foo")', {});
+        deepEqual(result.args, ['foo']);
+        var result2 = f.parse_on_change("on_str('foo')", {});
+        deepEqual(result2.args, ['foo']);
+    });
 });