From 9b936e7e29a6b48fa7a5c4fa703dee78b8df771d Mon Sep 17 00:00:00 2001
From: "Anand Patel (OpenERP)" <pan@tinyerp.com>
Date: Mon, 9 Jul 2012 16:12:18 +0530
Subject: [PATCH] [IMP] improve code for bounce effect on non editable form
 view.

bzr revid: pan@tinyerp.com-20120709104218-tot71riz8bww6itp
---
 addons/web/static/src/js/view_form.js | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/addons/web/static/src/js/view_form.js b/addons/web/static/src/js/view_form.js
index a65e471c6bf..2a5c0679bd2 100644
--- a/addons/web/static/src/js/view_form.js
+++ b/addons/web/static/src/js/view_form.js
@@ -92,7 +92,7 @@ instance.web.FormView = instance.web.View.extend(instance.web.form.FieldManagerM
         this._super();
     },
     on_loaded: function(data) {
-        var self = this;        
+        var self = this; 
         if (!data) {
             throw new Error("No data provided.");
         }
@@ -287,16 +287,18 @@ instance.web.FormView = instance.web.View.extend(instance.web.form.FieldManagerM
     on_invalidclick : function (){
         var self = this;
         var div = $("<div />", {id:"bounce"});
-        this.$element.find(".oe_form_field").click(function () {
+        this.$element.find(".oe_form_field, .oe_form_group_cell").click(function (e) {
         $(".oe_form_button_edit").wrap(div);
         $("#bounce").addClass('oe_bounce_button_left');
-        var val_bounce = $(".oe_form_button_edit");
+        var val_bounce = $(".oe_form_button_edit");        
         self.do_bounce(val_bounce);
-        });
+        e.stopImmediatePropagation();               
+        });        
+       
     },
     on_record_loaded: function(record) {
-        var self = this, set_values = [];
-        self.on_invalidclick();        
+        var self = this, set_values = [];  
+        self.on_invalidclick();    
         if (!record) {
             this.do_warn("Form", "The record could not be found in the database.", true);
             return $.Deferred().reject();
@@ -338,6 +340,7 @@ instance.web.FormView = instance.web.View.extend(instance.web.form.FieldManagerM
             }
             self.$element.add(self.$buttons).removeClass('oe_form_dirty');
         });
+          
     },
     on_form_changed: function() {
         this.trigger("view_content_has_changed");
@@ -596,9 +599,10 @@ instance.web.FormView = instance.web.View.extend(instance.web.form.FieldManagerM
     on_button_save: function() {
         var self = this;
         return this.do_save().then(function(result) {
-            self.set({mode: "view"});
-            self.on_invalidclick();
+            self.set({mode: "view"});            
+            self.on_invalidclick();          
         });
+        
     },    
     on_button_cancel: function(event) {
         if (this.can_be_discarded()) {
@@ -2982,7 +2986,7 @@ instance.web.form.FieldOne2Many = instance.web.form.AbstractField.extend({
         return def;
     },
     reload_current_view: function() {
-        var self = this;
+        var self = this;        
         return self.is_loaded = self.is_loaded.pipe(function() {
             var active_view = self.viewmanager.active_view;
             var view = self.viewmanager.views[active_view].controller;