odoo
/
odoo
2
0
Fork 0
Code Pull Requests Releases Activity

[FIX] models: fields_get() shall not return info about fields not set up yet 

When processing data files during a module installation/upgrade, not all fields
are set up yet, in particular relational custom fields.  Make fields_get()
ignore those fields, so that views can be created/updated and validated,
provided they do not refer to those fields...
This commit is contained in:
Raphael Collet 2014-10-06 11:56:03 +02:00
parent f563be5cc0
commit afb91fde81
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
openerp/fields.py
View File

@ -251,6 +251,7 @@ class Field(object):
automatic = False # whether the field is automatically created ("magic" field)
inherited = False # whether the field is inherited (_inherits)
column = None # the column interfaced by the field
setup_done = False # whether the field has been set up
name = None # name of the field
type = None # type of the field (string)
@ -346,7 +347,7 @@ class Field(object):
def reset(self):
""" Prepare `self` for a new setup. """
self._setup_done = False
self.setup_done = False
# self._triggers is a set of pairs (field, path) that represents the
# computed fields that depend on `self`. When `self` is modified, it
# invalidates the cache of each `field`, and registers the records to
@ -359,8 +360,8 @@ class Field(object):
and other properties). This method is idempotent: it has no effect
if `self` has already been set up.
"""
if not self._setup_done:
self._setup_done = True
if not self.setup_done:
self.setup_done = True
self._setup(env)
def _setup(self, env):

2
openerp/models.py
View File

@ -3042,6 +3042,8 @@ class BaseModel(object):
for fname, field in self._fields.iteritems():
if allfields and fname not in allfields:
continue
if not field.setup_done:
continue
if field.groups and not recs.user_has_groups(field.groups):
continue
res[fname] = field.get_description(recs.env)