From bffc2487968be0e77241d5d40d353901e4ce3aed Mon Sep 17 00:00:00 2001 From: "P. Christeas" Date: Sat, 27 Nov 2010 22:14:29 +0200 Subject: [PATCH] account.move.line: Fix ugly SQL call A matter of coding style, tripple quotes in the same line, put in a list is just a candidate for the hall of shame. bzr revid: p_christ@hol.gr-20101127201429-07u0bc8xra998zhi --- addons/account/account_move_line.py | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/addons/account/account_move_line.py b/addons/account/account_move_line.py index 307ab1f58da..2987b3c69d6 100644 --- a/addons/account/account_move_line.py +++ b/addons/account/account_move_line.py @@ -300,19 +300,15 @@ class account_move_line(osv.osv): context = {} c = context.copy() c['initital_bal'] = True - sql = [ - """SELECT l2.id, SUM(l1.debit-l1.credit) FROM account_move_line l1, account_move_line l2""", - """WHERE l2.account_id = l1.account_id""", - """AND""", - """l1.id <= l2.id""", - """AND""", - """l2.id IN %s""", - """AND""", - self._query_get(cr, uid, obj='l1', context=c), - """ GROUP BY l2.id""", - ] + sql = """SELECT l2.id, SUM(l1.debit-l1.credit) + FROM account_move_line l1, account_move_line l2 + WHERE l2.account_id = l1.account_id + AND l1.id <= l2.id + AND l2.id IN %%s AND """ + \ + self._query_get(cr, uid, obj='l1', context=c) + \ + " GROUP BY l2.id" - cr.execute('\n'.join(sql), [tuple(ids)]) + cr.execute(sql, [tuple(ids)]) res = dict(cr.fetchall()) return res