From e00c236693be8a7e2fbe12c59040c2b12b4048e2 Mon Sep 17 00:00:00 2001 From: Denis Ledoux Date: Wed, 8 Jan 2014 11:53:07 +0100 Subject: [PATCH] [FIX] web: redirect with hash always use html redirect # Most IE and Safari versions decided not to preserve location.hash upon # redirect. And even if IE10 pretends to support it, it still fails # inexplicably in case of multiple redirects (and we do have some). # See extensive test page at http://greenbytes.de/tech/tc/httpredirects/ bzr revid: dle@openerp.com-20140108105307-8dzzkxvtesb5d813 --- addons/web/controllers/main.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/addons/web/controllers/main.py b/addons/web/controllers/main.py index 14785e91896..1730ff576f0 100644 --- a/addons/web/controllers/main.py +++ b/addons/web/controllers/main.py @@ -129,14 +129,11 @@ def db_monodb(req): return db_redirect(req, True)[0] def redirect_with_hash(req, url, code=303): - if req.httprequest.user_agent.browser == 'msie': - try: - version = float(req.httprequest.user_agent.version) - if version < 10: - return "" % url - except Exception: - pass - return werkzeug.utils.redirect(url, code) + # Most IE and Safari versions decided not to preserve location.hash upon + # redirect. And even if IE10 pretends to support it, it still fails + # inexplicably in case of multiple redirects (and we do have some). + # See extensive test page at http://greenbytes.de/tech/tc/httpredirects/ + return "" % url def module_topological_sort(modules): """ Return a list of module names sorted so that their dependencies of the