From e8d373aa6c6bc5a61c6b74f62a72b3894d753f50 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= <tde@openerp.com>
Date: Fri, 10 Feb 2012 14:46:06 +0100
Subject: [PATCH] [FIX] Fixed filter icon for cash registers; removed a space
 for view_mode definition when returning an act_window; small code
 optimizations

bzr revid: tde@openerp.com-20120210134606-8aa4hnn8vuhwdzrz
---
 addons/account/account_view.xml                               | 2 +-
 .../account_bank_statement.py                                 | 2 +-
 addons/point_of_sale/wizard/pos_open_statement.py             | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/account/account_view.xml b/addons/account/account_view.xml
index f7b73f13040..87907129a3d 100644
--- a/addons/account/account_view.xml
+++ b/addons/account/account_view.xml
@@ -525,7 +525,7 @@
                 <search string="Search Bank Statements">
                     <group>
                         <filter string="Draft" name="state_draft" domain="[('state','=','draft')]" icon="terp-document-new"/>
-                        <filter string="Open" name="state_open" domain="[('state','=','open')]" icon="terp-document-new"/>
+                        <filter string="Open" name="state_open" domain="[('state','=','open')]" icon="terp-check"/>
                         <filter string="Confirmed" name="state_confirmed" domain="[('state','=','confirm')]" icon="terp-camera_test"/>
                         <separator orientation="vertical"/>
                         <field name="date"/>
diff --git a/addons/account_bank_statement_extensions/account_bank_statement.py b/addons/account_bank_statement_extensions/account_bank_statement.py
index 507590b3640..1aa1cd808c1 100644
--- a/addons/account_bank_statement_extensions/account_bank_statement.py
+++ b/addons/account_bank_statement_extensions/account_bank_statement.py
@@ -50,7 +50,7 @@ class account_bank_statement(osv.osv):
     def button_cancel(self, cr, uid, ids, context=None):
         super(account_bank_statement, self).button_cancel(cr, uid, ids, context=context)
         for st in self.browse(cr, uid, ids, context=context):
-            if len(st.line_ids) > 0:
+            if st.line_ids:
                 cr.execute("UPDATE account_bank_statement_line  \
                     SET state='draft' WHERE id in %s ",
                     (tuple([x.id for x in st.line_ids]),))
diff --git a/addons/point_of_sale/wizard/pos_open_statement.py b/addons/point_of_sale/wizard/pos_open_statement.py
index 18bfb14e41d..a6e45a93013 100644
--- a/addons/point_of_sale/wizard/pos_open_statement.py
+++ b/addons/point_of_sale/wizard/pos_open_statement.py
@@ -79,9 +79,9 @@ class pos_open_statement(osv.osv_memory):
             'type': 'ir.actions.act_window',
             'name': _('List of Cash Registers'),
             'view_type': 'form',
-            'view_mode': 'tree, form',
+            'view_mode': 'tree,form',
             'res_model': 'account.bank.statement',
-            'domain': "[('id', 'in', " + str(st_ids) + ")]",
+            'domain': str([('id', 'in', str(st_ids))]),
             'views': [(tree_id, 'tree'), (form_id, 'form')],
             'search_view_id': search_id,
         }