From f2beb97168c474b11b80eff24cab7ff4a450a2ab Mon Sep 17 00:00:00 2001
From: Christophe Matthieu <chm@openerp.com>
Date: Wed, 10 Apr 2013 18:09:17 +0200
Subject: [PATCH] [IMP] view_form: radio button, replace image by input type
 radio

bzr revid: chm@openerp.com-20130410160917-4meevyiff65adspx
---
 addons/web/static/src/css/base.css            |  17 +---------
 addons/web/static/src/css/base.sass           |  14 +--------
 .../static/src/img/icons/input_radio-off.png  | Bin 512 -> 0 bytes
 .../static/src/img/icons/input_radio-on.png   | Bin 559 -> 0 bytes
 addons/web/static/src/js/view_form.js         |  29 ++++++++++--------
 addons/web/static/src/xml/base.xml            |  10 +++---
 6 files changed, 23 insertions(+), 47 deletions(-)
 delete mode 100644 addons/web/static/src/img/icons/input_radio-off.png
 delete mode 100644 addons/web/static/src/img/icons/input_radio-on.png

diff --git a/addons/web/static/src/css/base.css b/addons/web/static/src/css/base.css
index 559b0e40e35..e2115440717 100644
--- a/addons/web/static/src/css/base.css
+++ b/addons/web/static/src/css/base.css
@@ -2312,25 +2312,10 @@
 .openerp .oe_form_field_radio.oe_horizontal {
   white-space: nowrap;
 }
-.openerp .oe_form_field_radio.oe_horizontal .oe_radio_header {
+.openerp .oe_form_field_radio.oe_horizontal label {
   display: inline-block;
   text-align: center;
 }
-.openerp .oe_form_field_radio.oe_vertical .oe_radio_header {
-  cursor: pointer;
-}
-.openerp .oe_form_field_radio .oe_radio_input {
-  cursor: pointer;
-  display: inline-block;
-  width: 20px;
-  background: transparent url(/web/static/src/img/icons/input_radio-off.png) no-repeat center center;
-}
-.openerp .oe_form_field_radio .oe_radio_input_on {
-  background: transparent url(/web/static/src/img/icons/input_radio-on.png) no-repeat center center;
-}
-.openerp .oe_form_field_radio .oe_radio_label {
-  cursor: default;
-}
 .openerp .oe_form_field_progressbar.ui-progressbar {
   height: 22px;
   font-size: 10px;
diff --git a/addons/web/static/src/css/base.sass b/addons/web/static/src/css/base.sass
index d687ce21869..c92e7fd3c55 100644
--- a/addons/web/static/src/css/base.sass
+++ b/addons/web/static/src/css/base.sass
@@ -483,21 +483,9 @@ $sheet-padding: 16px
     .oe_form_field_radio
         &.oe_horizontal
             white-space: nowrap
-            .oe_radio_header
+            label
                 display: inline-block
                 text-align: center
-        &.oe_vertical
-            .oe_radio_header
-                cursor: pointer
-        .oe_radio_input {
-            cursor: pointer
-            display: inline-block
-            width: 20px
-            background: transparent url(/web/static/src/img/icons/input_radio-off.png) no-repeat center center
-        .oe_radio_input_on
-            background: transparent url(/web/static/src/img/icons/input_radio-on.png) no-repeat center center
-        .oe_radio_label
-            cursor: default
     .oe_tags
         &.oe_inline
             min-width: 250px
diff --git a/addons/web/static/src/img/icons/input_radio-off.png b/addons/web/static/src/img/icons/input_radio-off.png
deleted file mode 100644
index 790f7ed13b250830ca15af29fcb18e9713349bc9..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 512
zcmV+b0{{JqP)<h;3K|Lk000e1NJLTq000jF000mO0ssI2Ml`Zh00001b5ch_0Itp)
z=>Px#1ZP1_K>z@;j|==^1poj532;bRa{vGi!vFvd!vV){sAK>D0hLKaK~yMHm6F*`
z!cY)~Eu_%p6ap=KOaQ|w@+#mZKA>C*FX4?BhCRq?LIQ;Zf+?F)>R(D|OpL*~Xs7+Z
z^Pf30htf3d>f*3mOzI$Y_EuH3R<CzDo$+`KArJ_}VzIkS#%i^m9Z$5PD5Y}Q>-9z>
z5ueWoS(fGgU@)Cd^SK-$#8{xyaD6NmBjIp5ecSF17RwI^qRSb(2{#*!!EpFcC>T5F
zb)x|I#S_Wrm)FhiQxru>l2r9jskM@+6eIwKw@$yc+c(i@xBt%b#349rG)*|x=aoF7
z8}&c}VA2y=M#YQe(&-QwJ1y{xlduBMdL;LLuR;P~(ne;dX^yo6auAN^Ir}k?;8YgN
zsnPlit7o&BB)Sg!FP5<(=woQwK_Fy4pW_&&cOo9|_50VM;C8#&?sgPKLEEDURpmGi
z5&)CVX0wyYq}6KTKtL5`wOX&y6NX_bl?o&PX1|ePI!~pN-|t7)F-80Vgz4aUpU?l8
zj<F8=R;$%+uQwWv@EHmQF?qQDGWqjO_&fRE9sCA&y}shq^Bu(i0000<MNUMnLSTZe
C3*nFe

diff --git a/addons/web/static/src/img/icons/input_radio-on.png b/addons/web/static/src/img/icons/input_radio-on.png
deleted file mode 100644
index d55c291e79525006be05cbef0ff7135fa8c946d7..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 559
zcmV+~0?_@5P)<h;3K|Lk000e1NJLTq000jF000mO0ssI2Ml`Zh00001b5ch_0Itp)
z=>Px#1ZP1_K>z@;j|==^1poj532;bRa{vGi!vFvd!vV){sAK>D0mMl}K~yMHWBmXB
zKLgQ#iD;D|g^X~s|Ni}Z`O1~sw{Jgx{v0SFDJiL{s;aA_!_3SKHxa7(%a<=3Hf|IX
z6H`)D6c-l<O22&h^4|UXuU@?h@b~B8;eluXsRo+5Z259U1qCfF?X#DzpT2SnC}FOr
zW~i%q?dsM04<1BCMnY@=slIUWBG3#21H%Ptx6j+KPf<qV-Me?M-haxA@`(-dICt(G
z&`tw=eV}TPFK^wvsjQ@Q;mXa~Yj<a5r`30~8W-k$VPKiCbo0Fj4}nrZ1rV2jRKIxn
z5~%yg`71o^O#hYTr#*hK|G{5ouk2r6J|4Sp6DS2#fKUx#u`;u~c=2M=u7`)ufBEo@
z;rlO8JaDkH0e!{91Py2q1=Rie^=ms*T{a$pw;QIvfA;P3t8f2yPG{#4aI!Q4`awiQ
z1Yx$in%doa_jJ@%s#8Mv{{Q0K)XcZ3S%~phe`UI)m<Uh`r~pd{>gwt}eERI_?MKWk
z%*NVk;v#|<E?htlL7+Zh?5y9gK|(?T80x@S1bO|%3t;R3$-saBl-PmT0`$$LOPB84
xz5C?J6ChVwN(vbBdU|?TVji9n@H0qDg8&_1;*QsZXG#D7002ovPDHLkV1kq30;B){

diff --git a/addons/web/static/src/js/view_form.js b/addons/web/static/src/js/view_form.js
index 600f5657503..e1c5208358c 100644
--- a/addons/web/static/src/js/view_form.js
+++ b/addons/web/static/src/js/view_form.js
@@ -2806,6 +2806,9 @@ instance.web.form.FieldSelection = instance.web.form.AbstractField.extend(instan
 
 instance.web.form.FieldRadio = instance.web.form.AbstractField.extend(instance.web.form.ReinitializeFieldMixin, {
     template: 'FieldRadio',
+    events: {
+        'click input': 'click_change_value'
+    },
     init: function(field_manager, node) {
         /* Radio button widget: Attributes options:
         * - "horizontal" to display in column
@@ -2820,20 +2823,18 @@ instance.web.form.FieldRadio = instance.web.form.AbstractField.extend(instance.w
         this.domain = false;
     },
     initialize_content: function () {
-        this.$el.on('click', '.oe_radio_input,.oe_radio_header', this, this.on_click_change_value);
+        this.uniqueId = _.uniqueId("radio");
         this.on("change:effective_readonly", this, this.render_value);
         this.field_manager.on("view_content_has_changed", this, this.get_selection);
         this.get_selection();
     },
-    on_click_change_value: function (event) {
-        var id = $(event.target).data("id") || $(event.target).parent().data("id");
-        id = isNaN(+id) ? id : +id;
-        if (id && !this.get("effective_readonly")) {
-            if (!this.field.required && id == this.get_value()) {
-                this.set_value(false);
-            } else {
-                this.set_value(id);
-            }
+    click_change_value: function (event) {
+        var val = $(event.target).val();
+        val = isNaN(+val) ? val : +val;
+        if (val == this.get_value()) {
+            this.set_value(false);
+        } else {
+            this.set_value(val);
         }
     },
     /** Get the selection and render it
@@ -2887,9 +2888,11 @@ instance.web.form.FieldRadio = instance.web.form.AbstractField.extend(instance.w
     render_value: function () {
         this.$(".oe_radio_edit_only, .oe_radio_read_only").hide();
         this.$(this.get('effective_readonly') ? ".oe_radio_read_only" : ".oe_radio_edit_only").show();
-        this.$(".oe_radio_input_on").removeClass("oe_radio_input_on");
-        this.$(".oe_radio_input[data-id='" + this.get_value() + "'], [data-id='" + this.get_value() + "'] .oe_radio_input").addClass("oe_radio_input_on");
-        this.$(".oe_radio_read_only .oe_radio_header").text(this.get('value') ? this.get('value')[1] : "");
+        this.$("input[checked]").prop("checked", false);
+        if (this.get_value()) {
+            this.$("input[value='" + this.get_value() + "']").attr("checked", true);
+            this.$(".oe_radio_read_only .oe_radio_header").text(this.get('value') ? this.get('value')[1] : "");
+        }
     }
 });
 
diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml
index e89865e42e1..df289bbb2ea 100644
--- a/addons/web/static/src/xml/base.xml
+++ b/addons/web/static/src/xml/base.xml
@@ -1118,23 +1118,23 @@
                 <t t-set="width" t-value="Math.floor(100 / widget.selection.length)"/>
                 <t t-if="!widget.no_radiolabel">
                     <t t-foreach="widget.selection" t-as="selection">
-                        <div class="oe_radio_header" t-att-style="'width: ' + width + '%;'"><t t-esc="selection[1]"/></div>
+                        <label t-att-for="widget.uniqueId + '_' + selection[0]" t-att-style="'width: ' + width + '%;'"><t t-esc="selection[1]"/></label>
                     </t>
                     <br/>
                 </t>
                 <t t-foreach="widget.selection" t-as="selection">
-                    <div class="oe_radio_input" t-att-style="'width: ' + width + '%;'" t-att-data-id="selection[0]">&amp;nbsp;</div>
+                    <input type="radio" t-att-name="widget.uniqueId" t-att-id="widget.uniqueId + '_' + selection[0]" t-att-style="'width: ' + width + '%;'" t-att-value="selection[0]"/>
                 </t>
             </t>
             <t t-if="!widget.horizontal">
                 <t t-foreach="widget.selection" t-as="selection">
-                    <div class="oe_radio_header" t-att-data-id="selection[0]">
-                        <div class="oe_radio_input">&amp;nbsp;</div><t t-if="!widget.no_radiolabel" t-esc="selection[1]"/>
+                    <div t-att-data-id="selection[0]">
+                        <input type="radio" t-att-id="widget.uniqueId + '_' + selection[0]" t-att-name="widget.uniqueId" t-att-value="selection[0]"/>&amp;nbsp;<label t-if="!widget.no_radiolabel" t-att-for="widget.uniqueId + '_' + selection[0]"><t t-esc="selection[1]"/></label>
                     </div>
                 </t>
             </t>
         </span>
-        <span class="oe_radio_read_only"><div class="oe_radio_header"><t t-esc="widget.get('value')[1]"/></div></span>
+        <span class="oe_radio_read_only"><t t-esc="widget.get('value')[1]"/></span>
     </span>
 </t>
 <t t-name="FieldMany2One">