From fbbc3a54e91e7768ecf33038154a2bdbd87505ba Mon Sep 17 00:00:00 2001 From: Richard Mathot Date: Wed, 2 Jul 2014 17:29:13 +0200 Subject: [PATCH] [FIX] RML reporting: understandable crash message When tag is misused in an RML report, logs a more explicit error --- openerp/report/render/rml2pdf/trml2pdf.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/openerp/report/render/rml2pdf/trml2pdf.py b/openerp/report/render/rml2pdf/trml2pdf.py index 9ed1a14a21b..ec5e9484805 100644 --- a/openerp/report/render/rml2pdf/trml2pdf.py +++ b/openerp/report/render/rml2pdf/trml2pdf.py @@ -373,7 +373,11 @@ class _rml_canvas(object): v = utils.attr_get(node, ['x','y']) text=self._textual(node, **v) text = utils.xml2str(text) - self.canvas.drawString(text=text, **v) + try: + self.canvas.drawString(text=text, **v) + except TypeError as e: + _logger.error("Bad RML: tag requires attributes 'x' and 'y'!") + raise e def _drawCenteredString(self, node): v = utils.attr_get(node, ['x','y'])