Commit Graph

411 Commits

Author SHA1 Message Date
Nicolas Martinelli e11f50599d [FIX] web_graph: duplicates header in pivot
For report with duplicated named headers, several columns could get
squashed together.

This fix check if a value is a duplicate or not, and if it is a
duplicates postfix an number allowing to differentiate the two headers
(for the human and the javascript).

This is the exact same solution than #6722
Backport of 5cff8fbb7c70a372cb5116c2fb98fd622c4d4358
opw-650000
2015-09-29 08:33:36 +02:00
Goffin Simon 7d79520559 [FIX] web_graph: graduations on Y axe
For bar chart, the graduations along Y axe must be in language format
of the user.

opw:631659
2015-05-04 12:16:17 +02:00
kevin wang d023c079ed [FIX] web_graph: format pivot cells with correct precision
fields received by the fields_get call sometimes have a digit
precision.  This commit makes sure that it is used when
formatting the cells to be displayed.
2015-01-09 14:40:53 +01:00
Denis Ledoux 15d87a1732 [FIX] web_graph: pass context to fields_get for translation
In graph views, fields from the pivot table were not translated in the user language
We pass the context, containing the user language, to fields_get in order to get the translation
This is also done by the search view, in search.js line 1978 at this rev.

opw-616713
2014-11-27 16:06:05 +01:00
Christophe Simonis 562272d9a0 [MERGE] forward port of branch saas-3 up to c89d1a0 2014-10-23 13:08:44 +02:00
David Monjoie d2147fc92b [IMP] web_graph: renamed Quantity field into Count to avoid ambiguities 2014-10-21 14:57:52 +02:00
Christophe Simonis e2e60bf4eb [MERGE] forward port of branch saas-3 up to fe8106f 2014-09-26 12:53:59 +02:00
Géry Debongnie 0305010f2f [FIX] fix context problem in graph view
The group_by query expects the context to have group_by_no_leaf = true,
so we can not just blindly forward the context to the groupby query.
This is a defensive way to fix the problem, to avoid other possible
crashes.  But the context shouldn't have group_by_no_leaf anyway,
it does not make sense to explicitely do that in the action
2014-09-26 11:43:59 +02:00
Géry Debongnie 4c031b95d0 [FIX] correctly forward context in graph view
the new graph view silently ignored the context when doing its rpc
read_group.  Usually, it's not really a problem, which is why it is only
now being fixed, but some models actually use the context in read_group.
(for ex, account_entries_report)
2014-09-22 11:18:41 +02:00
Géry Debongnie 145690d81b [FIX] display problem in graph view in some cases
Recently, the graph view was changed to prevent changing groupbys
for active custom filters.  Unfortunately, I did not take into account
the fact that pivot table can be drawn in part when expanding rows.

The "frozen" parameter was then undefined and caused display problems,
this patch should fix the issue.
2014-09-16 10:11:47 +02:00
Géry Debongnie 22b1f5ce0c [FIX] web: fixes issues with custom filters and search view
The problem was that when the user manipulates the graph view (in pivot
table mode), the graph view resetted the group by facet in the search
view.  It was not a problem unless a custom filter with a groupby was
already there, in which case, the group bys were duplicated.

The search view is now smarter, it only resets the additional groupbys
(and col_groupbys).   Also, to prevent usability problems, the graph
view disable the '+/-' groupbys added by a custom filters.

Note that this fix is only temporary: a revamp of custom filters, facets,
search view is coming in the next months. (at least, that's the idea). Right
now, too much 'search logic' is in the graph view.

Another note: this fix is somewhat fragile: it makes some assumptions
about the search query (mainly that the custom filter is the first facet,
also, that no other filters add groupbys/col_groupbys)
2014-09-15 09:52:34 +02:00
Denis Ledoux 3911468d72 [FIX] web_graph: pivot_table, use _.isEmpty to check if value_lookup is False 2014-09-11 17:00:45 +02:00
Raphael Collet 2ad092b5e5 [ADD] doc: new documentation, with training tutorials, and new scaffolding 2014-08-22 17:51:20 +02:00
Géry Debongnie 10be95407a [FIX] css fix in graph view
The field selection menu was not positioned correctly when there was
a long list.  (was not displayed at the position clicked)
2014-08-22 13:18:40 +02:00
qdc 8307a5f6ed [IMP] Graph views: show always measure + filters record measures in context 2014-08-21 11:09:49 +02:00
Olivier Dony e11eddf753 [MERGE] Forward-port of saas-5 up to 20cc18d 2014-08-13 20:46:47 +02:00
Olivier Dony 2a94d1d811 [MERGE] Forward-port saas-4 up to 2694ed1 2014-08-13 17:34:27 +02:00
Christophe Simonis ff0ab6426a [FIX] web_graph : display the corresponding label for selection fields in graph view 2014-08-13 11:12:20 +02:00
Denis Ledoux ae65be2b2a [MERGE] forward port of branch saas-5 up to 0739bc4 2014-08-11 15:58:02 +02:00
Denis Ledoux 7c647ec876 [MERGE] forward port of branch saas-4 up to 0a1e4a0 2014-08-08 17:27:29 +02:00
Jérome Maes 007a2f2a24 [FIX] web_graph : display the correct label for Selection fields in view graph 2014-08-07 16:00:19 +02:00
Géry Debongnie 08d957c264 [FIX] addon web: prefix css dropdown-submenu
to prevent possible future conflicts
2014-07-30 15:11:22 +02:00
Géry Debongnie afb19c59ee [IMP] improve graph view layout and groupbys
* add a 'total' foldable button to allow the user to control the column
in pivot table view
* in the dropdown menu, add all fields from the model instead of only
those from the search view groupbys
2014-07-30 15:11:21 +02:00
Géry Debongnie cedae1fba7 [FIX] removes non stored fields from measures
Non stored functional fields cannot be grouped by read_group, so it is
useless, and even harmful, to display them in the measure list (in
graph view).
2014-06-13 13:32:24 +02:00
Géry Debongnie 6f436a2a0e [FIX] correctly compute mouse click coords
in graph view, when the user click on the pivot table.  It was
calculated with pageX, pageY and positioned with 'absolute'. However,
the main view is now also positionod, so the dropdown menu was not
where it should be.
2014-05-30 09:21:30 +02:00
Géry Debongnie cc64d1d318 [FIX] fix the graphview field selection
searchview has been split in two parts, and the inputs are now located
in the drawer
2014-05-20 16:18:03 +02:00
Gery Debongnie e94c1f03d6 [IMP] optimizes pivot table rendering when expanding rows (addon web_graph)
This patch makes the graph widget only add the rows that were new instead
of redrawing the full table when expanding

bzr revid: ged@openerp.com-20140509090935-sje3u6i4x1luswwn
2014-05-09 11:09:35 +02:00
Gery Debongnie 8f55e4519f [IMP] optimize the pivot table rendering when folding rows (addon web_graph)
don't redraw the full table when folding rows.  instead, it removes from the dom the corresponding rows.  This should give a big speed boost when folding rows on big tables.

bzr revid: ged@openerp.com-20140508124002-yaa383rq4c0qhrf8
2014-05-08 14:40:02 +02:00
Gery Debongnie 1c87d5b6f4 [FIX] render the pivot table correctly (addon web_graph)
The code was bugged: it added a <tbody> tag around each rows instead of adding the rows to a single tbody.

bzr revid: ged@openerp.com-20140508112723-b6ffkmufwux1z0a7
2014-05-08 13:27:23 +02:00
Gery Debongnie b9c217e850 [FIX] add $ to jquery variables (addon web_graph)
the rendering code of the pivot table didn't use $ in jquery variables,
this commit fixes that issue and slightly simplify their names.

bzr revid: ged@openerp.com-20140508111311-kargzvzlttutwt47
2014-05-08 13:13:11 +02:00
Gery Debongnie 79c197814b [IMP] improve the way indentation is done in pivot table (addon web_graph)
Previously, it was done in a ugly way: added several spans with the class
.graph_indent.  Now, it simply sets the margin of the content.

bzr revid: ged@openerp.com-20140508110027-bdjdzlpfptjuf4fa
2014-05-08 13:00:27 +02:00
Kersten Jeremy 13d18d2bdb [FIX] Graph - Add context in fields_get to have the right translation in col_header and other places where terms was not translate.
lp bug: https://launchpad.net/bugs/1317079 fixed

bzr revid: jke@openerp.com-20140507154758-0vkq9rywjyl55f5w
2014-05-07 17:47:58 +02:00
Antony Lesuisse 5e21a4235d [MERGE] saas-4 up to dle@openerp.com-20140501121915-q88k37nd25ietw8c
bzr revid: al@openerp.com-20140501172508-tjennzht30ktw3nz
2014-05-01 19:25:08 +02:00
Gery Debongnie a6b25061ba [MERGE] merge from trunk
bzr revid: ged@openerp.com-20140430085942-umusyhp4cs2ffezj
bzr revid: ged@openerp.com-20140430140423-kq0vdboq1mux4zfn
2014-04-30 16:04:23 +02:00
Gery Debongnie 1f693aaed6 [FIX] fix a crash in graphview when user clicked rapidly twice on menu item
The issue was that the get_search_fields method tried to get the view's 
corresponding searchview after a rpc (fields_get).  Sadly, if the user
had meanwhile clicked again on the menu item, the first view would be
detached from the view manager and would be unable to reach the search 
view.  The solution is to move the lookup for the search view in the start
method, where it is guaranteed to exist.

bzr revid: ged@openerp.com-20140430084927-m11dxqg9ko0dnu08
2014-04-30 10:49:27 +02:00
Gery Debongnie 36e3aac85e [IMP] large optimizations to the graph view rendering (pivot table)
The pivot table rendering was slow with large tables : it appended to the
table each line, so the browser had to rerender each time the page.  This
was solved by rendering the table to a document fragment, then only add
the fragment to the main document.  This speeds up considerably the process
(from 2600ms to 420ms in one test)

Also, uses basic loops instead of underscore maps in the build_rows method

bzr revid: ged@openerp.com-20140430074733-quhfkzz33rlpahps
2014-04-30 09:47:33 +02:00
Gery Debongnie 065b3c2176 [IMP] add the expand all button back to the graph view
It was removed a long time ago, but it looks like the 'expand all' button
is useful enough to make a comeback.

Also, this commit removes a few useless lines in graph_widget about the 
grouped/stacked status of bar charts

bzr revid: ged@openerp.com-20140428090221-po3ksrd73093w3qm
2014-04-28 11:02:21 +02:00
Gery Debongnie a32d8cb9de [FIX] (partially) fixes a concurrence problem in graph view
The graph view is asynchronous when updating data.  It is not safe when 
the user tries to update quickly the group bys (for example, when adding two 
group bys in quick succession).  

This patch partially fixes the problem: it makes sure that two concurrent updates 
will be correctly serialized.  However, it is not a complete fix: the crash can still happen
when three or more updates are quickly done.  A complete solution require some more work in 
keeping tracks of an update queue and serializing properly the updates. (will be done in trunk)

bzr revid: ged@openerp.com-20140425102501-qe7ve1ug8neq1twv
2014-04-25 12:25:01 +02:00
Gery Debongnie 0241b762b2 [FIX] fix line chart x-axis labels: it now correctly uses the name of the row, and not a number (addon web_graph)
bzr revid: ged@openerp.com-20140422150441-3vll2jw69z319yza
2014-04-22 17:04:41 +02:00
Gery Debongnie 394897383f [FIX] correct the scaling problem of graph bar charts: nvd3 needs a numeric value and was given a [value]. Also, improves the margin of bar/line/pie charts (addon web_graph)
bzr revid: ged@openerp.com-20140422150401-p0t9xmittp73j7hx
2014-04-22 17:04:01 +02:00
Gery Debongnie f584b030bc [FIX] correct fix for the scrolling problem in graph view: the view now saves its scrolling position before redrawing itself (addon web_graph)
bzr revid: ged@openerp.com-20140422150316-m51u750732re8qib
2014-04-22 17:03:16 +02:00
Gery Debongnie 8c001acda0 [FIX] in graph view, save the scrolling position and use it when redrawing the table (addon web_graph)
bzr revid: ged@openerp.com-20140422150209-f06ffxry1h46cpfh
2014-04-22 17:02:09 +02:00
Gery Debongnie c3c56bb2b1 [FIX] disable export to xls button in graph view when there are no data to export, this prevent a crash (addon web)
bzr revid: ged@openerp.com-20140422145955-vfls1hxktnq8m67b
2014-04-22 16:59:55 +02:00
Gery Debongnie 00cb732ea0 [FIX] only hide the export button (and not all the config buttons) in graph view when the module xlwt is not installed (addon web)
bzr revid: ged@openerp.com-20140422145918-s20n3qla1nfte5dj
2014-04-22 16:59:18 +02:00
Gery Debongnie f966931b87 [IMP] performance improvement: write a custom isEqual function to use instead of _.isEqual to make the code faster in graph view (isEqual was determined guilty of being slow by profiling on a large view) (addon web_graph)
bzr revid: ged@openerp.com-20140409145735-m21t2fzmaepr1hsa
2014-04-09 16:57:35 +02:00
Gery Debongnie 281c19a751 [FIX] correctly determines when there is no data to read in graph view (instead of the good old crash) (addon web_graph)
bzr revid: ged@openerp.com-20140409123628-erw8dpb2l36l7hu6
2014-04-09 14:36:28 +02:00
Gery Debongnie 1330bb615e [IMP] massive optimization of the graph view code: more efficient access to values and smarter code to avoid reading uselessly many cells (graph view in web_graph)
bzr revid: ged@openerp.com-20140409093920-xqls2o6j6tocgf6l
2014-04-09 11:39:20 +02:00
Gery Debongnie 53cca3a046 [MERGE] merge from trunk
bzr revid: ged@openerp.com-20140407080642-b51z9j9cryb72tpc
bzr revid: ged@openerp.com-20140408090852-xmfi9nwd2lzsfbza
2014-04-08 11:08:52 +02:00
Christophe Simonis f1d3f2a0c4 [MERGE] forward port of branch saas-3 up to revid 3995 chs@openerp.com-20140407144625-jfimvsx4mgrkztqv
bzr revid: chs@openerp.com-20140407161728-ccudwnqo970ac8ay
2014-04-07 18:17:28 +02:00
Gery Debongnie 4d79722227 [FIX] add missing semicolons, add a missing 'var' statement and remove trailing whitespace (addon web_graph)
bzr revid: ged@openerp.com-20140404143009-6uk7607bv4acbg4b
2014-04-04 16:30:09 +02:00