Commit Graph

82776 Commits

Author SHA1 Message Date
Denis Ledoux 3f7f2a51fa [FIX] security: remove read access on company critical fields 2014-08-26 15:35:47 +02:00
Denis Ledoux 53582c2ea6 [FIX] security: res.groups should be readable by admins only 2014-08-26 13:31:41 +02:00
Denis Ledoux 72d3697fbc [FIX] security: externals should be able to read attachements
without having the rights to read ir.config_parameter
2014-08-26 12:55:48 +02:00
Denis Ledoux 80017b04c2 [FIX] security: ir.config_parameter should not be readable by externals 2014-08-26 12:50:04 +02:00
Denis Ledoux e7f8425a3a Revert "[FIX] web: grid headers should be aligned properly"
This reverts commit 4c335588a1.
It leads to table widths inconsistencies: The tables take more width then before, and overflow much more than before. This can be seen in "Accounting" > "Journal Entries", in the list of the form view
2014-08-26 10:56:44 +02:00
TheCloneMaster 4b446550c6 [FIX] hw_escpos: Replaced "tab" by space
call to self.open() had a tab instead of spaces
2014-08-25 18:08:40 +02:00
Daniel Dico f880d89cc4 [FIX] sale_order_line: use order date to compute currency instead of current date 2014-08-25 18:04:43 +02:00
Daniel Dico 180c4734a6 [FIX] product_visible_discount: use order date to compute currency instead of current date 2014-08-25 17:53:47 +02:00
Denis Ledoux 9b3f3fecfe [FIX] hr_holidays: employees cannot approve their holidays
Nor modify once approved

It wasn't possible for employees to approve their holidays themself, thanks to the GUI, but this was possible through xmlrpc calls, or when altering the html directly in the browser.
Besides, this was also possible to edit the holiday through the same trick once the holiday validated
2014-08-25 14:51:03 +02:00
Ravish Murari bc3991b4c5 [FIX] board: Do not offer to create dashboard when there is no action
In case we have no defined action (e.g. redirection by python code), adding a dashboard should not be possible as the rendering based on the action.
This patch hides the 'Add to Dashboard' button in search view (opw 611288)
2014-08-25 12:03:12 +02:00
Martin Trigaux 73546f70ca [FIX] point_of_sale: generate bank statement with commerical partner
When a pos session is closed & confirmed, the account.move were generated with the commercial partner except for the bank statement which prevented automatic reconciliation.
This patch uses the commercial partner also for bank statement.
Fixes #1558, #1764
2014-08-22 15:29:23 +02:00
Martin Trigaux b160f99e2d [FIX] fetchmail: do not delete a failing email when using POP
In case of IMAP, the email is simply set as read but in case of POP, the email is deleted. To avoid loosing data (e.g. misconfiguration of server), the email is kept for POP.
Bug lp:1296724, opw 605667
2014-08-22 14:14:56 +02:00
Bhavik Bagdiya 4c335588a1 [FIX] web: grid headers should be aligned properly 2014-08-22 12:54:17 +02:00
Martin Trigaux 7bcefaf232 Forward port of branch 7.0 up to 0ab88f5 2014-08-21 17:57:57 +02:00
Martin Trigaux 0ab88f54f9 [FIX] ir_model: invalidate cache when adding new fields
When a new ir.model.field is created, add the new field in the fields_by_model (cache of custom fields). This is required as the __init__ method would not retrieve the new field if fields_by_model is already set.
Otherwise, the _columns would not contain the new fields and we could not access it without restarting the server (e.g. the installation of a module adds ir.model.fields and use it in the a view.
2014-08-21 17:24:45 +02:00
Desai Binjal 8fe9f07cac [FIX] note: small bugs 2014-08-21 15:55:23 +02:00
Martin Trigaux 768b3592c2 [FIX] base: wrong model change check
Comparing an id and a browse record will always fail so the exception would have always been raised when changing a model (e.g. updating a module with custom fields).
2014-08-21 14:30:10 +02:00
fka-odoo 20a99ae129 [IMP] account_budget: added date filter in print budget report
Fixes #1743, opw 611307
2014-08-21 11:45:38 +02:00
Denis Ledoux 99ce17cfca [FIX] point_of_sale: report, product_id of line is product_product
product_id column of pos_order_line is a product_product
the left join of l.product_id was done on product_template, instead of product_product

It worked as long as the ids product_product were the same as product_template. Meaning that, if you used variants, this report view was screwed.
2014-08-21 11:20:09 +02:00
Christophe Simonis 8f13e8320e [MERGE] forward port of branch 7.0 up to d0a0b7d 2014-08-20 17:45:05 +02:00
Christophe Simonis f32c88f932 [FIX] web: correct /web/proxy/load to set correct base_url 2014-08-20 17:33:27 +02:00
Guewen Baconnier d0a0b7d91d [FIX] purchase: skip move if not linked to a purchase order
When this situation happens. the 'cost' is None and the web interface cannot handle this value, provoking a JS error. Thus, prefer to fallback on the standard way to get the cost: based on the current standard price of the product.
Fixes #1032
2014-08-20 15:13:36 +02:00
Martin Ambroz 106cb1ec2b [FIX] base: python 2.6 incompatibility for dictionary comprehension 2014-08-20 10:28:37 +02:00
Sandy Carter 11e4cad9f7 [IMP] auth_oauth: set default 'zocial' css_class
The buttons for new providers needs at least the zocial css class to be seen as button. As the field css_class is not in the default form view, add it by default.
2014-08-19 17:43:09 +02:00
Daniel Dico 9a763928e1 [FIX] account_anglo_saxon: variable 'standard_price' referenced before assignment
Due to forward-port, the variable standard_price was reintroduced instead of valuation_price_unit
Move the change of currency after the fifo/lifo computation.
Fixes #1801
2014-08-19 17:16:28 +02:00
Sébastien BEAU 3b901f0aa0 [FIX] web: ignored readonly attribute on image widget 2014-08-19 15:27:36 +02:00
fka-odoo 9247c37de7 [FIX] web: rendering issue in mail composer on Firefox
The cleditor width does not include the margins. Setting 100% will make the editable area too large (104%) on Firefox (opw 611700).
Replaced by auto, the default value adviced by CLEditor.
2014-08-19 11:55:53 +02:00
David Arnold 6164f52ca3 [FIX] account_voucher: wrong type in context
The type 'general' no longer exists on a account.voucher. As in general context, removed the default value on this menu.
Fixes #1261, it produces a traceback in 8.0 where the selection fields are less fault-tolerant.
2014-08-19 11:22:38 +02:00
Denis Ledoux cee1f0457d [FIX] sale: define sale_note field before using it as a default value for sale.order
When uninstalling/installing sale module, this can be problematic
2014-08-19 09:48:05 +02:00
Martin Trigaux f572b27ec8 [IMP] account_voucher: make the field tax_amount always readonly
The field tax_amount is fieled with onchanges and the compute_tax method. Setting a different value than the one computed by the system may lead to unbalanced move (which is obviously wrong).
In the future, handeling these operations by setting the correct value to the tax accounts would be better.
2014-08-18 17:59:17 +02:00
Martin Trigaux 85b08a75f6 [FIX] account_voucher: avoid error if no partner
The field partner_id is not required on an account.voucher but the validation was failing if none was set (opw 611663).
This patch makes a fallback on the account of the voucher if neither a partner nor a writeoff account is specified.
2014-08-18 17:50:32 +02:00
Thomas Groutars 397e83554b [FIX] product: make sure unlinked product still exists
When uninstalling/updating a module, we may execute unlink method on product.template before product.product. In such cases, the product is already removed after removeing the template (_inherits) and the chained unlink of the product would fail (traceback when browsing).
2014-08-18 10:37:03 +02:00
Denis Ledoux 97d097a2af [FIX] point_of_sale: field date of report.pos.order should be a datetime
The date_order field of the pos.order is a datetime, not a date
As, in report.pos.order, the date field is related to date_order of the pos.order

We usually do not commit fixes altering the model fields structure in 7.0, but this one is retro-compatible, as the database structure won't change
2014-08-14 18:01:37 +02:00
Denis Ledoux dcd26acccf [FIX] web: do not focus if the focus_field is not a field
Sometimes, focus_field could be a button, and in such cases, we should not focus on it

opw-612045
2014-08-14 17:33:59 +02:00
Rifakat fa27d28494 [FIX] stock: inventory lines with no production lot: compare with correct stock level
Inventory lines without production lot number should
be compared with the stock level of products without
a production lot. Otherwise the final result of a
validated inventory is wrong as soon as there are
lines with and without production lot for the same
product.

Adds corresponding regression test.

Fixes https://bugs.launchpad.net/openobject-addons/+bug/1008099
Manual rebase of #1658, courtesy of Numerigraphe
2014-08-14 16:51:37 +02:00
Olivier Dony 971ffa3db1 [FIX] account: reconcile: no useless revalidation
Avoid revalidating the complete account moves
that contain the lines being reconciled.
The reconciliation does not change the validity
of those moves anyway.
This represents a very important speed up of
reconciliation when moves with several hundred
lines are involved.
2014-08-14 16:51:37 +02:00
Mohammed Shekha 9207748a71 [FIX] Fixed the issue of calendar view reload events inconsistency, when the slow create popup creates event through any form button which is kind of object, action or workflow at that time events are reloaded but still button action is not called like workflow is not triggered and hence state of the event is still not changed and due to domain newly created event is filtered, note that events are refetched when create_completed is triggered and create_completed is triggered right after creation of record, but there are case where some form button changes state of the record and it requires to refetched for example we have scenario in mrp order planning where Confirm Production creates event but before workflow is triggered and state of the event is changed, events are reloaded and newly created event will not returned because of domain. 2014-08-14 16:21:20 +02:00
Denis Ledoux 9b5553286a [FIX] export: in saas-3, req becomes request.
Error during forward port b9275da8a5
2014-08-14 12:49:32 +02:00
Martin Trigaux deacba0ed6 [IMP] base: no default domain for partner's title
The title field should not have a domain by default.
When a new record is created or the 'is company' field is changed, the onchange_type is triggered to restrict the domain accordingly to is_company field.
When an existing record is modified, there will have no domain on title field. It's not ideal but at least companies will be able to change the title without the need to modify twice the field is_company.
Fixes #1713
2014-08-14 12:00:27 +02:00
Olivier Dony 8b12d1c566 [MERGE] Forward-port of 7.0 up to 85d2b45 2014-08-14 04:11:33 +02:00
Olivier Dony 85d2b45aaa [I18N] Update 7.0 translations with latest changes on Launchpad
See also https://github.com/odoo/odoo/wiki/GitHub-Transition#translations
2014-08-14 03:38:58 +02:00
Olivier Dony 96c36e895c [I18N] Update all 7.0 translation templates with latest terms and annotations
Total new terms: 168
Total deleted terms: 95
Total identical terms: 16329
(Some modules skipped, typically all l10n_* modules)
2014-08-14 02:24:24 +02:00
Olivier Dony 69eef5ac8d [FIX] tools.translate: addons path resolution failed with duplicates
When the addons_path config contained the
default path, the system was working with
an empty addons_path in the middle of the
other paths. This empty one matched for all
files, making all files appear to belong to
the root path component, e.g. `home` if the
root path is in /home.
Refactored a bit to avoid duplicates and
redundant path calculations.
2014-08-14 02:07:59 +02:00
Vo Minh Thu 680214c47e [FIX] tools.translate: when loading entries from a PO file, use also the POT.
On Launchpad, as commented on bug 933496, PO entries (and their comments) are
shared between series. This mean that e.g. the 7.0 series can have the wrong
`reference` comments (those beginning with #:) as they would be copied from say
the trunk series. Those `reference` comments are used to import translations
and look them up.

This patch adds a few lines of code to tools.translate so that targets
defined in the POT `reference` comments are used in addition to those from the
PO file.

Also adds a test module to validate the new behavior.

This patch stems from:
 - the 6.1 branch by Vo Minh Thu:
    https://code.launchpad.net/+branch/~openerp-dev/openobject-server/6.1-fix-po-targets-933496-vmt
 - the 7.0 port by Numerigraphe:
    https://code.launchpad.net/~numerigraphe-team/openobject-server/7.0-fix-po-targets-933496-vmt
2014-08-13 23:07:40 +02:00
Olivier Dony 303d2e09eb [FIX] portal_sale: access rights: sale.shop was removed at cf6595b
Fixes error in forward-port b9275da
2014-08-13 20:54:27 +02:00
Olivier Dony daaef17ccb [FIX] portal_sale: missing closing tag in b9275da during forward-port 2014-08-13 17:49:40 +02:00
Olivier Dony b9275da8a5 [MERGE] Forward-port 7.0 up to 23cffab 2014-08-13 17:30:06 +02:00
Olivier Dony 23cffab1f8 [FIX] portal_sale: remove more access rights, add pricelist access
Pricelist access is necessary for being able to read
the unit price of sale order lines, and does not
pose major security risks, as it does not permit
reading the actual pricelist definition.
2014-08-13 17:20:49 +02:00
Olivier Dony d03ae8980a [FIX] portal_sale: remove un-necessary access rights, improve rules
Portal access rights need to be associated with
security rules, or not granted at all, as soon
as they grant access to non-trivial data.
2014-08-13 16:46:42 +02:00
Martin Trigaux bceb278199 [FIX] base: revert 19e401a for title on res.partner form
The title of the partner is restricted with a context that will change in the onchange_type. Having twice the same field will not work well.
Remove the invisible attribute as the domain is handled by the domain.
2014-08-13 15:04:54 +02:00