Commit Graph

76248 Commits

Author SHA1 Message Date
Denis Ledoux 4adb4b8d15 [FIX] sale, website_sale: Send email on sale order confirmation
Not just when coming back from the payment provider to the
payment validation route `/shop/payment/validate`.

Otherwise, if you do not come back from the payment provider
page, that you quit just after having paid but just before
being redirected to Odoo, you do not receive the email.

The change within the `sale` module, while this issue concerns
`website_sale` only, has been accepted because this is a mechanism
that could be used by other modules.

opw-644348
2015-07-09 15:51:50 +02:00
Goffin Simon 85a06f8a6e [FIX] sale: confirmed sale order line
The filter "Confirmed" is applied on sale order line.
Introduced by b927f8a864
2015-07-09 15:23:44 +02:00
Goffin Simon dacf29427f [FIX] purchase: Invoicing on incoming shipments
The filter "Incoming Shipments to Invoice" must not include shipments that are
already invoiced.

opw:644407
2015-07-09 14:10:13 +02:00
Goffin Simon 2835381c7e [FIX] acount: aged partner balance
In the aged balance report, the reconcile entries are excluded
except if the reconciliation date is greater than the date for which the aged balance report is requested.
But this exception should never include opening entries.

opw:643172
2015-07-09 12:54:16 +02:00
Denis Ledoux 7c2521a79b [FIX] payment_ogone: amount rounding issue
The amount to pay must be sent without comma to ogone.
e.g., for 66.99 EUR, the amount sent must be 6699.

To do that, we simply applied 66.99 * 100, which
seems rather good.

However, due to the fact how floats are handled in computers,
`66.99 * 100` returns 6698.999999999999
and
`int(6698.999999999999)` returns 6698
while we expected 6699

Using `float_repr` with `0` as decimal precision
instead of using `int` solves this issue.
`float_repr(6698.999999999999, 0)` returns 6699, as expected.
2015-07-09 11:51:40 +02:00
Lionel Sausin 4be4678d8b [FIX] stock_account: use all inbound/outbound moves when valuating
The valuation wizard is based on stock moves and currently only takes into
account the moves which have different companies in source vs destination
locations.
This is a problem because all user-created locations have a default company set
to the user's company, even the "virtual" ones. For example in the demo dataset
visible on runbot, some supplier locations have a company set and some don't.
So we have to make sure to include every move coming from/going to
outside locations based on the locations's type too.

Closes #7530
2015-07-09 11:39:14 +02:00
Denis Ledoux 812318dcba [FIX] survery: access rights for invitations
When building a new suvery, and sending invitation
trough private emails, it wasn't possible
to fill the survey from the link sent
if you were not logged as the user who sent
the invitation, or as a survey manager

opw-644210
Fixes #7486
2015-07-09 11:01:14 +02:00
Lionel Sausin 5fcad55000 [FIX] stock_account: missing default filter for valuation menu
The menu entry in Warehouse > Current Inventory Valuation is a shortcut to the
same results as the wizard in Reports > Warehouse > Valuation. However when
using the "current valuation" menu entry, the list is given without grouping by
product and location, so it's basically just a glorified list of stock moves
that no Warehouse manager is going to understand.

Let's just add the same default grouping to let the results make sense.

Closes #7531
2015-07-09 09:29:18 +02:00
Martin Trigaux 45748bab59 Revert "[I18N] purchase: remove untranslatable term from .pot"
This reverts commit 905dd88ce4.
This fields contains the attachment name which do make sense to be translated
("PO" stands for "Purchase Order").
2015-07-09 08:58:51 +02:00
Goffin Simon c33f79ae3e [FIX] stock: _get_domain_locations function
To adopt the same behavior than location with warehouse in function _get_domain_locations.

opw:644219
2015-07-09 08:00:05 +02:00
Goffin Simon a35af81e6a [FIX] account_voucher: onchange_journal
In the "Pay invoice" wizard, the period doesn't have to be change when
the payment method is modified.

opw:643791
2015-07-08 14:30:56 +02:00
Denis Ledoux d08facdcb5 [FIX] website: the sitemap must be build with the public user
Otherwise, when accessing `/sitemap.xml` as SUPERUSER for instance,
pages not published were displayed in the sitemap.

opw-640673
2015-07-08 14:16:30 +02:00
Martin Trigaux 905dd88ce4 [I18N] purchase: remove untranslatable term from .pot 2015-07-08 13:59:42 +02:00
Martin Trigaux d2e660b31d [FIX] purchase: field label
No need for uppercase, courtesy of Lionel Sausin.

Well, Clarice - have the lambs stopped screaming?
  -- Hannibal Lecter
2015-07-08 13:47:38 +02:00
Holger Brunn f204c76f23 [FIX] web: keep the context we got in Many2ManyDataset
This bug causes binary fields in many2many lists being presented as a data url,
even though bin_size is passed.

Closes #6966
2015-07-08 13:42:59 +02:00
Guewen Baconnier 26c7ea4de6 [REF] account_analytic_analysis: extract a method for preparing invoice lines
In recurring invoices from contracts. It allows to inherit and modify the
prepared values for the lines.

Closes #6822
2015-07-08 13:42:59 +02:00
Holger Brunn 1e8f8eabec [IMP] procurement, stock: make procurement.rule.name and stock.location.route.name translatable
Closes #4222
2015-07-08 13:42:59 +02:00
Erwin van der Ploeg 91985d7eae [FIX] stock: visibility of "Recheck Availability"
If a picking is partially available and some lines are waiting another operation
2015-07-08 11:39:13 +02:00
Goffin Simon e27d854801 [FIX] website_sale: delete console.log
Delete console.log introduced by 4d7671a4c3
2015-07-08 10:37:33 +02:00
Lionel Sausin 7fb37b3e89 [FIX] stock: missing default filter for quants menu
Most (if not every) other ways to open a list of quants has default filters to
include only internal locations.

Closes #7501
2015-07-08 09:30:33 +02:00
Goffin Simon 669948569b [FIX] website_sale: alternative products
Display correctly the alternative products

opw:643934
2015-07-08 09:11:01 +02:00
Christophe Simonis 2de301df24 [FIX] analytic: copy children accounts on copy. 2015-07-07 17:37:31 +02:00
Nicolas Martinelli 24556120e7 [FIX] purchase: apply appropriate fiscal position when PO created automatically
When a PO is created automatically from a procurement, the fiscal position is
not chosen correctly. We need to choose the fiscal position in the same way if
the PO is created manually or automatically.

Follows commit 1062905acb

Fixes #3863
opw-643916
2015-07-07 16:08:11 +02:00
Christophe Simonis acc7d20ea9 [MERGE] forward port of branch saas-3 up to ac865c8 2015-07-07 15:12:41 +02:00
Christophe Simonis ac865c8a78 [MERGE] forward port of branch 7.0 up to 9fa7624 2015-07-07 13:58:35 +02:00
EL HADJI DEM 076944cc3f [FIX] mrp_repair: display tracking warning only if lot_id not defined
Closes #6826
2015-07-07 12:47:13 +02:00
Leonardo Pistone 02ae76ce0b [FIX] account: type builtin used as a local variable
Close #6901
2015-07-07 12:47:13 +02:00
Nicolas Martinelli 9fa7624e25 [FIX] stock: onchange_quantity and onchange_uos_quantity use rounding
It is necessary to round the quantities with the appropriate precision. Indeed,
since onchange_quantity and onchange_uos_quantity trigger each other indirectly,
it is quite easy to fall in an infinite loop if the uom and uos precisions are
different.

Follows commit 6e346f0adb

opw-643651
2015-07-07 11:25:19 +02:00
Nicolas Martinelli b4efb4eeb3 [FIX] web: on calendar with date and time, focus in the field only when hidden
The behavior of the datetime widget was to focus in the field every time a date
is chosen. This causes an issue if the datetime widget is called from an
editable list. Indeed, the list editable will consider that the value has been
set, and therefore the value will not be changed anymore if the user choses
another date.

The new behavior is to put the focus only when the date picker is hidden,
therefore the editable list will consider the value set only when the selection
is done.

opw-644062
Fixes #7463
2015-07-07 11:19:27 +02:00
Samus CTO 6490c62e5d [FIX] mail: backport of rev 752a07c to 8.0
[FIX] res.partner.find_or_create() should match using =like

Otherwise john@connor.com may match sarah.john@connor.com
2015-07-07 08:52:44 +02:00
Lionel Sausin cdd023f8fc [FIX] delivery: grant stock workers permission to list carriers
Otherwise sotck users are not allowed to list the available carriers (e.g. when
creating a picking).

Closes #7299
2015-07-06 17:09:10 +02:00
Martin Trigaux 5e475f75de [FIX] stock: filter products on locations
Filtering product.product based on the location crashed due to fields_view_get
override exepecting an integer in the context.

Fixes #5164
Closes #5218
2015-07-06 16:28:48 +02:00
Loïc BELLIER 34b9f43011 [FIX] stock: add location in context on prodlot search
To be consistant with the results of _get_stock. Otherwise search made on
stock_available may not display results with the same value than the search
criteria.
Fixes #3976
2015-07-06 14:41:56 +02:00
Nicolas Lempereur b5d7e663b4 [FIX] web: readonly field and tab
When we go from one field to another via the tab key, in the form view what happens is:

{{we get a blur from the current field}}
-> if [[widget was not in state clicked (which can be gotten for example by clicking on a focused field)]]
     -> blur event is cancelled,
     -> the blur event is set to be triggered soon
-> the clicked state is set to false

{{we may get a focus for the next field}}
-> if [next field get an onfocus event]
     -> blur event is cancelled,

So if :
- the state is not clicked and,
- the next field don't get an focus event.

We get a blur event which will either save (if a field value has been changed) or cancel
the form view editing and will hide the current edition, hence losing the focus.

For example, it happens on a readonly fields with  field containing an `<a />` tag, on
some browser (for example google chrome), the focus event will not get triggered (it still
work if we were in a clicked state) so we can't cycle thought a list editable cells if there is a readonly field in it.

closes #7446
opw-643718
2015-07-06 11:55:01 +02:00
Jos De Graeve baa51efdc9 [FIX] point_of_sale: do not create empty picking for order with only service products
When confirming a pos order with only "service" products, an emtpy pos order is
created which stays in "draft" state forever.

Closes #7460
2015-07-06 11:33:19 +02:00
Lionel Sausin (Numérigraphe) a55a768d61 [FIX] stock: colors in tree view
Missing part from e28e01a

Closes #6785
2015-07-06 10:07:59 +02:00
Odoo Translation Bot fe3835faff [I18N] Update translation terms from Transifex 2015-07-05 01:52:32 +02:00
Nicolas Martinelli 6e346f0adb [FIX] stock: product_uos_qty must have the precision of Product UoS
If 'Product UoS' has a higher precision than 'Product Unit of Measure', the
method onchange_uos_quantity will be called over and over by an infinite loop
if 'product_uos_qty' doesn't have the sufficient number of decimals.

opw-643651
2015-07-03 16:42:34 +02:00
Jos De Graeve 7771c45ed9 [FIX] sale: product_id_change ignores context
The product_id_change method of sale.order.line
ignored the passed context.

The context was simply overwritten,
which is no a good practice.

Besides, it prevents customizations.

Closes #7447
opw-643983
2015-07-03 16:38:12 +02:00
Nicolas Lempereur 880c997e12 [FIX] website_quote: take suggested product lang from partner
Use the lang from the sale order's partner when updating suggested
product line. To achieve this, the onchange has been replaced by an
onchange of the new api which gives access to all the fields.

closes #7268
opw-643098
2015-07-03 13:58:22 +02:00
Nicolas Martinelli 2a49c1a7fb [FIX] purchase: take into account the currency of unit price
The currency of the unit price of the stock.move is the currency of the
company, which can be different from the currency of the invoice.

opw-643077
2015-07-03 12:26:02 +02:00
Lorenzo Battistini 0f82346167 [FIX] email_template: keep email_from and outgoing server
When sending an email from mail.compose.message using a template, the system
should use the outgoing mail server associated to the template.
Introduce context hack to keep these values.

This should NOT to be forward ported to version 8 where a proper fix exists.

Fixes #3848
2015-07-03 12:21:53 +02:00
Wolfgang Taferner c776dce531 Revert "[FIX] product_extended: cost price computation from BOM"
This reverts commit 2f5d681135.

The previous commit was intended to fix a wrong assumption in case the
purchase uom was different to the standard uom.

The wrong assumption:
- price is related to purchase uom
- therefore it was tried to convert the bom price accordingly
- as the price needs to be already in standard uom it does lead to a
wrong calculation now

Closes #7421
2015-07-03 12:16:55 +02:00
Olivier Dony dc0e126b53 [FIX] hr_holidays: leave holiday overlap should ignore cancelled/refused ones
Obviously a cancelled leave does not really
overlap with a new one.

bzr revid: odo@openerp.com-20131023162928-56vdsjxr8sa4n3jv

Closes #2329
2015-07-03 12:07:47 +02:00
Goffin Simon 72ec0050b4 [FIX] account: bank statement reconciliation
To determine the account.move.line to reconcile, first it tries to match with
the ref and the amount of the account.bank.statement.line and if it doesn't match,
it just tries to match with the amount.

opw:643867
2015-07-03 11:55:46 +02:00
Nicolas Martinelli 1ab007a843 [FIX] mrp: fix issue introduced by rev b9cdce1
If copy=True for production_id, a move created from a push rule will be added
in the list of Product Produced. Therefore, we must set manually the value of
production_id of the scrapped moves.

opw-643877
2015-07-03 11:45:33 +02:00
Goffin Simon 3062b66d21 [FIX] mail: unknown icon
When the attachment type is not defined, the icon used must be unknown.png

closes#7336
2015-07-03 11:35:31 +02:00
Denis Ledoux 25d365ee69 [FIX] payment_authorize: adapt test for rev. 3375ff2827
Besides, the test was particularly useful:
It tested that when 'Buyer' was sent as firstname
and 'Nobert' as lastname to Authorize,
authorize returned the opposite, 'Norbert' as firstname
and 'Buyer' as last name.
2015-07-02 18:00:01 +02:00
Denis Ledoux 3375ff2827 [FIX] payment: By assumption, first name is before last name
In the partner model, there is only one field `name`.
The first name and the last name are not within two
separated fields.

By assumption, the firstname is written before the last name
(first <> last)

This assumption should be kept when sending the
first name / last name of the partner to the payment acquirers
e.g. Paypal.

opw-643120
2015-07-02 17:21:02 +02:00
Christophe Combelles 2c37f83435 [FIX] analytic: duplication of analytic lines
When duplicating analytic accounts, child accounts are duplicated as well.
The custom copy method removes the analytic lines but this applies only on the
first copy. As the copy_data method recursively copies child accounts, these
child accounts did not use the custom copy method but the basic copy_data.

Move to copy_data

Fixes #6368, lp:1149676
2015-07-02 16:54:46 +02:00