Commit Graph

71958 Commits

Author SHA1 Message Date
Denis Ledoux 1f4f0c0768 [FIX] email_template: security, email_template no rights for externals 2014-08-26 17:32:04 +02:00
Denis Ledoux dd86d41eb4 [FIX] security: disallow read on ir.sequence for externals 2014-08-26 16:17:24 +02:00
Denis Ledoux 3f7f2a51fa [FIX] security: remove read access on company critical fields 2014-08-26 15:35:47 +02:00
Denis Ledoux 53582c2ea6 [FIX] security: res.groups should be readable by admins only 2014-08-26 13:31:41 +02:00
Denis Ledoux 72d3697fbc [FIX] security: externals should be able to read attachements
without having the rights to read ir.config_parameter
2014-08-26 12:55:48 +02:00
Denis Ledoux 80017b04c2 [FIX] security: ir.config_parameter should not be readable by externals 2014-08-26 12:50:04 +02:00
Daniel Dico f880d89cc4 [FIX] sale_order_line: use order date to compute currency instead of current date 2014-08-25 18:04:43 +02:00
Daniel Dico 180c4734a6 [FIX] product_visible_discount: use order date to compute currency instead of current date 2014-08-25 17:53:47 +02:00
Denis Ledoux 9b3f3fecfe [FIX] hr_holidays: employees cannot approve their holidays
Nor modify once approved

It wasn't possible for employees to approve their holidays themself, thanks to the GUI, but this was possible through xmlrpc calls, or when altering the html directly in the browser.
Besides, this was also possible to edit the holiday through the same trick once the holiday validated
2014-08-25 14:51:03 +02:00
Ravish Murari bc3991b4c5 [FIX] board: Do not offer to create dashboard when there is no action
In case we have no defined action (e.g. redirection by python code), adding a dashboard should not be possible as the rendering based on the action.
This patch hides the 'Add to Dashboard' button in search view (opw 611288)
2014-08-25 12:03:12 +02:00
Martin Trigaux 73546f70ca [FIX] point_of_sale: generate bank statement with commerical partner
When a pos session is closed & confirmed, the account.move were generated with the commercial partner except for the bank statement which prevented automatic reconciliation.
This patch uses the commercial partner also for bank statement.
Fixes #1558, #1764
2014-08-22 15:29:23 +02:00
Martin Trigaux b160f99e2d [FIX] fetchmail: do not delete a failing email when using POP
In case of IMAP, the email is simply set as read but in case of POP, the email is deleted. To avoid loosing data (e.g. misconfiguration of server), the email is kept for POP.
Bug lp:1296724, opw 605667
2014-08-22 14:14:56 +02:00
Martin Trigaux 0ab88f54f9 [FIX] ir_model: invalidate cache when adding new fields
When a new ir.model.field is created, add the new field in the fields_by_model (cache of custom fields). This is required as the __init__ method would not retrieve the new field if fields_by_model is already set.
Otherwise, the _columns would not contain the new fields and we could not access it without restarting the server (e.g. the installation of a module adds ir.model.fields and use it in the a view.
2014-08-21 17:24:45 +02:00
Desai Binjal 8fe9f07cac [FIX] note: small bugs 2014-08-21 15:55:23 +02:00
Martin Trigaux 768b3592c2 [FIX] base: wrong model change check
Comparing an id and a browse record will always fail so the exception would have always been raised when changing a model (e.g. updating a module with custom fields).
2014-08-21 14:30:10 +02:00
fka-odoo 20a99ae129 [IMP] account_budget: added date filter in print budget report
Fixes #1743, opw 611307
2014-08-21 11:45:38 +02:00
Denis Ledoux 99ce17cfca [FIX] point_of_sale: report, product_id of line is product_product
product_id column of pos_order_line is a product_product
the left join of l.product_id was done on product_template, instead of product_product

It worked as long as the ids product_product were the same as product_template. Meaning that, if you used variants, this report view was screwed.
2014-08-21 11:20:09 +02:00
Guewen Baconnier d0a0b7d91d [FIX] purchase: skip move if not linked to a purchase order
When this situation happens. the 'cost' is None and the web interface cannot handle this value, provoking a JS error. Thus, prefer to fallback on the standard way to get the cost: based on the current standard price of the product.
Fixes #1032
2014-08-20 15:13:36 +02:00
Martin Ambroz 106cb1ec2b [FIX] base: python 2.6 incompatibility for dictionary comprehension 2014-08-20 10:28:37 +02:00
Sandy Carter 11e4cad9f7 [IMP] auth_oauth: set default 'zocial' css_class
The buttons for new providers needs at least the zocial css class to be seen as button. As the field css_class is not in the default form view, add it by default.
2014-08-19 17:43:09 +02:00
Sébastien BEAU 3b901f0aa0 [FIX] web: ignored readonly attribute on image widget 2014-08-19 15:27:36 +02:00
David Arnold 6164f52ca3 [FIX] account_voucher: wrong type in context
The type 'general' no longer exists on a account.voucher. As in general context, removed the default value on this menu.
Fixes #1261, it produces a traceback in 8.0 where the selection fields are less fault-tolerant.
2014-08-19 11:22:38 +02:00
Martin Trigaux f572b27ec8 [IMP] account_voucher: make the field tax_amount always readonly
The field tax_amount is fieled with onchanges and the compute_tax method. Setting a different value than the one computed by the system may lead to unbalanced move (which is obviously wrong).
In the future, handeling these operations by setting the correct value to the tax accounts would be better.
2014-08-18 17:59:17 +02:00
Martin Trigaux 85b08a75f6 [FIX] account_voucher: avoid error if no partner
The field partner_id is not required on an account.voucher but the validation was failing if none was set (opw 611663).
This patch makes a fallback on the account of the voucher if neither a partner nor a writeoff account is specified.
2014-08-18 17:50:32 +02:00
Thomas Groutars 397e83554b [FIX] product: make sure unlinked product still exists
When uninstalling/updating a module, we may execute unlink method on product.template before product.product. In such cases, the product is already removed after removeing the template (_inherits) and the chained unlink of the product would fail (traceback when browsing).
2014-08-18 10:37:03 +02:00
Denis Ledoux 97d097a2af [FIX] point_of_sale: field date of report.pos.order should be a datetime
The date_order field of the pos.order is a datetime, not a date
As, in report.pos.order, the date field is related to date_order of the pos.order

We usually do not commit fixes altering the model fields structure in 7.0, but this one is retro-compatible, as the database structure won't change
2014-08-14 18:01:37 +02:00
Denis Ledoux dcd26acccf [FIX] web: do not focus if the focus_field is not a field
Sometimes, focus_field could be a button, and in such cases, we should not focus on it

opw-612045
2014-08-14 17:33:59 +02:00
Rifakat fa27d28494 [FIX] stock: inventory lines with no production lot: compare with correct stock level
Inventory lines without production lot number should
be compared with the stock level of products without
a production lot. Otherwise the final result of a
validated inventory is wrong as soon as there are
lines with and without production lot for the same
product.

Adds corresponding regression test.

Fixes https://bugs.launchpad.net/openobject-addons/+bug/1008099
Manual rebase of #1658, courtesy of Numerigraphe
2014-08-14 16:51:37 +02:00
Olivier Dony 971ffa3db1 [FIX] account: reconcile: no useless revalidation
Avoid revalidating the complete account moves
that contain the lines being reconciled.
The reconciliation does not change the validity
of those moves anyway.
This represents a very important speed up of
reconciliation when moves with several hundred
lines are involved.
2014-08-14 16:51:37 +02:00
Martin Trigaux deacba0ed6 [IMP] base: no default domain for partner's title
The title field should not have a domain by default.
When a new record is created or the 'is company' field is changed, the onchange_type is triggered to restrict the domain accordingly to is_company field.
When an existing record is modified, there will have no domain on title field. It's not ideal but at least companies will be able to change the title without the need to modify twice the field is_company.
Fixes #1713
2014-08-14 12:00:27 +02:00
Olivier Dony 85d2b45aaa [I18N] Update 7.0 translations with latest changes on Launchpad
See also https://github.com/odoo/odoo/wiki/GitHub-Transition#translations
2014-08-14 03:38:58 +02:00
Olivier Dony 96c36e895c [I18N] Update all 7.0 translation templates with latest terms and annotations
Total new terms: 168
Total deleted terms: 95
Total identical terms: 16329
(Some modules skipped, typically all l10n_* modules)
2014-08-14 02:24:24 +02:00
Olivier Dony 69eef5ac8d [FIX] tools.translate: addons path resolution failed with duplicates
When the addons_path config contained the
default path, the system was working with
an empty addons_path in the middle of the
other paths. This empty one matched for all
files, making all files appear to belong to
the root path component, e.g. `home` if the
root path is in /home.
Refactored a bit to avoid duplicates and
redundant path calculations.
2014-08-14 02:07:59 +02:00
Vo Minh Thu 680214c47e [FIX] tools.translate: when loading entries from a PO file, use also the POT.
On Launchpad, as commented on bug 933496, PO entries (and their comments) are
shared between series. This mean that e.g. the 7.0 series can have the wrong
`reference` comments (those beginning with #:) as they would be copied from say
the trunk series. Those `reference` comments are used to import translations
and look them up.

This patch adds a few lines of code to tools.translate so that targets
defined in the POT `reference` comments are used in addition to those from the
PO file.

Also adds a test module to validate the new behavior.

This patch stems from:
 - the 6.1 branch by Vo Minh Thu:
    https://code.launchpad.net/+branch/~openerp-dev/openobject-server/6.1-fix-po-targets-933496-vmt
 - the 7.0 port by Numerigraphe:
    https://code.launchpad.net/~numerigraphe-team/openobject-server/7.0-fix-po-targets-933496-vmt
2014-08-13 23:07:40 +02:00
Olivier Dony 23cffab1f8 [FIX] portal_sale: remove more access rights, add pricelist access
Pricelist access is necessary for being able to read
the unit price of sale order lines, and does not
pose major security risks, as it does not permit
reading the actual pricelist definition.
2014-08-13 17:20:49 +02:00
Olivier Dony d03ae8980a [FIX] portal_sale: remove un-necessary access rights, improve rules
Portal access rights need to be associated with
security rules, or not granted at all, as soon
as they grant access to non-trivial data.
2014-08-13 16:46:42 +02:00
Martin Trigaux bceb278199 [FIX] base: revert 19e401a for title on res.partner form
The title of the partner is restricted with a context that will change in the onchange_type. Having twice the same field will not work well.
Remove the invisible attribute as the domain is handled by the domain.
2014-08-13 15:04:54 +02:00
Samus CTO 1a7c8953fe [IMP] calculating nextcall datetime of a cron SHOULD use the cron's user 2014-08-13 14:58:55 +02:00
Samus CTO 7f88681186 [FIX] context_timestamp MUST return a "timezone aware" timestamp 2014-08-13 14:58:55 +02:00
Denis Ledoux 8276fb5853 [FIX] export: add the context in the export
In some cases, the data dispalyed in a list depends on the context
This context needs to be passed to the export method, so the exported data reflects correctly the data from the list view
2014-08-13 14:52:01 +02:00
Olivier Dony 6b8af73179 [FIX] account.invoice: payments can never be shown to portal users, but residual might be needed
The residual amount is typically needed to render the
online payment forms (payment acquirers).

Payments on the other hand rely on account.move.line,
something that portal users should never be allowed to read.
Removing the field from the view by setting a model-level
group permission ensures they will not see an error.
2014-08-13 12:38:38 +02:00
Olivier Dony f2788afe92 [FIX] portal_sale: browse data for payment acquirer form with superuser ID
The payment form needs to be rendered for non-employee
users, and may require accessing extra financial data
not available for those users.
2014-08-13 11:50:04 +02:00
Olivier Dony 18fe7abcc6 [FIX] account_followup: avoid crashing when a move line has no ref 2014-08-13 11:45:59 +02:00
Denis Ledoux 60ab6f111e [FIX] web: on switch form (from list & kanban) do not load record if empty dataset 2014-08-12 17:45:05 +02:00
Ruchir Shukla b2f1c764cd [FIX] account_anglo_saxon: avoid duplication of price difference lines
When computing the price difference lines, in move_line_get of account_anglo_saxon, we loop on the result of super call for each lines (n * n times) to compute the price difference.
The product_id was used to match the returned line and the original invoice line. This was wrong as we could get several lines with the same product_id (and then get n * n price difference lines).
This patch adds the line id to the result of move_line_get (from account) so that account_anglo_saxon can filter more efficiently and only get one price difference per invoice line.
Fixes #704
2014-08-12 17:30:49 +02:00
Martin Trigaux 7a50b3b057 [FIX] web: missing self initialisation
The self is needed in the _value() method below, opw 608878
2014-08-12 16:08:30 +02:00
Denis Ledoux 0d22a34fa9 [FIX] portal_claim: create claim with no partner_id
If partner_id is False, do not try to name_get

This fix is related to the rev 095be21ab1
2014-08-12 14:13:44 +02:00
Denis Ledoux 245bb4ebdf [FIX] mail: to/from/reply-to addresses formated according to RFC2822
Use formataddr method from email.utils lib, which do the job correctly
2014-08-12 13:40:45 +02:00
Denis Ledoux 2abddd5311 [FIX] l10n_be_coda: set a meaningful filename default value 2014-08-12 12:58:38 +02:00
Denis Ledoux 3609ba10f2 [FIX] procurement: refactor scheduler so it continues even if a procurement failed
If the mrp scheduler fails during the treatment of a procurement (due to a postgresql error, like an update lock), we let it try the other procurements, instead of stopping at the first procurement which fails.
Besides, we retry to treat the procurements which failed, until the list of the remaining procurements is always the same (meaning something is wrong and block the procurements treatment).
2014-08-12 11:02:15 +02:00