Commit Graph

57738 Commits

Author SHA1 Message Date
Somesh Khare cce70fd4c9 [FIX] document: display Attachment(s) menu only on form view
The attachment menu (list and add) has no effect in tree view (not supporting multi-items upload and display), the menu should then only be displayed in these view (opw 612534)
2014-09-04 14:47:06 +02:00
Denis Ledoux 5872c2485d [FIX] stock: on partial picking, do no open a new window action if not needed
This is related to rev. dd4d72d

Not opening a new window action allows to keep the current list of stock picking being threated, and to use the next an previous arrow of the forom view of the web client.
2014-09-04 12:28:16 +02:00
Denis Ledoux 73072272de [FIX] mrp: do not reset back stock moves to confirm
For instance, setting a BOM Phantom with:
Finished product: stockable, MTO Manufacture
Components: stockable, MTS, Buy. Inventory set to 1000
Stock moves of components are directly set to assigned once the procurement confirmed thanks to JIT
The stock moves should not be set back to confirmed after they have been assigned
2014-09-03 18:25:19 +02:00
Olivier Dony c0d838ddb3 [IMP] web: extra comments to explain commit 57b4860
Added some cryptic comments so we remember a bit
why we have a complicated dance with on_close.
Basically we do not want to reload the
original form view until the last popup is closed,
in the case where several wizard (steps) are opened
one after the other.
2014-09-02 19:44:21 +02:00
Denis Ledoux c77c3f934c [FIX] account_payment: lin2bank correct fallback condition 2014-09-02 18:43:22 +02:00
Denis Ledoux 57b48602fb [FIX] web: chain close action on wizard confirm
If a wizard has several steps, or laucnh a second wizard, the view from where has been loaded the initial wizard is finally reloaded
2014-09-02 17:32:37 +02:00
Anael Closson 0bee015dd6 [FIX] mail: more robust parsing of In-Reply-To/References (OPW 608919)
When parsing incoming messages, ignore white-space around
In-Reply-To headers, and extract message-id items inside
the References header using a regex.
This actually serves as a workaround for broken MTAs
mangling References (such as outlook.com nesting past ones
with commas, violating RFC2822).

Closes #516 as a manual rebase.
2014-09-01 13:51:08 +02:00
Denis Ledoux 18d365ce05 "[REVERT][FIX] point_of_sale: field date of report.pos.order should be a datetime"
This reverts commit 97d097a2af.

As explained in the commit comments (on Github), this patch leads to an infinite loop in 7.0, the filter of the pos orders report using the '=' operator in its domain, which is not available for datetime fields, but is for date fields.

This should not be forward ported to newer release (saas-3)
2014-08-29 20:40:31 +02:00
Denis Ledoux 8044a37b3a [FIX] l10n_ma: proper chart of account name 2014-08-29 15:46:36 +02:00
Christophe Simonis 15ee4d83c9 [FIX] email_template: remove group restriction on field mail.compose.message.template_id
This was added as a security check, but access to this field is need by the wizard itself.
As non employee users can't read/create email templates, this will not be problematic
2014-08-28 19:04:14 +02:00
Ravi Gohil df5633dcab [FIX] account: avoid date and cache issues
Explicitely refresh invoice browse_record(...) in order to have correct 'date' in account.move.
Use context_today() date instead of time.strftime() for date_invoice. (opw 611210)
2014-08-27 15:03:47 +02:00
Denis Ledoux 362221b6f5 [FIX] resource: security, resource not readable by externals 2014-08-26 18:10:14 +02:00
Denis Ledoux 1f4f0c0768 [FIX] email_template: security, email_template no rights for externals 2014-08-26 17:32:04 +02:00
Denis Ledoux 3f7f2a51fa [FIX] security: remove read access on company critical fields 2014-08-26 15:35:47 +02:00
Denis Ledoux 53582c2ea6 [FIX] security: res.groups should be readable by admins only 2014-08-26 13:31:41 +02:00
Denis Ledoux 80017b04c2 [FIX] security: ir.config_parameter should not be readable by externals 2014-08-26 12:50:04 +02:00
Daniel Dico f880d89cc4 [FIX] sale_order_line: use order date to compute currency instead of current date 2014-08-25 18:04:43 +02:00
Daniel Dico 180c4734a6 [FIX] product_visible_discount: use order date to compute currency instead of current date 2014-08-25 17:53:47 +02:00
Denis Ledoux 9b3f3fecfe [FIX] hr_holidays: employees cannot approve their holidays
Nor modify once approved

It wasn't possible for employees to approve their holidays themself, thanks to the GUI, but this was possible through xmlrpc calls, or when altering the html directly in the browser.
Besides, this was also possible to edit the holiday through the same trick once the holiday validated
2014-08-25 14:51:03 +02:00
Ravish Murari bc3991b4c5 [FIX] board: Do not offer to create dashboard when there is no action
In case we have no defined action (e.g. redirection by python code), adding a dashboard should not be possible as the rendering based on the action.
This patch hides the 'Add to Dashboard' button in search view (opw 611288)
2014-08-25 12:03:12 +02:00
Martin Trigaux 73546f70ca [FIX] point_of_sale: generate bank statement with commerical partner
When a pos session is closed & confirmed, the account.move were generated with the commercial partner except for the bank statement which prevented automatic reconciliation.
This patch uses the commercial partner also for bank statement.
Fixes #1558, #1764
2014-08-22 15:29:23 +02:00
Martin Trigaux b160f99e2d [FIX] fetchmail: do not delete a failing email when using POP
In case of IMAP, the email is simply set as read but in case of POP, the email is deleted. To avoid loosing data (e.g. misconfiguration of server), the email is kept for POP.
Bug lp:1296724, opw 605667
2014-08-22 14:14:56 +02:00
Desai Binjal 8fe9f07cac [FIX] note: small bugs 2014-08-21 15:55:23 +02:00
fka-odoo 20a99ae129 [IMP] account_budget: added date filter in print budget report
Fixes #1743, opw 611307
2014-08-21 11:45:38 +02:00
Denis Ledoux 99ce17cfca [FIX] point_of_sale: report, product_id of line is product_product
product_id column of pos_order_line is a product_product
the left join of l.product_id was done on product_template, instead of product_product

It worked as long as the ids product_product were the same as product_template. Meaning that, if you used variants, this report view was screwed.
2014-08-21 11:20:09 +02:00
Guewen Baconnier d0a0b7d91d [FIX] purchase: skip move if not linked to a purchase order
When this situation happens. the 'cost' is None and the web interface cannot handle this value, provoking a JS error. Thus, prefer to fallback on the standard way to get the cost: based on the current standard price of the product.
Fixes #1032
2014-08-20 15:13:36 +02:00
Sandy Carter 11e4cad9f7 [IMP] auth_oauth: set default 'zocial' css_class
The buttons for new providers needs at least the zocial css class to be seen as button. As the field css_class is not in the default form view, add it by default.
2014-08-19 17:43:09 +02:00
Sébastien BEAU 3b901f0aa0 [FIX] web: ignored readonly attribute on image widget 2014-08-19 15:27:36 +02:00
David Arnold 6164f52ca3 [FIX] account_voucher: wrong type in context
The type 'general' no longer exists on a account.voucher. As in general context, removed the default value on this menu.
Fixes #1261, it produces a traceback in 8.0 where the selection fields are less fault-tolerant.
2014-08-19 11:22:38 +02:00
Martin Trigaux f572b27ec8 [IMP] account_voucher: make the field tax_amount always readonly
The field tax_amount is fieled with onchanges and the compute_tax method. Setting a different value than the one computed by the system may lead to unbalanced move (which is obviously wrong).
In the future, handeling these operations by setting the correct value to the tax accounts would be better.
2014-08-18 17:59:17 +02:00
Martin Trigaux 85b08a75f6 [FIX] account_voucher: avoid error if no partner
The field partner_id is not required on an account.voucher but the validation was failing if none was set (opw 611663).
This patch makes a fallback on the account of the voucher if neither a partner nor a writeoff account is specified.
2014-08-18 17:50:32 +02:00
Thomas Groutars 397e83554b [FIX] product: make sure unlinked product still exists
When uninstalling/updating a module, we may execute unlink method on product.template before product.product. In such cases, the product is already removed after removeing the template (_inherits) and the chained unlink of the product would fail (traceback when browsing).
2014-08-18 10:37:03 +02:00
Denis Ledoux 97d097a2af [FIX] point_of_sale: field date of report.pos.order should be a datetime
The date_order field of the pos.order is a datetime, not a date
As, in report.pos.order, the date field is related to date_order of the pos.order

We usually do not commit fixes altering the model fields structure in 7.0, but this one is retro-compatible, as the database structure won't change
2014-08-14 18:01:37 +02:00
Denis Ledoux dcd26acccf [FIX] web: do not focus if the focus_field is not a field
Sometimes, focus_field could be a button, and in such cases, we should not focus on it

opw-612045
2014-08-14 17:33:59 +02:00
Rifakat fa27d28494 [FIX] stock: inventory lines with no production lot: compare with correct stock level
Inventory lines without production lot number should
be compared with the stock level of products without
a production lot. Otherwise the final result of a
validated inventory is wrong as soon as there are
lines with and without production lot for the same
product.

Adds corresponding regression test.

Fixes https://bugs.launchpad.net/openobject-addons/+bug/1008099
Manual rebase of #1658, courtesy of Numerigraphe
2014-08-14 16:51:37 +02:00
Olivier Dony 971ffa3db1 [FIX] account: reconcile: no useless revalidation
Avoid revalidating the complete account moves
that contain the lines being reconciled.
The reconciliation does not change the validity
of those moves anyway.
This represents a very important speed up of
reconciliation when moves with several hundred
lines are involved.
2014-08-14 16:51:37 +02:00
Olivier Dony 85d2b45aaa [I18N] Update 7.0 translations with latest changes on Launchpad
See also https://github.com/odoo/odoo/wiki/GitHub-Transition#translations
2014-08-14 03:38:58 +02:00
Olivier Dony 96c36e895c [I18N] Update all 7.0 translation templates with latest terms and annotations
Total new terms: 168
Total deleted terms: 95
Total identical terms: 16329
(Some modules skipped, typically all l10n_* modules)
2014-08-14 02:24:24 +02:00
Olivier Dony 23cffab1f8 [FIX] portal_sale: remove more access rights, add pricelist access
Pricelist access is necessary for being able to read
the unit price of sale order lines, and does not
pose major security risks, as it does not permit
reading the actual pricelist definition.
2014-08-13 17:20:49 +02:00
Olivier Dony d03ae8980a [FIX] portal_sale: remove un-necessary access rights, improve rules
Portal access rights need to be associated with
security rules, or not granted at all, as soon
as they grant access to non-trivial data.
2014-08-13 16:46:42 +02:00
Denis Ledoux 8276fb5853 [FIX] export: add the context in the export
In some cases, the data dispalyed in a list depends on the context
This context needs to be passed to the export method, so the exported data reflects correctly the data from the list view
2014-08-13 14:52:01 +02:00
Olivier Dony 6b8af73179 [FIX] account.invoice: payments can never be shown to portal users, but residual might be needed
The residual amount is typically needed to render the
online payment forms (payment acquirers).

Payments on the other hand rely on account.move.line,
something that portal users should never be allowed to read.
Removing the field from the view by setting a model-level
group permission ensures they will not see an error.
2014-08-13 12:38:38 +02:00
Olivier Dony f2788afe92 [FIX] portal_sale: browse data for payment acquirer form with superuser ID
The payment form needs to be rendered for non-employee
users, and may require accessing extra financial data
not available for those users.
2014-08-13 11:50:04 +02:00
Olivier Dony 18fe7abcc6 [FIX] account_followup: avoid crashing when a move line has no ref 2014-08-13 11:45:59 +02:00
Denis Ledoux 60ab6f111e [FIX] web: on switch form (from list & kanban) do not load record if empty dataset 2014-08-12 17:45:05 +02:00
Ruchir Shukla b2f1c764cd [FIX] account_anglo_saxon: avoid duplication of price difference lines
When computing the price difference lines, in move_line_get of account_anglo_saxon, we loop on the result of super call for each lines (n * n times) to compute the price difference.
The product_id was used to match the returned line and the original invoice line. This was wrong as we could get several lines with the same product_id (and then get n * n price difference lines).
This patch adds the line id to the result of move_line_get (from account) so that account_anglo_saxon can filter more efficiently and only get one price difference per invoice line.
Fixes #704
2014-08-12 17:30:49 +02:00
Martin Trigaux 7a50b3b057 [FIX] web: missing self initialisation
The self is needed in the _value() method below, opw 608878
2014-08-12 16:08:30 +02:00
Denis Ledoux 0d22a34fa9 [FIX] portal_claim: create claim with no partner_id
If partner_id is False, do not try to name_get

This fix is related to the rev 095be21ab1
2014-08-12 14:13:44 +02:00
Denis Ledoux 245bb4ebdf [FIX] mail: to/from/reply-to addresses formated according to RFC2822
Use formataddr method from email.utils lib, which do the job correctly
2014-08-12 13:40:45 +02:00
Denis Ledoux 2abddd5311 [FIX] l10n_be_coda: set a meaningful filename default value 2014-08-12 12:58:38 +02:00