Commit Graph

11 Commits

Author SHA1 Message Date
Xavier Morel 3049760fe6 [FIX] race condition in ir.ui.menu leading to incomplete menus in web client
See bug, issue occurs with variable frequency when changing between
simple and extended views in a user account (non-administrator at
least): saving the user account leads to a clearing of the menu cache,
this is followed by two search/read in parallel (one to get the full
menu listing and one to get the list of applications for the home
page), which leads to ir_ui_menu.search (thus
ir_ui_menu._filter_visible_menus) being called concurrently, and this
apparently somehow wrecks havoc on some browse_record's caches
yielding to incoherent behaviors (menus which do have children in db
not having children in the browse_record, and thus being pruned from
the list of menus).

Putting a big lock around 1. clear_cache (just in case) and
2. _filter_visible_menu (to make cache-filling essentially atomic)
seems to solve the issue or at least make it disappear, ideally more
time should be spent understanding what breaks in browse_record.

A reentrant lock is needed as _filter_visible_menu may recurse when
accessing e.g. a menu's child_id (which yield a
search([parent_id=menu.id]) and thus a _filter_visible_menu)

lp bug: https://launchpad.net/bugs/920332 fixed

bzr revid: xmo@openerp.com-20120125115823-rpu03zdv14t11lp3
2012-01-25 12:58:23 +01:00
Olivier Dony bdce754108 [IMP] cleanup deprecated method=True param for function fields
bzr revid: odo@openerp.com-20120104133027-oaydmngk2dfc22mk
2012-01-04 14:30:27 +01:00
Naresh (OpenERP) 2d67a75338 [FIX]: WARNING:orm:No such field(s) in model ir.values: object: This was probably missed out to be removed with the improvements made at 3560.1.8 odo@openerp.com-20110905141058-xa01o77l1rto6hg9
bzr revid: nch@tinyerp.com-20111124085813-28fbguyklybdq213
2011-11-24 14:28:13 +05:30
Olivier Dony 52f6e15e5c [FIX] ir.ui.menu: typo during merge of simplified cache
bzr revid: odo@openerp.com-20110901143038-dpuehbd8p1e0o3qz
2011-09-01 16:30:38 +02:00
Antony Lesuisse 8d31082408 [FIX] ir.model.access check use positional args
bzr revid: al@openerp.com-20110824211948-gvtc7uv9e3oeeo3e
2011-08-24 23:19:48 +02:00
Xavier Morel cbbae67165 [ADD] possibility to use a client action in a menu
bzr revid: xmo@openerp.com-20110701130517-p8dz909jho2658vk
2011-07-01 15:05:17 +02:00
Vo Minh Thu 545a438c03 [REF] openerp.modules
- for the moment it is a copy of openerp.addons

bzr revid: vmt@openerp.com-20110420152718-eok61oule6p2x58z
2011-04-20 17:27:18 +02:00
Vo Minh Thu a931e398bf [REF] consistent, grepable ir.values object naming.
bzr revid: vmt@openerp.com-20110516150534-2524fn6587jir72m
2011-05-16 17:05:34 +02:00
Vo Minh Thu c666a297cf [REF] ir_ui_menu: _get_image_icon simplified, more general.
- code actually from chs a.k.a. Christophe (OpenERP) a.k.a. kangol.

bzr revid: vmt@openerp.com-20110512123752-l1gpv6qr193wt4yf
2011-05-12 14:37:52 +02:00
Olivier Dony 556f36b5d5 [FIX] ir.ui.menu: load web icons for all menus, not just top levels ones
This is useful for portal, where a subtree of the menus
is used as top-level menu for portal users.

bzr revid: odo@openerp.com-20110411211835-zw2kazf63ae4qrr1
2011-04-11 23:18:35 +02:00
Vo Minh Thu f8572e5c60 [IMP] openerp python module.
- Some logging code moved from netsvc.py to loglevels.py
- Changed imports to use the new openerp module
- config and netsvc initialization calls move to openerp-server.py
- Moved openerp-server.py outside the old bin directory
- Some imports in tools moved inside the methods to break mutual-dependencies

bzr revid: vmt@openerp.com-20110207125723-ooee7d7ng5elmkso
2011-02-07 13:57:23 +01:00