Commit Graph

1394 Commits

Author SHA1 Message Date
Denis Ledoux a32e989fba [FIX] web: save date(time) field value on key enter in editable list
In editable list, on keypress enter, the _next method is called, saving the current line and starting the edition of the next one
The _next is triggered before the date(time) field change event, and, therefore, the saved value of the date(time) field is the old one
2014-06-17 12:56:13 +02:00
Christophe Simonis ab9ac783db [FIX] web: many2many field handle "no_create" option 2014-06-05 13:46:53 +02:00
Mohammed Shekha 26cb208903 [FIX]Refixed the issue of o2m record duplication 2014-05-27 19:35:09 +05:30
Mohammed Shekha 477fa85e55 [FIX]Fixe the issue o2m record duplication. 2014-05-27 10:10:06 +05:30
Martin Trigaux fa4e285be7 [FIX] FieldMany2One: avoid error when saving changes in popup from a related fields (opw 606601)
bzr revid: mat@openerp.com-20140418092033-mvqng3thuy61kfoq
2014-04-18 11:20:33 +02:00
Denis Ledoux 7c668d8eac [FIX] web: double click on save button was trying to save the data two times if there is some latency, event target should be used instead of delegate target
bzr revid: dle@openerp.com-20140417101217-3fwnm76qne6f1vwk
2014-04-17 12:12:17 +02:00
Denis Ledoux f928ba4f10 [FIX] web: double click on save button was trying to save the data two times if there is some latency
bzr revid: dle@openerp.com-20140417101000-6gtyxntkm5d7zcoy
2014-04-17 12:10:00 +02:00
Mohammed Shekha 91930b470d [FIX]Fixed the issue of reference field throws traceback that view is undefined, the reason is that reference field passing DefaultFieldManager while creating instance of many2one widget and DefaultFieldManager is eventually extending instance.web.widget not instance.web.form.FormWidget and hence DefaultFieldmanager will nto having view attribute, instead of calling self.view.do_onchange, trigger changed_value which is going to do the same job.
bzr revid: msh@tinyerp.com-20140416083857-sug0k4a28nkvgg27
2014-04-16 14:08:57 +05:30
Mohammed Shekha f9d143c216 [FIX]Fixed the issue of duplicated one2many lines, weired behavior when you add one2many line and then add another line withour filling required field and then click on save, then remove added one2many line for which we didn't filled required data and then save it, you will get duplicated lines.
bzr revid: msh@tinyerp.com-20140403070844-6ogpdursukue2zoh
2014-04-03 12:38:44 +05:30
Denis Ledoux 649ef3ed21 [REVERT] 4164 revid:dle@openerp.com-20140326113036-g9yv3jj6yetwxvg8: this fix actually works in saas-3, but not in 7.0, as search_read method is not part of the orm
bzr revid: dle@openerp.com-20140326123513-jkful2m1n2zjgdmv
2014-03-26 13:35:13 +01:00
Denis Ledoux 162ad1c0f1 [FIX] web: on record reload (form & list view), use search_read instead of read, to check if the user can still read the record (security rules)
bzr revid: dle@openerp.com-20140326113036-g9yv3jj6yetwxvg8
2014-03-26 12:30:36 +01:00
Martin Trigaux 53922c9593 [FIX] pager: revert of revision 4159, the pager was disapearing when going in editable mode (which is more problematic that the issue rev 4159 was trying to fix)
bzr revid: mat@openerp.com-20140314132854-8ie8sosx9xecuww4
2014-03-14 14:28:54 +01:00
Martin Trigaux 08e07af590 [FIX] pager: do not try to toggle the visibility if the pager do not exists yet
bzr revid: mat@openerp.com-20140314112709-0sqq6tcpmza34q1e
2014-03-14 12:27:09 +01:00
Martin Trigaux 71d8f8f1c4 [FIX] pager: show the pagger earlier to avoid slow loading to mix list and form pagers when fast switching
bzr revid: mat@openerp.com-20140313123811-ej7lu53xp51kn6gu
2014-03-13 13:38:11 +01:00
Xavier ALT c033e5a535 [FIX] web: on SearchPopup creation concat build context even if we have initial_ids
On SearchPopupCreation, if we have initial_ids - 1st search_read() will be
  missing custom context defined on the field.

  1. defined view like this: <field name='my_many2one_field_id' context="{'test': 1}"/>
  2. in we expand the list of available item, name_search() has 'test' in context
  3. in we click on 'Search More', search_read() is missing 'test' in context
  4. if we change filter add/remove item, search_read() will have 'test' in context

  Step 3. is wrong, should also have 'test' in context

lp bug: https://launchpad.net/bugs/1209295 fixed

bzr revid: mat@openerp.com-20140311091522-03imwd5rj3rmwapl
2014-03-11 10:15:22 +01:00
Martin Trigaux 618c8b9100 [FIX] quick create: do not add the id in the form if the form is readonly (eg: clicking on save button will make the form uneditable)
bzr revid: mat@openerp.com-20140307141257-rvusvzm6oq3tel51
2014-03-07 15:12:57 +01:00
Mohammed Shekha (OpenERP) a8943b416a [FIX]Web, Statusbar: Fixed the issue of statubar in chrome is aligned, it is aligned in inline block.
bzr revid: msh@openerp.com-20140213115556-irdodahpw0atgy5u
2014-02-13 17:25:56 +05:30
Martin Trigaux b75c52f3ed [IMP] reference fields: display a more user-friendly window title when open a chosen many2one record in reference field
bzr revid: mat@openerp.com-20140206102409-4lbx7ofsgz8speni
2014-02-06 11:24:09 +01:00
Martin Trigaux 263693e44e [FIX] search: add delay of 250us (was 0) on autocomplete fields in search bar and m2o fields.
This avoids making a search request for each keypressed

bzr revid: mat@openerp.com-20140120160147-q7lg4j93c836ec44
2014-01-20 17:01:47 +01:00
Denis Ledoux 6109102e91 [FIX] web: view_form.js, allow press enter to break line in fieldtextwidget
bzr revid: dle@openerp.com-20140115120844-1z0pbh9pc63tllce
2014-01-15 13:08:44 +01:00
Martin Trigaux 3f4c637674 [IMP] view_form: do not display hugly error message when name_get returns no value but more helpful message (eg: bad default value returns wrong id)
bzr revid: mat@openerp.com-20140114145720-r3lg0qjezqj4p3i1
2014-01-14 15:57:20 +01:00
Xavier Morel 1b76c66930 [MERGE] fixes for non-direct IME
bzr revid: xmo@openerp.com-20131218152626-kexq1wudvjwnh962
2013-12-18 16:26:26 +01:00
Martin Trigaux ad7951214c [MERGE] [FIX] One2ManyListView: reload line data without saving it when m2o record has changed in edition mode (eg: changing product name in sale order line) (opw #600224)
bzr revid: mat@openerp.com-20131211105009-iylczcepd3a0e61l
2013-12-11 11:50:09 +01:00
Michel Meyer 68aac8e855 [FIX] events handling ordering courtesy of Michel Meyer
lead to errors during the validation of rows in list o2ms.

See https://bugs.launchpad.net/openerp-web/+bug/1182101/comments/20
for an extensive description of the events and issue.

bzr revid: xmo@openerp.com-20131209153519-n05bdx15t75dh7gf
2013-12-09 16:35:19 +01:00
Xavier Morel b4c121db71 [FIX] bad interaction of editable list with IME
IME are ways to input language which can't trivially map to a keyboard
(e.g. CJK language) with a standard-ish keyboard. For japanese IME
this is done by entering text phonetically: text is entered in romaji
and automatically converted to hiragana (or katakana) when it matches
the transcription a japanese syllable (~phoneme?) e.g. to (と). The
text is then split and reprocessed with sequences of hiragana being
converted to kanji (or not), and the possibility to pick the right
kanji when multiple kanji match e.g. for "Tokyo" toukyou -> とうきょう
-> 東京.

But to do the edition, keyboard keys are used. For the japanese IMEs
(tested on Windows, OSX and Linux) [Space] will do the initial
conversion from kana to kanji (and allow selecting an other conversion
or a different kana split) and [Return] will validate the current
conversion (removing the underline marking "unvalidated" kana or kanji
groups).

And that's where the problem hit: IME + browser combinations may or
may not suppress part of all of the event. Firefox will trigger a
keydown of the key which "starts" IME input (e.g. "t") and will
trigger a keyup for the validation key (return), except on Linux where
the initial keydown is suppressed. Inbetween these, it will fire no
keydown, keyup or keypress event but will fire input events (at least
on an input element) every time the displayed text changes.

Meanwhile webkit browsers will, for each press on the keyboard during
IME,

* trigger a keydown with the keyCode 229
* trigger a keyup event with the keycode of the key which was actually
  hit
* trigger input events every time the displayed text changes

This include meta-operation uses of [Space] and [Return].

MSIE has the same behavior (including triggering the input event), but
the keydown event is augmented with ``key`` and ``char`` attributes
providing the character matching the key hit to trigger the change.

Although the triggering of the input even is useless for the purpose
of the editable list (especially here, the purpose of validating a
list row with [Return] one fact stands out: keypress is never
triggered during IME operations, hitting the [Return] key outside of
IME will trigger keydow, keypress, keyup but doing so during IME will
only trigger the first and last.

Thus by changing the binding from keyup (return) to keypress (return)
for a line validation, spurious validation during IME text entry
should be avoided. This seems to work correctly on MSIE (Windows),
Firefox (Windows, OSX, Linux), Chrome (Windows, OSX, Linux) and Safari
(OSX), after testing in IE9, IE10, Chrome 31, Firefox 25 and Safari 7,
and a quick test on a task's o2m did not reveal any regression.

note: not all differences between various browser/os combinations were
inspected in details, there may well be further differences which were
not noticed or not relevant to this precise issue.

bzr revid: xmo@openerp.com-20131206124431-q4a9l1gn9wjtmlvz
2013-12-06 13:44:31 +01:00
Mohammed Shekha (OpenERP) b3391cd7fe [FIX]Web: Fixed the issue of immediate update of many2one field when many2one object name has been changed from follow button popup, reloaded the record from database forcefull to update dataaset, do not call form-blur when follow button is clicked, also do not evict record when record is still not created.
bzr revid: msh@openerp.com-20131203123856-gce4li1igo9k1mak
2013-12-03 18:08:56 +05:30
Christophe Simonis 8721307dae [IMP] web: avoid double reload() when clicking on a button on a editable form view.
bzr revid: chs@openerp.com-20131120185337-w8857fmwosa36r4d
2013-11-20 19:53:37 +01:00
Martin Trigaux 8c3cdce539 [MERGE] view form: reduce the number of result in 'search more' view opening to 160 records (performances improvement, not filtering every possible record) (opw 593963)
bzr revid: mat@openerp.com-20131113082806-me6uy7cjj6holn56
2013-11-13 09:28:06 +01:00
niv-openerp ffe8490aef Enabled sort in o2m
bzr revid: nicolas.vanhoren@openerp.com-20131010091125-0t1v8wmkrn8bnc5y
2013-10-10 11:11:25 +02:00
Martin Trigaux cd99b9ffac [MERGE] [FIX] reload form if button has option reload_on_button
bzr revid: mat@openerp.com-20130821085342-8k6q1d2886tmwffm
2013-08-21 10:53:42 +02:00
Vidhin Mehta 21cc22b9e9 [IMP]check parent is exist or not.
lp bug: https://launchpad.net/bugs/1202120 fixed

bzr revid: vme@tinyerp.com-20130719090753-t1o4l3pyxd2t5kv9
2013-07-19 14:37:53 +05:30
Christophe Matthieu 27db64f7a0 [FIX] duplicate tag when press tab key two time. Bug 1154057
bzr revid: chm@openerp.com-20130607132203-rcvx6wu820o03tiu
2013-06-07 15:22:03 +02:00
Christophe Matthieu a941c199c1 [FIX] translation button or icon not displayed with html widget. Bug 1179505
bzr revid: chm@openerp.com-20130607101517-zilu97d4akhho72v
2013-06-07 12:15:17 +02:00
Christophe Matthieu 56e4be5d1d [IMP] Improve typos in warning (Grammar mistake, Capitalize title, Typos)
bzr revid: chm@openerp.com-20130607083901-f24fjvo0vi696ll3
2013-06-07 10:39:01 +02:00
Christophe Matthieu b151613f0d [MERGE] pager should be disappear when we create a new record from o2m/m2m popup.
bzr revid: chm@openerp.com-20130606121754-r9xa11ms6do2nrwh
2013-06-06 14:17:54 +02:00
Christophe Matthieu cf0fcaebc9 [MERGE] Onchange must be called for m2o when the popup view is opened an return changes (save button).
bzr revid: chm@openerp.com-20130606094739-3ydlncwv711txo41
2013-06-06 11:47:39 +02:00
Christophe Matthieu 027bf19a7a [IMP] ir_ui_menu: trunk to 7.0 dynamic counters
bzr revid: chm@openerp.com-20130417133438-1g8h8hezbn1vtjj1
2013-04-17 15:34:38 +02:00
Fabien Meghazi 428fdca40a [FIX] FormRenderingEngine: allow class propagation to group cells
bzr revid: fme@openerp.com-20130411163238-qy377cdnn9enax34
2013-04-11 18:32:38 +02:00
Fabien Meghazi 905d13671b [FIX] Do not autofocus Notebook pages by default
bzr revid: fme@openerp.com-20130409122852-f4ikugl83otx8423
2013-04-09 14:28:52 +02:00
Fabien Meghazi 8a20760fc8 [FIX] DataSet#size() problem + FormView#on_button_delete() shall pop breadcrumb on empty dataset
bzr revid: fme@openerp.com-20130404101459-m9q90e32qwf068lw
2013-04-04 12:14:59 +02:00
Fabien Meghazi cea7a7a0ab [FIX] m2o does not use @alive()
lp bug: https://launchpad.net/bugs/1160192 fixed

bzr revid: fme@openerp.com-20130402133952-xz2qaoygg83ks3tx
2013-04-02 15:39:52 +02:00
Fabien Meghazi c94c81c8ac [FIX] Remove dirty flag on save
lp bug: https://launchpad.net/bugs/1099380 fixed

bzr revid: fme@openerp.com-20130328210718-85lemijdjc79hhea
2013-03-28 22:07:18 +01:00
Mohammed Shekha 8cb9a216f0 [FIX]Refixed the issue of reload whole record from one2many.
bzr revid: msh@openerp.com-20130313051042-4nqv5abjf9odi2bh
2013-03-13 10:40:42 +05:30
niv-openerp e35e199064 [FIX] small error, probably due to refactoring, that disabled feature of form buttons.
The feature was to disable button automatically buttons in unsaved o2m to avoid errors.

lp bug: https://launchpad.net/bugs/1095255 fixed

bzr revid: nicolas.vanhoren@openerp.com-20130312170515-qt74ceqm50uscupu
2013-03-12 18:05:15 +01:00
Mohammed Shekha 1289a23782 [FIX]Fixed the issue of reload whole record when new record is created for one2many from wizard, so by default only that record is reloaded but as wizard creates new record in one2many so we have reload whole record so that one2many reloaded with new record, we already did this with setting options=reload_on_button to true
bzr revid: msh@openerp.com-20130312134748-kpmf0dxz9iyji1v3
2013-03-12 19:17:48 +05:30
Xavier Morel 18eb55643e [FIX] hide form autofocus trying to focus destroyed fields under the rug
lp bug: https://launchpad.net/bugs/1153437 fixed

bzr revid: xmo@openerp.com-20130312132144-o5enjfemuk5zxilz
2013-03-12 14:21:44 +01:00
Xavier Morel ee46eb8015 [FIX] blurring propagation on m2m tag fields
lp bug: https://launchpad.net/bugs/1153492 fixed

bzr revid: xmo@openerp.com-20130312131412-mtcl932of1466n2j
2013-03-12 14:14:12 +01:00
Xavier Morel 3890039735 [FIX] correctly check for o2m listview validity
if an edition has been canceled, don't check the form's content as it
does not matter.

lp bug: https://launchpad.net/bugs/1103507 fixed

bzr revid: xmo@openerp.com-20130312112244-zmt34jydpzge6yof
2013-03-12 12:22:44 +01:00
Xavier Morel 2dff34a18f [FIX] array extra comma
bzr revid: xmo@openerp.com-20130312110520-aym6nspf6mlcvsqe
2013-03-12 12:05:20 +01:00
niv-openerp 3f40cad548 [FIX] problem when o2m and readonly fields, now readonly fields are saved in buffered dataset too
bzr revid: nicolas.vanhoren@openerp.com-20130308104336-u2gslznv24h8n88l
2013-03-08 11:43:36 +01:00