Commit Graph

54 Commits

Author SHA1 Message Date
Martin Trigaux f2cf6ced17 [FIX] mail: encoding of sender name with unicode
When sending an email, both formats 'Name <email>' or '"Name" <email>' can be used for fields 'From', 'To' and others. If the name contains unicode characters, a regex only matching '"Name" <email>' was used to encode the name with RFC2047. That meant that the name was not encoded and eventually dropped, using only the email part.
Instead of using a limited regex, use the parseaddr method from email library.
Fixes lp:1272610, opw 607683
2014-09-10 17:36:00 +02:00
Olivier Dony 130afb812d [FIX] ir.mail.server: improve support for user names with emails
The previous fix in revision 5072 only allowed user names
that contained the exact same emails, but users will do
the wildest things like having `someone@domain.com` as
name but setting their email to `someone@domain2.com`.

This was blocked by our sanity check looking for a single
email in the From header. As this check is only done
in order to provide a better error message, it should
not impact valid cases.
Modifying the check to pass when at least one email
was found should be enough to catch most invalid cases,
without requiring a more advanced analysis of the
header value (the RFCs allows very strange things!)

bzr revid: odo@openerp.com-20130918143807-wqqpqomyu1ppa2ih
2013-09-18 16:38:07 +02:00
Olivier Dony b24e37db63 [FIX] ir.mail_server: be more lenient when validating From address
When a user has their email as name, the system will
construct the From header as "email<email>".
We previously forbade this, because the naive
check only counts the number of emails in
the From header.
We might need to drop that assert or implement
something better in the future.

bzr revid: odo@openerp.com-20130910143809-wu32dkz20es579nv
2013-09-10 16:38:09 +02:00
Christophe Matthieu de9777bf56 [IMP] Improve typos in warning (Grammar mistake, Capitalize title, Typos)
bzr revid: chm@openerp.com-20130607090251-2ym7dx73jdigq93w
2013-06-07 11:02:51 +02:00
Martin Trigaux b8aed2249a [IMP] remove read access to outgoing mail server configuration
forward port of rev 4349 in 6.1

bzr revid: mat@openerp.com-20130521133025-198z6n1nqltcisx2
2013-05-21 15:30:25 +02:00
Olivier Dony 4eac510461 [FIX] ir.mail_server: properly handle the --smtp-ssl command-line option + map it to STARTTLS as a safer default
bzr revid: odo@openerp.com-20130115124058-81kgv0cy9jp96ln4
2013-01-15 13:40:58 +01:00
Olivier Dony ecc56794cd [FIX] ir.mail_server: correct fallback to smtp parameters provided in server config/command-line
bzr revid: odo@openerp.com-20130111161201-3w8o2voiauxyvxzz
2013-01-12 05:12:01 +13:00
Fabien Pinckaers 013af8477f [IMP] mail serveur active
bzr revid: fp@tinyerp.com-20121221195614-pfk4kbmquzmhrgbc
2012-12-21 20:56:14 +01:00
Cecile Tonglet ad8b76de53 [MERGE] From trunk (second time)
bzr revid: cto@openerp.com-20121217144753-1rboqdw01h8yrehj
2012-12-17 15:47:53 +01:00
Xavier Morel d0a377cb1c [FIX] incorrect docstrings or docstring param names not matching actual param names
bzr revid: xmo@openerp.com-20121214130758-a2wp963w4djmb02k
2012-12-14 14:07:58 +01:00
Vo Minh Thu 509a084e79 [IMP] use the openerp namespace.
bzr revid: vmt@openerp.com-20121210152723-mv4dykfu6ip1991h
2012-12-10 16:27:23 +01:00
Xavier Morel 5bd939f0ac [REM] useless intermediate lambdas in default values
bzr revid: xmo@openerp.com-20121102094705-6vcutz0bv4dc0jkl
2012-11-02 10:47:05 +01:00
Jigar Amin - OpenERP 8d00222f8b [FIX] usa fix
bzr revid: jam@tinyerp.com-20120625134414-jfztjo8by5kbgqg0
2012-06-25 19:14:14 +05:30
Jigar Amin - OpenERP 5b339753b1 [FIX] usa fix
bzr revid: jam@tinyerp.com-20120625131158-qeggwyomms20zm1f
2012-06-25 18:41:58 +05:30
Jigar Amin - OpenERP 0473afaca6 [REN] e-mail to email
bzr revid: jam@tinyerp.com-20120625125700-7jr8aeqp2kn9uggu
2012-06-25 18:27:00 +05:30
Jigar Amin - OpenERP abfa5612f5 [USB] renamed e-mail to email *.py
bzr revid: jam@tinyerp.com-20120625123206-2nwfjc9mpbuk4mn1
2012-06-25 18:02:06 +05:30
Olivier Dony 6242bb6a22 [FIX] ir.mail_server: now that server time is UTC, outgoing msg Date header should too
bzr revid: odo@openerp.com-20120316132022-j17inidkutkxclvd
2012-03-16 14:20:22 +01:00
Olivier Dony 972a0a4557 [FIX] ir_mail_server: make attachment filename work properly on GMail
The default Python encoding for mail header parameters
is RFC2231, which produces headers of the form:
  Content-Disposition: attachment; filename*="utf-8abcd%C3%A9.pdf"
This works fine for e.g. Thunderbird but on GMail
such headers appear as `noname`.
We are therefore falling back to RFC2047 encoding
which will instead give something like:
  Content-Disposition: attachment; filename="=?utf-8?b?UmVxdWVzdCf?="

bzr revid: odo@openerp.com-20120316130803-zo4fwuk7h6bq6k54
2012-03-16 14:08:03 +01:00
Olivier Dony e74c011a60 [FIX] ir.mail_server: SMTP user and pass should be passed as bytes to login()
Passing a unicode used to work in Python 2.5 but that
changed in 2.6 due to a change in the hmac module.
In any case the various RFCs that describe such
authentication mechanism do specify that UTF-8 encoded
values should be used, so we should be safe coercing
the user and passsword to UTF-8 bytes strings.
And of course it should not change anything for
the ASCII passwords out there anyway.

For references, see:
- Zope bug https://bugs.launchpad.net/zope.sendmail/+bug/597143
- Python issue http://bugs.python.org/issue5285
- http://tools.ietf.org/html/draft-ietf-sasl-crammd5-10#section-4

bzr revid: odo@openerp.com-20120312174348-iiqfa2toupn3udr3
2012-03-12 18:43:48 +01:00
Christophe Simonis 91b8829050 [FIX] tools.email_send: use correct kwarg
bzr revid: chs@openerp.com-20120306173319-6tmhco83w0we5hl6
2012-03-06 18:33:19 +01:00
Vo Minh Thu f5db1d10ec [IMP] openerp.addons.base: _logger with fully qualified module name.
bzr revid: vmt@openerp.com-20120124114730-24m0ftu1wbowg8a0
2012-01-24 12:47:30 +01:00
Vo Minh Thu b5caa70b83 [IMP] tools: removed some functools functions (they were there for previous python versions).
bzr revid: vmt@openerp.com-20120118114109-txh1cjv503xautty
2012-01-18 12:41:09 +01:00
Raphael Collet 298add20ca [FIX] add missing import
bzr revid: rco@openerp.com-20111201155758-y1tej4pqrupzifs0
2011-12-01 16:57:58 +01:00
Raphael Collet 3343ccbed1 [IMP] add log message when skipping sending email
bzr revid: rco@openerp.com-20111201155248-o284h5r27pjrxbbx
2011-12-01 16:52:48 +01:00
Raphael Collet 9aa1ecbe58 [IMP] indicate tests in current thread, and prevent email sending during tests
bzr revid: rco@openerp.com-20111201153156-2ki7x22evf5ojyrz
2011-12-01 16:31:56 +01:00
Olivier Dony 5823bf1634 [FIX] ir.mail_server: except_osv's signature has changed + care for non-ascii mail errors
bzr revid: odo@openerp.com-20111017145714-36khvwvipuf8cauh
2011-10-17 16:57:14 +02:00
Olivier Dony d13fb7fe7e [MERGE] various bugfixes/improvements (coming from EDI development)
- _original_module is now available on model/browse_records
 - context usage in res.partner.*
 - proper name_search() + default values for res.currency
 - active_model in wkf exec context
 - safe_eval allows try/except/finally
 - yaml_import: !ref {id: xml_id} works
 - ir_mail_server: support for alternative body/subtype
 - default value for web.base.url config parameter
 - consistency rename: Model.*get_xml_id* -> *get_external_id*

bzr revid: odo@openerp.com-20111005100954-c8mbd4kz6kkqaj84
2011-10-05 12:09:54 +02:00
Fabien Pinckaers 346d19862a [IMP] mail server view
bzr revid: fp@tinyerp.com-20111001223402-zh4bmgmihliiic1c
2011-10-02 00:34:02 +02:00
Olivier Dony 0453878cf3 [IMP] ir.mail_server: build_email support for alternative body content
bzr revid: odo@openerp.com-20110930210651-jkkskerjt1fb4s9p
2011-09-30 23:06:51 +02:00
Olivier Dony 623bdb2c9f [FIX] ir.mail_server: care for non-ascii connection error message
bzr revid: odo@openerp.com-20110914120644-u0e2dmo2n146nl97
2011-09-14 14:06:44 +02:00
Olivier Dony ed8d1a9f2f [IMP] ir.mail_server: improve handling of non-ASCII in headers
bzr revid: odo@openerp.com-20110906171746-nnjk6ic0bdlqltcu
2011-09-06 19:17:46 +02:00
Olivier Dony a0639a51a7 [IMP] ir.mail.server: improved tooltips
bzr revid: odo@openerp.com-20110902134831-pvpxeg0k2em975ye
2011-09-02 15:48:31 +02:00
Olivier Dony 973c7b116c [FIX] ir.mail.server: remove debugging statement
bzr revid: odo@openerp.com-20110829125917-xm8s6bkfa1uiw4qh
2011-08-29 14:59:17 +02:00
Olivier Dony d94b4e4348 [IMP] ir.mail_server: global handling of smtplib debug output
bzr revid: odo@openerp.com-20110722144657-kaiinv7kkbq43ls6
2011-07-22 16:46:57 +02:00
Olivier Dony edc12e8fda [FIX] ir.mail_server: cleanup,typos
bzr revid: odo@openerp.com-20110722131608-whc560llbswg5nq0
2011-07-22 15:16:08 +02:00
Olivier Dony 05f20c47a8 [IMP] ir.mail_server: cleanup
bzr revid: odo@openerp.com-20110722103428-n6f95br3xrh88a12
2011-07-22 12:34:28 +02:00
Olivier Dony 92a858d4dc [IMP] ir.mail_server: safer handling of non-ascii mail headers (wip)
bzr revid: odo@openerp.com-20110720163343-3tz7onq6c2ucmezj
2011-07-20 18:33:43 +02:00
Olivier Dony 1c55d35026 [IMP] ir.mail_server: next round of review/cleanup
bzr revid: odo@openerp.com-20110720101822-b7n9kinz8sic1vuw
2011-07-20 12:18:22 +02:00
Olivier Dony 3080ba3452 [IMP] ir.mail_server: another round of cleanup
bzr revid: odo@openerp.com-20110715002809-ryvm27wi4ktv8v49
2011-07-15 02:28:09 +02:00
Harry (OpenERP) bf6cba8a1e [IMP] mail_server: smtp_ssl should be readonly if smtplib is not support SMTP_SSL and improve tooltip
bzr revid: hmo@tinyerp.com-20110520055238-qad1x5stnwucv04i
2011-05-20 11:22:38 +05:30
Harry (OpenERP) 4b2b063aaf [FIX] mail_server: correct docstring of method: pack_message and send_email
bzr revid: hmo@tinyerp.com-20110406050503-2dxlv1xrj4qxrb56
2011-04-06 10:35:03 +05:30
Harry (OpenERP) 6f3e5d049b [IMP] mail_server: In pack_message method, remove argument of debug=False. it is a useless in this method
bzr revid: hmo@tinyerp.com-20110404105347-op0urcs5h1ndmjie
2011-04-04 16:23:47 +05:30
Harry (OpenERP) a65b3dc875 [REVIEW+MERGE] merged work
bzr revid: hmo@tinyerp.com-20110404060015-pku4bh49l0g5eamf
2011-04-04 11:30:15 +05:30
Rifakat Haradwala (Open ERP) d7c1a0dc4c [IMP] : changes in arguments
bzr revid: rha@tinyerp.com-20110331133628-0ahwzhlbah44mpej
2011-03-31 19:06:28 +05:30
Harry (OpenERP) 4dbdabe3d2 [REVIEW] review and refactor code
bzr revid: hmo@tinyerp.com-20110331093342-7glpwdwjko1px44h
2011-03-31 15:03:42 +05:30
Rifakat Haradwala (Open ERP) 707efc0d34 [IMP]: ir_mail_server.py: removed _email_send() and merge with email_send()
bzr revid: rha@tinyerp.com-20110330133331-3r1wpr4pepdont6x
2011-03-30 19:03:31 +05:30
Rifakat Haradwala (Open ERP) 899815c3cd [IMP]: refactored send_email() of ir.mail_server
bzr revid: rha@tinyerp.com-20110330100050-aiuhkmb8je2w1p5b
2011-03-30 15:30:50 +05:30
Rifakat Haradwala (Open ERP) 573431a8ba [IMP] ir_mail_server.py: corrected argument of send_method and did related changes and also removed unused imports
bzr revid: rha@tinyerp.com-20110329115309-q7q02pto691a9nxp
2011-03-29 17:23:09 +05:30
Rifakat Haradwala (Open ERP) e3c85bedf0 [IMP] ir_mail_server.py: improvement in send_email method
bzr revid: rha@tinyerp.com-20110328134850-x6dyw3zzqz4k8m1w
2011-03-28 19:18:50 +05:30
Rifakat Haradwala (Open ERP) 6a76b19d2e [IMP] ir_mail_server.py: implemented onchange for tls and ssl boolean field
bzr revid: rha@tinyerp.com-20110325115702-6066ifi582eztgfq
2011-03-25 17:27:02 +05:30