Commit Graph

452 Commits

Author SHA1 Message Date
Cedric Snauwaert fa2f7b86bf [FIX] product: remove digits_precision from uom factor fields
Remove the hardcoded precision of 12 on factor and factor_inv,
to use the complete natural precision of NUMERIC types,
preserving all significant digits.

e.g. a UoM with a factor_inv of 6.0 used to be computed as:
factor_inv: 6.0 -> factor: 0.166666666667 (1.0/6.0, rounded to 12 digits) -> factor_inv: 5.999999999988 (1.0/factor)
which could lead to errors such 12*0.166666666667 = 2.000000000004 instead of 2.0

Slightly changed the way the ORM handles float fields to allow setting `digits=0`
as a way to explicitly require a NUMERIC value but without enforcing/rounding
the values at the ORM level, i.e. a truly full-precision field.

NUMERIC type has unlimited precision but is less efficient so should not be
used as the default behaviour, which is why we keep float8 as an alternative.

Modified the view to display the product UOM factor with a 5 digits value by default.
This value is for usability purpose only, the field still accepts bigger precision, by
setting the `digits` option on the field in the form view.

This change is safe in a stable series, the `digits=0` alternative is
treated the same as the default `digits=None` everywhere in the framework,
except when creating the database field.
2014-10-22 14:28:34 +02:00
Martin Trigaux 78144410a4 [IMP] product: name_get matching on commercial_partner_id for suppliers
The name_get of a product will use some information (e.g. default_code) based on the supplier.
The matching of the supplier should use the commercial_partner_id in case the supplier info are on the company and the partner_id in the context belongs to the company (e.g. creates quotation with a contact of the company).
Fixes #1219
2014-10-02 10:59:18 +02:00
Denis Ledoux 9cc54dcd2c [FIX] product: name_search handles negative operators 2014-10-01 12:39:59 +02:00
Cedric Snauwaert 311c77bb88 [FIX] product: _compute_qty: first round before ceiling, to avoid pathological cases
Fixes problem when we try to sell 12 units of a product and change it to 1 dozen,
the algorithm was then trying to recompute the original amount and was getting
12,0000048 as a result which was then passed to the ceiling method, getting 13.0!

See also previous commit and issue #1125, PR #1126
2014-09-24 17:11:26 +02:00
Thomas Groutars 397e83554b [FIX] product: make sure unlinked product still exists
When uninstalling/updating a module, we may execute unlink method on product.template before product.product. In such cases, the product is already removed after removeing the template (_inherits) and the chained unlink of the product would fail (traceback when browsing).
2014-08-18 10:37:03 +02:00
Martin Trigaux 8f43b749f4 [FIX] product: when duplicating a product, keep the language in the context
At the time of the context_wo_lang patch (7.0 revision 6577), the orm did not keep the language in copy_data, this patch intended to be more consistent.
Since server revision 5146 7.0, the new behaviour is to use the translated version in copy_data. Removign this change will be more consistent with the orm.

The expected behaviour is now the following:
In user lang: translated product name + translated '(copy)'
In other lang: same as original product

lp bug: https://launchpad.net/bugs/1159913 fixed

bzr revid: mat@openerp.com-20140508134937-7cbja3vsv311z5j4
2014-05-08 15:49:37 +02:00
Denis Ledoux 12eb157397 [FIX] product: price computation failed when for pricelists based on Cost price for non-employee users
bzr revid: dle@openerp.com-20140425125507-njfyl1r6wn11vqwx
2014-04-25 14:55:07 +02:00
Martin Trigaux 1967b6ce19 [FIX] product: when converting unit of mesures, round above instead of mathematical rounding
bzr revid: mat@openerp.com-20140305171456-goo7on3ncfihu0wu
2014-03-05 18:14:56 +01:00
Martin Trigaux d241afa6bd [FIX] product: pass count argument to super call for search (opw #585031)
bzr revid: mat@openerp.com-20130909140414-7mndwgkbwntgcgnj
2013-09-09 16:04:14 +02:00
Olivier Dony 6de0051315 [FIX] product: support string values for context `pricelist` key when computing prices
As of v7 search views will replace the value of any `self`
      literal in a @context attribute by the name of the
      record, whereas it used to be its ID.
      This means that the `Pricelist` filter used to display
      the product list with a specific pricelist would not
      work anymore.
      
      The fix requires a rather hackish name_search()
      override for product.pricelist because the display
      name of pricelists includes their currency, while
      that could be a valid name for a pricelist too.
      
      To avoid side-effects the name_search() override
      only picks up the special case used by the
      product.product._product_price() method when it
      tries to apply the context pricelist, that is
      with operator explicitly set to `=` and no extra
      domain `args`.

lp bug: https://launchpad.net/bugs/1178835 fixed

bzr revid: odo@openerp.com-20130906155047-7dmozy2jpe1ca1p2
2013-09-06 17:50:47 +02:00
Chris Biersbach 0e7569ef31 [FIX] product: the search method now passes the count argument correctly in the super call
bzr revid: cbi@openerp.com-20130305083513-xcyg1uyal53q914h
2013-03-05 09:35:13 +01:00
kirti savalia (OpenERP) 7d9edcc3c0 [IMP]: improve the string name according the given suggestion on the mp
bzr revid: ksa@tinyerp.com-20130122050057-fqyw4me7cj501xwn
2013-01-22 10:30:57 +05:30
kirti savalia (OpenERP) 197a10f53d [FIX]:When apply advance search confusing with the name field because one is name and another is name template so change in the string for the template
bzr revid: ksa@tinyerp.com-20130121113147-8cef58mtkeolxpkk
2013-01-21 17:01:47 +05:30
Thibault Delavallée be97933e77 [FIX] product: unlinking products was not possible due to already-deleted product that leads to a crash, therefore reverting the unlink.
bzr revid: tde@openerp.com-20130325153706-kykjhcaaw0z8tm23
2013-03-25 16:37:06 +01:00
Fabien Pinckaers 41f7f27881 [IMP] several subtype fixes
bzr revid: fp@tinyerp.com-20121218220617-d6ebdlkf1facw4x8
2012-12-18 23:06:17 +01:00
Vo Minh Thu 6072fd11af [MERGE] merged trunk.
bzr revid: vmt@openerp.com-20121210111654-0pm3pupnqqeip52n
2012-12-10 12:16:54 +01:00
Fabien Pinckaers 5c98593604 [IMP] fields name
bzr revid: fp@tinyerp.com-20121208104558-2jr4j84go4gcemrb
2012-12-08 11:45:58 +01:00
Vo Minh Thu e7f4891d46 [IMP] use the openerp namespace.
bzr revid: vmt@openerp.com-20121206145632-0h1coh5aaem65wsy
2012-12-06 15:56:32 +01:00
Bhumi Thakkar (Open ERP) 149525095c [IMP] Replaced String.
bzr revid: bth@tinyerp.com-20121205090114-8xq7fsntg4xn3dzr
2012-12-05 14:31:14 +05:30
Bhumi Thakkar (Open ERP) 39470414b0 [IMP]String Replaced Invoiced to Invoice Ratio and Given string to currency_id field.
bzr revid: bth@tinyerp.com-20121205083731-vuyi112ouewch5iw
2012-12-05 14:07:31 +05:30
Rucha (Open ERP) ca668a8acb [MERGE]: Merged with latest trunk-addons
bzr revid: rpa@tinyerp.com-20121130055252-9lu0qeabe2zcndcj
2012-11-30 11:22:52 +05:30
Quentin (OpenERP) 7a50367e84 [IMP] account: optimized the account invoice analysis report to lower the response time. Removed the fields due_delay and delay_to_pay that were the reasons of the bad performances besides being a bit useless and having wrong values computed
bzr revid: qdp-launchpad@openerp.com-20121129101228-6cxv07svxnbabfr0
2012-11-29 11:12:28 +01:00
Saurang Suthar ec06e58bb4 [IMP]product:renamed label Partners by Supplier of form which is opened on clicking in Add an Item in o2m suppliers in procurement tab of product form
bzr revid: ssu@tinyerp.com-20121126121335-b04ny0j1lwcr200j
2012-11-26 17:43:35 +05:30
Olivier Dony f5f6547fa7 [MERGE] Sync with trunk
bzr revid: odo@openerp.com-20121113164544-21tmr4bmpt2n1mfl
2012-11-13 17:45:44 +01:00
Fabien Pinckaers e4b64624e4 [MERGE] fix limit=None name_search on products
bzr revid: fp@tinyerp.com-20121113080350-j3n5bc9rw4ocabs1
2012-11-13 09:03:50 +01:00
Olivier Dony c9d5148991 [MERGE] Sync with trunk
bzr revid: odo@openerp.com-20121107114202-mt3gny8e2497m7qf
2012-11-07 12:42:02 +01:00
Fabien Pinckaers cd68364301 [MERGE] English typos
bzr revid: fp@openerp.com-20121102173407-umicel4287htim14
2012-11-02 18:34:07 +01:00
Somesh Khare(OpenERP) e519b2b9dc [FIX]product: when you search the product the limit into the name_search() goes None
bzr revid: mma@tinyerp.com-20121102084004-af7m8wlov3w627ei
2012-11-02 14:10:04 +05:30
Vijaykumar Baladaniya 1fc8b2e611 [IMP]Improve tool tip.
bzr revid: vba@tinyerp.com-20121031072758-niyxbgdzih79mln1
2012-10-31 12:57:58 +05:30
Vijaykumar Baladaniya b32662bca6 [IMP]change the spelling mistakes.
bzr revid: vba@tinyerp.com-20121031045027-ywkukcwz0cl5224o
2012-10-31 10:20:27 +05:30
Vijaykumar Baladaniya 510be6595c Improve tooltip.
bzr revid: vba@tinyerp.com-20121030131401-hf7oonmt0nkwfi1y
2012-10-30 18:44:01 +05:30
Vijaykumar Baladaniya 7850a91339 [IMP]Improve a tooltip.
bzr revid: vba@tinyerp.com-20121023130242-pu2o7e9x7lpr7g36
2012-10-23 18:32:42 +05:30
Mayur Maheshwari (OpenERP) 604f6f8b09 [IMP]product: improve tool-tip
bzr revid: mma@tinyerp.com-20121018085142-c8g4v72xlf7rmfne
2012-10-18 14:21:42 +05:30
Mayur Maheshwari (OpenERP) b26d5a8877 [IMP]product,stock,account : improve tool-tip and also improve product category form view and related inherited view
bzr revid: mma@tinyerp.com-20121018072456-v7f3roq58djtc2e8
2012-10-18 12:54:56 +05:30
Olivier Dony b42801595e [IMP] product.uom: support name_create, allows EDI import to work silently
bzr revid: odo@openerp.com-20121017162855-dkrr07bldsnc6f5s
2012-10-17 18:28:55 +02:00
Fabien Pinckaers d95f09a3b2 [IMP] UoM useability
bzr revid: fp@tinyerp.com-20121013100905-nsljyzxuzg2omoct
2012-10-13 12:09:05 +02:00
Harry (OpenERP) a4a339dfa9 [FIX] product: string of factor fields in uom
bzr revid: hmo@tinyerp.com-20121012104706-0eaxbacnrx52bpl4
2012-10-12 16:17:06 +05:30
Harry (OpenERP) bfff63118c [IMP] product: new widget for UOMFactor
bzr revid: hmo@tinyerp.com-20121012102708-weeno36hl33ysd9a
2012-10-12 15:57:08 +05:30
Harry (OpenERP) bfba3deb93 [MERGE]
bzr revid: hmo@tinyerp.com-20121012085357-9h4kw3ozaq29z7ex
2012-10-12 14:23:57 +05:30
Tejas Tank 03eb5a002a [Fix] Create a functional field : reference_uom_id.
bzr revid: tta@openerp.com-20121011124040-egs4a1ds7w7dc9fa
2012-10-11 18:10:40 +05:30
Tejas Tank c22440e5f4 [Fix] Set right margin and corrected indentation.
bzr revid: tta@openerp.com-20121009091818-k4wi2eio1spd98x7
2012-10-09 14:48:18 +05:30
Tejas Tank 90079f6752 [FIX]Corrected indentation issue.
bzr revid: tta@openerp.com-20121009062305-kxsxabgrjrzz5gr3
2012-10-09 11:53:05 +05:30
Tejas Tank 5fe8e1e1a6 [IMP] Refine form view layout for UOM.
bzr revid: tta@openerp.com-20121008071625-yaeo8ogvlajw7k7r
2012-10-08 12:46:25 +05:30
Mayur Maheshwari (OpenERP) d57703fa87 [FIX]product : improve tooltip
bzr revid: mma@tinyerp.com-20121004100306-k82sewubhw508cgz
2012-10-04 15:33:06 +05:30
Mayur Maheshwari (OpenERP) cc331b802c [FIX]product : remove sale_dealy from product.template
bzr revid: mma@tinyerp.com-20121003114328-9ufkrn1d84vyny5q
2012-10-03 17:13:28 +05:30
Mayur Maheshwari (OpenERP) be42204adf [FIX]product : remove lemda from defaults
bzr revid: mma@tinyerp.com-20121003113846-mjjtghoxdu8h2nq8
2012-10-03 17:08:46 +05:30
Mayur Maheshwari (OpenERP) a4da52f7f0 [FIX]hr_expense : remove purchase_ok
bzr revid: mma@tinyerp.com-20121003112746-sw2ycbrysn65hfjz
2012-10-03 16:57:46 +05:30
Randhir Mayatra (OpenERP) f73bb9d592 [MERGE]merge with lp:~openerp-dev/openobject-addons/trunk-addons_issue12_product-mma
bzr revid: rma@tinyerp.com-20121003110705-oz8yk0sx8gog20ve
2012-10-03 16:37:05 +05:30
Randhir Mayatra (OpenERP) fbd443a66e [MERGE] merge with addons
bzr revid: rma@tinyerp.com-20121003103503-5rdpwbp2cecfmna0
2012-10-03 16:05:03 +05:30
Mayur Maheshwari (OpenERP) 5eb45dc4a8 [MERGE]: Merge with lp:openobject-addons
bzr revid: mma@tinyerp.com-20121003101055-2phrkr59lefzu4co
2012-10-03 15:40:55 +05:30