Commit Graph

66 Commits

Author SHA1 Message Date
Holger Hans Peter Freyther 95eb5043e2 https: Point to the logo using https instead of http
This is needed to not have paypal's checkout patch fetch from
a http source during checkout.
2014-01-18 15:54:53 +01:00
Holger Hans Peter Freyther 04fa7f9c40 Fix: Do not redirect to paypal if there is an error on the Order model
In case there is a validation issue with the Order we do not want to
redirect to the paypal page.
2013-01-31 22:52:27 +01:00
Holger Hans Peter Freyther 143ffe4da1 paypal: Do no guess the state as this can cuase validation errors
States are not common to use for addresses in Germany, a customer
was putting 'DE' into the state, this is the abbreviation for
Delaware. When trying to save the Address record the validation failed
as the country of the address and the country of the state do not
match at all.

Fix it by always using the text form for addresses returned by
PayPal. Make sure that the state is never blank.
2013-01-30 21:50:59 +01:00
Holger Hans Peter Freyther d2db33ad1d address: Set a dummy zipcode if none was returned from paypal
This is an attempt to fix a case where paypal does not provide any
zipcode back to us and then validation is failing. It is difficult
to test misconduct of paypal.
2013-01-30 21:50:27 +01:00
Holger Hans Peter Freyther 4883afb265 paypal: Add hack to accept paypal from US and Germany...
we had to make the State mandantory for US customers using Paypal,
but now for EU members we don't get a state and fail to save the
order.

Move it down as we might overwrite it
2013-01-30 21:50:12 +01:00
Holger Hans Peter Freyther dec84157ba address: Do not use the paypal shipping address to override things
This extension overrides the shipping address with the one supplied
by paypal. It is not what we want! Store the paypal address in a dedicated
field in case we will ever need it.
2013-01-30 21:50:12 +01:00
Holger Hans Peter Freyther a272ee6df7 paypal: Do not allow to enter user comments
The storing of this is broken, no need to cause issues with
users trying to send us message this way.
2013-01-30 19:16:58 +01:00
Jeff Dutil 732a85dc88 Fix passing order not self shipping calculator. 2013-01-05 16:08:46 -05:00
Jeff Dutil dc6bccfad3 Fixes bugs where wrong payment method is referenced, and shipping has been already been applied when checking out from cart.
Conflicts:
	app/controllers/spree/checkout_controller_decorator.rb
2013-01-04 03:06:26 -05:00
Jeff Dutil 798ea648fe Pass @order not self. [Fixes #103] 2012-11-30 18:04:11 -05:00
Jeff Dutil 00b170eed2 Fix calls for spree root url. [fix #102] 2012-11-26 22:01:24 -05:00
Jeff Dutil c7f55c4941 Only look to current users addresses when possible. Such as in conjunction with spree_address_book extension. [fix #101] 2012-11-26 07:35:28 -05:00
Jeff Dutil 63ff2c99bf Only pass billing address details if they are present. 2012-11-19 07:56:15 -05:00
Joe Sak 6b82df21af Send billing address to Paypal, so Customer doesn't have to enter twice 2012-11-19 07:52:35 -05:00
Jeff Dutil 50684bbb1d Set flash[:commerce_tracking] on success, and string HTML tags from product name and description sent to PayPal. [Fixes #85 #76] 2012-11-19 07:41:13 -05:00
Jeff Dutil 4725846db0 Parameterize gateway error text for i18n key. [Fix #80] 2012-11-19 07:34:58 -05:00
Jeff Dutil 5a4f2fe47d Fixes broken specs except for a couple relying on open spree pull requests. 2012-11-19 06:45:08 -05:00
Vladimir Fedorov ca60407d5d Added PayPal Instant Update feature 2012-11-13 10:24:42 -05:00
Jeff Dutil 56930b93aa Fix current user method for Spree 1.2.x 2012-11-12 17:49:27 -05:00
Ryan Bigg 5a048d4449 Strip all potential blank characters from Spree::Config[:site_url] inside asset_url method 2012-11-07 09:27:08 +11:00
Brian Quinn a95329aa9e cleanup 2012-11-06 19:43:17 +00:00
Andrew Hooker 405acab005 Handling coupon codes properly 2012-11-06 19:37:18 +00:00
Roman Smirnov dd7834bd2f Minor improvement for case when ship_address[state] is nil or empty 2012-10-16 15:23:20 +04:00
Brian Quinn 8ca407b1e4 Updated to work with 1-1 proper 2012-07-20 11:23:01 +01:00
Brian Quinn 042e013be7 Merge remote-tracking branch 'sbounmy/custom'
Conflicts:
	Gemfile
2012-07-17 12:58:42 +01:00
edslocomb ce3d71193f ActiveMerchant::PaypalExpressGateway does nothing with item[:sku], instead we should set the confusingly-named item[:number] from the underlying Paypal api: https://cms.paypal.com/us/cgi-bin/?cmd=_render-content&content_ID=developer/e_howto_api_ECCustomizing 2012-07-17 10:01:35 +10:00
Josh Shupack d9873ff63f fixed bug where state not found is Paypal returns state abbr in lowercase
Fixes #71
2012-07-16 13:34:49 +10:00
Bounmy Stephane 3d5af5bdaf set completed_at 2012-05-25 21:26:19 +02:00
Bounmy Stephane 4b1def8643 fixed consume_users_credit call 2012-05-25 20:44:20 +02:00
Bounmy Stephane 4ee142bc7f fixed css and respond_to? 2012-05-25 19:50:05 +02:00
Bounmy Stephane bf00623328 fixed paypal_confirm order state 2012-05-24 23:02:15 +02:00
Bounmy Stephane 4b8dbdbfeb start adding integration tests 2012-05-24 22:33:17 +02:00
Bounmy Stephane 06a81e1c64 rendering view in controller specs improved paypal confirm template 2012-05-24 21:15:02 +02:00
Bounmy Stephane 63b2c21438 private method! 2012-05-24 00:48:31 +02:00
Bounmy Stephane 287eee48a1 dirty fix store_credit_callback 2012-05-22 23:26:11 +02:00
Bounmy Stephane 9d2c8fda03 update order on paypal checkout 2012-05-21 23:01:52 +02:00
Scott Wagner 09df0aaf4a Update app/controllers/spree/checkout_controller_decorator.rb 2012-05-16 13:02:48 -07:00
Steve Root 1a59c10d19 missing comma 2012-05-12 11:08:09 +01:00
Steve Root 4bc99e2fb7 Reworked based on Radar's directions 2012-05-12 11:00:57 +01:00
Steve Root e4fe2f9129 fixes asset_url failing if logo is absolute url 2012-05-10 12:37:32 +01:00
Ryan Bigg 7e018fb2d2 Need to call after_complete state callback so that session[:order_id] is nil'd after successful order. Related to #48. 2012-05-02 10:38:51 -05:00
Ryan Bigg 5ab0b9d6be Explicitly set order state to complete + call finalize, rather than jumping through all the states
Previously, the checkout controller decorator here would go through each of the order states and call @order.update! for each state, as well as the order callback.

This is unecessary for PayPal transactions.

All that needs to happen here is that the state is put into the complete state and the order is finalized.

Fixes #48.

Finally.
2012-05-02 10:26:01 -05:00
Ryan Bigg e539e1d5cf Revert "Fix some attr_accessible problems to do with log entries, payments and PaypalAccount"
Already done by Andrew.

This reverts commit 51caa03295.
2012-05-02 07:32:52 -05:00
Ryan Bigg 51caa03295 Fix some attr_accessible problems to do with log entries, payments and PaypalAccount 2012-05-02 07:31:55 -05:00
Chris Wise f8e239e3c1 corrected a misnamed payment event from fail! to failure! 2012-04-13 10:09:21 -04:00
Chris Wise 6fbc63116a fixed the opts and items hashes that are sent to PayPal to only show eligible promotions and to use existing Order methods for tax and shipping 2012-04-11 11:27:28 -04:00
Bounmy Stephane c1f8854e15 cache payment_method and can now set paypal's landing page by setting allow_guest_checkout 2012-04-11 11:21:40 -04:00
Bounmy Stephane 98f99ab3d2 fixed header_image and locale using I18n.locale set from set_user_language 2012-04-11 11:21:39 -04:00
Bounmy Stephane 4511907f4f cancel_return_url returns to checkout payment instead of edit order url 2012-04-11 11:21:39 -04:00
Bounmy Stephane ba2fc9d8c7 untrack gemfile.lock + fix spree namespacing model 2012-04-11 11:21:39 -04:00