From 259b65b5ac0f3505d9d38f7d3aaf238439d9ef46 Mon Sep 17 00:00:00 2001 From: Lucas Stach Date: Fri, 7 Feb 2014 09:48:51 +0100 Subject: [PATCH] usb: dfu: fix error path to avoid NULL ptr deref Signed-off-by: Lucas Stach Signed-off-by: Sascha Hauer --- drivers/usb/gadget/dfu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/dfu.c b/drivers/usb/gadget/dfu.c index e15fc41b8..4d4c347ab 100644 --- a/drivers/usb/gadget/dfu.c +++ b/drivers/usb/gadget/dfu.c @@ -597,8 +597,10 @@ static int dfu_bind_config(struct usb_configuration *c) func->disable = dfu_disable; dfu->dnreq = usb_ep_alloc_request(c->cdev->gadget->ep0); - if (!dfu->dnreq) + if (!dfu->dnreq) { printf("usb_ep_alloc_request failed\n"); + goto out; + } dfu->dnreq->buf = dma_alloc(CONFIG_USBD_DFU_XFER_SIZE); dfu->dnreq->complete = dn_complete; dfu->dnreq->zero = 0;